mirror of
https://github.com/dart-lang/sdk
synced 2024-09-15 22:00:09 +00:00
ddfc98337b
This is a reland of b6dc4dad4d
TEST=ci
Original change's description:
> [vm/aot] Avoid using most Code objects in stack traces with --dwarf-stack-traces
>
> The following changes are done in preparation for the removal of Code
> objects in AOT with --dwarf-stack-traces:
>
> * Stack trace objects are extended to hold uword PCs (which may not
> fit into Smi range).
>
> * Scanning stack frames in GC (StackFrame::VisitObjectPointers)
> now avoids using Code objects.
> In order to find CompressedStackMaps it now calls
> ReversePc::FindCompressedStackMaps.
>
> * Singleton Code object (StubCode::UnknownDartCode()) is prepared as
> a replacement for Code objects in stack traces. It has
> PayloadStart() == 0 and Size() == kUwordMax so it includes
> arbitrary PCs.
>
> * In --dwarf-stack-traces mode, most Code objects obtained from stack
> frames are replaced with StubCode::UnknownDartCode().
> This simulates future behavior of ReversePc::Lookup when Code objects
> will be removed.
>
> Issue: https://github.com/dart-lang/sdk/issues/44852
> Change-Id: I7cec7b8b9396c9cfeca3c256a412ba4e82a7e0c4
> TEST=ci
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182720
> Commit-Queue: Alexander Markov <alexmarkov@google.com>
> Reviewed-by: Tess Strickland <sstrickl@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
Change-Id: Ia2fc4672a085cd963b7fc103369851df3603590c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186202
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
156 lines
5.4 KiB
C++
156 lines
5.4 KiB
C++
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
|
|
#if defined(TARGET_ARCH_ARM)
|
|
|
|
#include "vm/code_patcher.h"
|
|
|
|
#include "vm/instructions.h"
|
|
#include "vm/object.h"
|
|
|
|
namespace dart {
|
|
|
|
CodePtr CodePatcher::GetStaticCallTargetAt(uword return_address,
|
|
const Code& code) {
|
|
ASSERT(code.ContainsInstructionAt(return_address));
|
|
CallPattern call(return_address, code);
|
|
return call.TargetCode();
|
|
}
|
|
|
|
void CodePatcher::PatchStaticCallAt(uword return_address,
|
|
const Code& code,
|
|
const Code& new_target) {
|
|
ASSERT(code.ContainsInstructionAt(return_address));
|
|
CallPattern call(return_address, code);
|
|
call.SetTargetCode(new_target);
|
|
}
|
|
|
|
void CodePatcher::InsertDeoptimizationCallAt(uword start) {
|
|
UNREACHABLE();
|
|
}
|
|
|
|
CodePtr CodePatcher::GetInstanceCallAt(uword return_address,
|
|
const Code& caller_code,
|
|
Object* data) {
|
|
ASSERT(caller_code.ContainsInstructionAt(return_address));
|
|
ICCallPattern call(return_address, caller_code);
|
|
if (data != NULL) {
|
|
*data = call.Data();
|
|
}
|
|
return call.TargetCode();
|
|
}
|
|
|
|
void CodePatcher::PatchInstanceCallAt(uword return_address,
|
|
const Code& caller_code,
|
|
const Object& data,
|
|
const Code& target) {
|
|
auto thread = Thread::Current();
|
|
thread->isolate_group()->RunWithStoppedMutators([&]() {
|
|
PatchInstanceCallAtWithMutatorsStopped(thread, return_address, caller_code,
|
|
data, target);
|
|
});
|
|
}
|
|
|
|
void CodePatcher::PatchInstanceCallAtWithMutatorsStopped(
|
|
Thread* thread,
|
|
uword return_address,
|
|
const Code& caller_code,
|
|
const Object& data,
|
|
const Code& target) {
|
|
ASSERT(caller_code.ContainsInstructionAt(return_address));
|
|
ICCallPattern call(return_address, caller_code);
|
|
call.SetData(data);
|
|
call.SetTargetCode(target);
|
|
}
|
|
|
|
FunctionPtr CodePatcher::GetUnoptimizedStaticCallAt(uword return_address,
|
|
const Code& caller_code,
|
|
ICData* ic_data_result) {
|
|
ASSERT(caller_code.ContainsInstructionAt(return_address));
|
|
ICCallPattern static_call(return_address, caller_code);
|
|
ICData& ic_data = ICData::Handle();
|
|
ic_data ^= static_call.Data();
|
|
if (ic_data_result != NULL) {
|
|
*ic_data_result = ic_data.ptr();
|
|
}
|
|
return ic_data.GetTargetAt(0);
|
|
}
|
|
|
|
void CodePatcher::PatchSwitchableCallAt(uword return_address,
|
|
const Code& caller_code,
|
|
const Object& data,
|
|
const Code& target) {
|
|
auto thread = Thread::Current();
|
|
// Ensure all threads are suspended as we update data and target pair.
|
|
thread->isolate_group()->RunWithStoppedMutators([&]() {
|
|
PatchSwitchableCallAtWithMutatorsStopped(thread, return_address,
|
|
caller_code, data, target);
|
|
});
|
|
}
|
|
|
|
void CodePatcher::PatchSwitchableCallAtWithMutatorsStopped(
|
|
Thread* thread,
|
|
uword return_address,
|
|
const Code& caller_code,
|
|
const Object& data,
|
|
const Code& target) {
|
|
if (FLAG_precompiled_mode && FLAG_use_bare_instructions) {
|
|
BareSwitchableCallPattern call(return_address);
|
|
call.SetData(data);
|
|
call.SetTarget(target);
|
|
} else {
|
|
SwitchableCallPattern call(return_address, caller_code);
|
|
call.SetData(data);
|
|
call.SetTarget(target);
|
|
}
|
|
}
|
|
|
|
uword CodePatcher::GetSwitchableCallTargetEntryAt(uword return_address,
|
|
const Code& caller_code) {
|
|
if (FLAG_precompiled_mode && FLAG_use_bare_instructions) {
|
|
BareSwitchableCallPattern call(return_address);
|
|
return call.target_entry();
|
|
} else {
|
|
SwitchableCallPattern call(return_address, caller_code);
|
|
return call.target_entry();
|
|
}
|
|
}
|
|
|
|
ObjectPtr CodePatcher::GetSwitchableCallDataAt(uword return_address,
|
|
const Code& caller_code) {
|
|
if (FLAG_precompiled_mode && FLAG_use_bare_instructions) {
|
|
BareSwitchableCallPattern call(return_address);
|
|
return call.data();
|
|
} else {
|
|
SwitchableCallPattern call(return_address, caller_code);
|
|
return call.data();
|
|
}
|
|
}
|
|
|
|
void CodePatcher::PatchNativeCallAt(uword return_address,
|
|
const Code& code,
|
|
NativeFunction target,
|
|
const Code& trampoline) {
|
|
Thread::Current()->isolate_group()->RunWithStoppedMutators([&]() {
|
|
ASSERT(code.ContainsInstructionAt(return_address));
|
|
NativeCallPattern call(return_address, code);
|
|
call.set_target(trampoline);
|
|
call.set_native_function(target);
|
|
});
|
|
}
|
|
|
|
CodePtr CodePatcher::GetNativeCallAt(uword return_address,
|
|
const Code& code,
|
|
NativeFunction* target) {
|
|
ASSERT(code.ContainsInstructionAt(return_address));
|
|
NativeCallPattern call(return_address, code);
|
|
*target = call.native_function();
|
|
return call.target();
|
|
}
|
|
|
|
} // namespace dart
|
|
|
|
#endif // defined TARGET_ARCH_ARM
|