dart-sdk/runtime/observatory
Bruno Leroux 2481cf76f5 [ VM / Service ] Fix 'dart:' scripts lookup
Bug: VM service `addBreakpointWithScriptUri` and `addBreakpoint` don't add valid breakpoints for code in `dart:` libraries. See #47204

This PR contains :
- a new test : 'service/break_on_dart_colon_test.dart', that checks several URIs to register breakpoints in `dart:` libs.
- a fix in `Debugger::SetBreakpointAtLineCol` to make it calls `Library::LookupScript'` with the right value for `useResolvedUri` parameter.

Fixes https://github.com/dart-lang/sdk/issues/47204

TEST=runtime/observatory/tests/service/break_on_dart_colon_test.dart

Change-Id: Id3d6722c278e3238202a9d84a0d34612b957035c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213766
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2021-09-24 01:20:38 +00:00
..
bin [vm, service, observatory] Bang Bang (My Type System Shot Me Down). 2020-10-14 18:16:27 +00:00
lib [ Service ] Test constructor tearoffs through VM service 2021-09-14 17:14:31 +00:00
tests [ VM / Service ] Fix 'dart:' scripts lookup 2021-09-24 01:20:38 +00:00
tool Use dartfmt on Observatory code 2016-09-16 06:59:51 -07:00
web [vm] Make naming more consistent when converting between handles, tagged and untagged pointers. 2021-01-15 23:32:02 +00:00
.gitignore Commit observatory's pubspec.lock to the repo 2016-09-27 14:04:47 +02:00
analysis_options.yaml [SDK] Removes non-exiting tests from .status 2021-02-04 06:46:13 +00:00
BUILD.gn [build] Remove expensive use of make_version.py for unused OBS_VER. 2021-04-26 22:51:08 +00:00
HACKING.md [ VM / Service / Observatory ] The VM service now requires an authentication code by default. 2019-04-09 22:57:29 +00:00
observatory_sources.gni [vm, service] Remove unsafe querying across threads during Isolate::PrintJSON. 2020-12-08 00:36:38 +00:00
pubspec.yaml [Observatory] Switch to Dart 2.12 and remove redundant experiment 2020-12-30 02:26:25 +00:00
update_sources.py [infra] Migrate scripts to python3 2021-04-15 10:10:20 +00:00