85f9e45434
Work towards https://github.com/dart-lang/linter/issues/4991 Here I just take all of the existing rules marked with `Category.errors` (which are not removed or deprecated), and re-examine what category or categories they fall into. I add new categories: * "binary size" (not super accurate for JS-compile apps, but "binary" is still a common industry term for the JS app that is delivered to the browser) * "documentation comment maintenance" * "error-prone" * "language feature usage" * "memory leaks" (note, different from "binary size"; mostly memory-leak related but may contain other things?) * "non-performant" * "unintentional" * "unused code" For multiple rules, I considered adding a "best practices" category too, but this also seems tragically vague. But for rules like "control_flow_in_finally", "avoid_catches_without_on_clauses", etc. Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try Change-Id: I043a509120e7347283d6ab10e8eb73859830abc0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371921 Reviewed-by: Marya Belanger <mbelanger@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> |
||
|---|---|---|
| .. | ||
| _fe_analyzer_shared | ||
| _js_interop_checks | ||
| _macros | ||
| analysis_server | ||
| analysis_server_client | ||
| analysis_server_plugin | ||
| analyzer | ||
| analyzer_cli | ||
| analyzer_plugin | ||
| analyzer_utilities | ||
| async_helper | ||
| bisect_dart | ||
| build_integration | ||
| compiler | ||
| dart2js_info | ||
| dart2js_runtime_metrics | ||
| dart2js_tools | ||
| dart2native | ||
| dart2wasm | ||
| dart_internal | ||
| dart_service_protocol_shared | ||
| dartdev | ||
| dds | ||
| dds_service_extensions | ||
| dev_compiler | ||
| dtd | ||
| dtd_impl | ||
| expect | ||
| front_end | ||
| frontend_server | ||
| heap_snapshot | ||
| js | ||
| js_ast | ||
| js_runtime | ||
| js_shared | ||
| json | ||
| kernel | ||
| language_versioning_2_12_test | ||
| linter | ||
| macros | ||
| meta | ||
| mmap | ||
| modular_test | ||
| native_stack_traces | ||
| reload_test | ||
| scrape | ||
| server_plugin | ||
| smith | ||
| sourcemap_testing | ||
| status_file | ||
| telemetry | ||
| test_runner | ||
| testing | ||
| vm | ||
| vm_service | ||
| vm_service_interface | ||
| vm_service_protos | ||
| vm_snapshot_analysis | ||
| wasm_builder | ||
| .gitignore | ||
| analysis_options.yaml | ||
| BUILD.gn | ||
| OWNERS | ||
| pkg.dart | ||
| pkg.status | ||
| README.md | ||
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency