dart-sdk/tools/bots
William Hesse 83956f4059 Revert "[infra] Add error check when adding builder data to test results."
This reverts commit 9fd914e450.

Reason for revert: There needs to be a check if this is an experimental job, or a tryjob, and accept blank fields in that case.
I meant to put it in if I made the code return 1, but forgot.

Even in this case, the results need to be returned, for tryjobs to work.


Original change's description:
> [infra] Add error check when adding builder data to test results.
> 
> Change-Id: Ia59b8dcb711839e90d222679362d145b332c45b2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107510
> Reviewed-by: Jonas Termansen <sortie@google.com>

TBR=whesse@google.com,sortie@google.com

Change-Id: I37a48d78265e9630a7c562a46083e5234abba1aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107512
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2019-06-28 16:49:40 +00:00
..
browsers Add hash for downloading Linux Chrome to tools/bots/browsers. 2018-03-16 10:35:11 +00:00
flutter Compile flutter tests via the sdk 2019-04-11 08:38:53 +00:00
__init__.py
add_fields.dart Add commit hash to results upload on builders 2018-09-12 17:15:39 +00:00
android.py
aot_smoke_tests.dart [SDK] Adds smoke test for dartaot. 2019-05-06 11:11:38 +00:00
apply_preapprovals.dart [infra] Add --apply-changelist option to apply_preapprovals. 2019-03-26 12:56:57 +00:00
bot.py
bot_utils.py [infra] Build Linux ARM architectures in tools/bots/dart_sdk.py. 2019-01-03 14:37:35 +00:00
compare_results.dart [infra] Add support for pre-approvals in approved_results.json. 2019-03-22 11:11:00 +00:00
dart2js_d8_hostchecked_tests.isolate Remove the Dart 1 tests. 2018-10-11 23:45:18 +00:00
dart2js_dump_info.py
dart_aot_test.dart [SDK] Adds smoke test for dartaot. 2019-05-06 11:11:38 +00:00
dart_sdk.py [SDK] Fix missing argument in tools/bots/dart_sdk.py 2019-05-07 07:34:33 +00:00
dart_tests.isolate Remove the Dart 1 tests. 2018-10-11 23:45:18 +00:00
dart_tests_extended.isolate
dartdoc_footer.html
ddc_tests.py Finish migrating stuff out of lib_strong. 2017-12-11 23:45:23 +00:00
extend_results.dart Revert "[infra] Add error check when adding builder data to test results." 2019-06-28 16:49:40 +00:00
find_base_commit.dart Update HttpRequest and HttpClientResponse to be Stream<Uint8List> 2019-06-27 00:21:07 +00:00
linux_distribution_support.py [infra] Add versionchecker and debianpackage to test matrix 2019-03-11 12:52:03 +00:00
pub.py
pub_integration_test.py [infra] Add debug mode support to pub_integration_test. 2018-12-21 23:47:23 +00:00
README.md [infra] Add test matrix documentation 2018-06-07 17:39:12 +00:00
results.dart Update File.openRead to return Stream<Uint8List> 2019-06-27 00:22:17 +00:00
run_android_tests.sh
test_matrix.json [infra] Add runtime_kernel target to dart-sdk-win builder 2019-06-27 12:02:45 +00:00
try_benchmarks.sh [benchmark] Add gen/kernel_service.dill to try_benchmarks.sh. 2019-06-19 09:25:03 +00:00
try_test.dart Remove use of deprecated methods and constants. 2018-07-04 17:18:06 +00:00
update_flakiness.dart [infra] Fix update_flakiness using wrong key when computing matches. 2019-03-04 13:38:29 +00:00
upload_debian_packages.py [infra] Add versionchecker and debianpackage to test matrix 2019-03-11 12:52:03 +00:00
version_checker.py

tools/bots

This folder contains scripts and configuration files used by Dart's continuous integration and testing infrastructure.

Test matrix

The file test_matrix.json defines the test configurations run by Dart's CI infrastructure. Changes to the test matrix affect all builds that include them.

Structure

The test matrix is a JSON document and consists of the "filesets" object and the "configurations" array.

The file sets define files and/or directories that need to be present for a test configuration at runtime. Any directory specified will be included along with its subdirectories recursively. Directory names must have a / at the end. All paths are relative to the SDK checkout's root directory.

"filesets": {
  "a_fileset_name": [
    "a/directory/",
    "a/file"
  ],
  "another_fileset_name": [
    "another/directory/",
    "another/file"
  ]
}

The builder configurations describe all test configurations a specific builder must execute. Each builder configuration is an object that specifies which builders it applies to, defines the build steps for the builders, and some additional metadata. Only one builder configuration can apply to a builder.

"configurations": [
  {
    "builders": [
      "a-builder",
      "another-builder"
    ],
    "meta": {
      "description": "Description of this configuration."
    },
    "steps": [
    ]
  }
]

Each step is an object and must have a name. A step may also specify a script to run instead of the default script: tools/test.py. Additional arguments may be specified. These arguments will be passed to the script.

"steps": [
  {
    "name": "build it",
    "script": "tools/build.py",
    "arguments": ["--a-flag", "target", "another_target"]
  },
  {
    "name": "test it",
  }
]

A step using the default script may also be sharded across many machines using the "shards" parameter. If a step is sharded, it must specify a "fileset". Only the files and directories defined by the file set will be available to the script when it's running on a shard.

{
  "name": "shard the tests",
  "shards": 10,
  "fileset": "a_fileset_name"
}

Builder name parsing

The builder names are split by '-' and each part is then examined if it is an option. Options can be runtimes (e.g. "chrome"), architectures (e.g. x64) and operating system families (e.g. win). For each valid option, additional arguments are passed to the tools/test.py and tools/build.py scripts.

Adding a new builder

To add a builder:

  1. Decide on a name.
  2. Add the builder name to a new or existing configuration.
  3. File an issue labelled "area-infrastructure" to get your builder activated.

Testing a new or modified builder

Builders can be tested using a tool called led that is included in depot_tools. Replace buildername and CL number with the correct values and run:

led get-builder luci.dart.ci:<builder name> | \
led edit-cr-cl 'https://dart-review.googlesource.com/c/<cl number>' | \
led launch

Adding a builder to the commit queue

For now, file an issue labeled "area-infrastructure" to get your builder added to the commit queue.

Glossary

Builder

A builder has a name and defines the steps the need to be run when it is executed by a bot. In general, a builder defines how to build and test software.

Bot

A physical or virtual machine (or even a docker container) that executes all commands it receives. Often, these commands are the steps defined by a builder.

Sharding

Sharded steps copy all files in a file set to as many bots as specified and runs the same command on all of the shards. Each shard has a shard number. The shard number and the total number of shards are passed as arguments to the command. The command is then responsible for running a subset of its work on each shard based on these arguments.