dart-sdk/sdk
Jonas Termansen daa400bada [sdk] Fix all uses of the view() constructor to always use offsetInBytes.
The list being viewed can sometimes itself be a sublist view, but the
default view() constructor doesn't take that into account, and instead the
caller needs to be aware of the case. This change makes all such uses use
offsetInBytes, even in cases that's not needed, so it's trivial to audit
that it's always used correctly. In the cases it's not needed, it just gets
the value 0 and it's a no-operation. In the cases it's needed, it fixes a
bug, such as in _WebSocketProtocolTransformer.add().

Closes #39589

Change-Id: I6e9bd5510f48ce378bdec2c64b56fe789dfb27ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127165
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
2019-12-06 10:37:00 +00:00
..
bin [vm] Remove deprecated (and untested) ARMv5 support from the VM 2019-10-23 14:44:33 +00:00
lib [sdk] Fix all uses of the view() constructor to always use offsetInBytes. 2019-12-06 10:37:00 +00:00
api_readme.md Update API homepage to link to dart.dev, not dartlang.org 2019-05-21 02:51:59 +00:00
BUILD.gn (ddc) Fix deps tracking for the ddc sdk. 2019-11-23 00:21:58 +00:00