mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 04:16:51 +00:00
b464fc9037
This reverts commitcd2c566bcf
. Reason for revert: Updating to not remove field used by Flutter engine. Original change's description: > Revert "Tweak `expect.dart` library." > > This reverts commitff5f391c0a
. > > Reason for revert: The expect library is used by Flutter engine, and some of its tests use assertStatementsEnabled. There should be a migration path that doesn't require an atomic change, like adding the replacement api before removing the old one. > > Original change's description: > > Tweak `expect.dart` library. > > > > Make API more consistent for a few methods. > > Reduce the number of language features used in tests: > > * Never iterating an iterable, always converting it > > using `.toList()` first and iterating using indices > > (fx `setEquals`). > > Also require a `List` in places where an `Iterable` > > wasn't necessary. > > * Avoid doing complicated computations that are also > > used for the error message. Do simple check first, > > then recompute to get better error messages > > (fx `allDistinct`). > > > > Renamed some rarely used members for consistency > > (`stringContainsInOrder`->`containsInOrder`, > > where other string-contains functions just start > > with `contains`, and `containsOneOf` -> `containsAny` > > to match `Iterable.any` phrasing, and also it accepts > > if containing at least one, not precisely one.) > > > > Removed a function that wasn't used anywhere. > > > > Moved `assertStatementsEnabled` to `variations.dart` as `asserts`. > > Removed `typeAssertionsEnabled` and `checkedModeEnabled`. The former used in one place, where it was replaced with `checkedImplicitDowncasts` from `variations.dart`, the latter wasn't used anywhere. > > > > Deprecates `package:expect/minitest.dart`. It was never intended > > to be used for new tests, only as a help to convert existing tests > > written against `package:unit_test`. > > All existing imports marked as `// ignore: deprecated_member_use`. > > > > Change-Id: I07e21d4c0f3ccf11b82ee34af2668fdbb22264d2 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352360 > > Reviewed-by: Slava Egorov <vegorov@google.com> > > Reviewed-by: Ömer Ağacan <omersa@google.com> > > Reviewed-by: Nate Bosch <nbosch@google.com> > > Reviewed-by: Stephen Adams <sra@google.com> > > Commit-Queue: Lasse Nielsen <lrn@google.com> > > Change-Id: I360b4347470a0bb2b63c3108e2b83ee2a771bf3f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362020 > Reviewed-by: Nate Bosch <nbosch@google.com> > Reviewed-by: Ömer Ağacan <omersa@google.com> > Reviewed-by: Stephen Adams <sra@google.com> > Reviewed-by: Leaf Petersen <leafp@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: William Hesse <whesse@google.com> CoreLibraryReviewExempt: Reland Change-Id: I53db40edc0733842a008839c3913d51c885e39ab Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362502 Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Ömer Ağacan <omersa@google.com> Reviewed-by: Slava Egorov <vegorov@google.com> Reviewed-by: William Hesse <whesse@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com>
136 lines
5.2 KiB
Dart
136 lines
5.2 KiB
Dart
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
// Tests that late fields are properly reset after hot restarts.
|
|
|
|
// Requirements=nnbd
|
|
|
|
import 'dart:_runtime' as dart show hotRestart, resetFields;
|
|
|
|
import 'package:expect/expect.dart';
|
|
|
|
late String noInitializer;
|
|
late int withInitializer = 1;
|
|
|
|
class Lates {
|
|
static late String noInitializer;
|
|
static late int withInitializer = 2;
|
|
}
|
|
|
|
class LatesGeneric<T> {
|
|
static late String noInitializer;
|
|
static late int withInitializer = 3;
|
|
}
|
|
|
|
main() {
|
|
// Read this static field first to avoid interference with other reset counts.
|
|
var weakNullSafety = hasUnsoundNullSafety;
|
|
|
|
// The first call of `Expect.throws` involves type tests that initialize
|
|
// values in the runtime type system that will read static fields. After
|
|
// initialization fields are never read again (even after a hot restart)
|
|
// so we perform the first call here before we start counting field resets.
|
|
Expect.throws(() => throw 'foo');
|
|
|
|
dart.hotRestart();
|
|
|
|
// Count the number of reset fields triggered by a call to `Expect.throws`
|
|
// after every hot restart. This value is used as an offset in expectations
|
|
// below. (Update the expectation below if the number changes.)
|
|
Expect.throws(() => throw 'foo');
|
|
var expectThrowsResetFieldCount = dart.resetFields.length;
|
|
Expect.equals(0, expectThrowsResetFieldCount);
|
|
|
|
dart.hotRestart();
|
|
|
|
// Set uninitialized static late fields. Avoid calling getters for these
|
|
// statics to ensure they are reset even if they are never accessed.
|
|
noInitializer = 'set via setter';
|
|
Lates.noInitializer = 'Lates set via setter';
|
|
LatesGeneric.noInitializer = 'LatesGeneric set via setter';
|
|
|
|
// Initialized statics should contain their values.
|
|
Expect.equals(1, withInitializer);
|
|
Expect.equals(2, Lates.withInitializer);
|
|
Expect.equals(3, LatesGeneric.withInitializer);
|
|
|
|
// In weak null safety the late field lowering introduces a second static
|
|
// field that tracks if late field has been initialized thus doubling the
|
|
// number of expected resets.
|
|
//
|
|
// In sound null safety non-nullable fields don't require the extra static to
|
|
// track initialization because null is used as a sentinel value.
|
|
//
|
|
// Weak Null Safety - 12 total field resets
|
|
// - 3 isSet write/resets for uninitialized field writes.
|
|
// - 3 write/resets for the actual uninitialized field writes.
|
|
// - 3 isSet reads/resets for initialized field reads.
|
|
// - 3 reads/resets for the actual initialized field reads.
|
|
//
|
|
// Sound Null Safety - 6 total field resets:
|
|
// - 3 write/resets for the actual uninitialized field writes.
|
|
// - 3 reads/resets for the actual initialized field reads.
|
|
var expectedResets = weakNullSafety ? 12 : 6;
|
|
Expect.equals(expectedResets, dart.resetFields.length);
|
|
|
|
dart.hotRestart();
|
|
|
|
// Late statics should throw on get when not initialized.
|
|
Expect.throws(() => noInitializer);
|
|
Expect.throws(() => Lates.noInitializer);
|
|
Expect.throws(() => LatesGeneric.noInitializer);
|
|
|
|
// Set uninitialized static late fields again.
|
|
noInitializer = 'set via setter';
|
|
Lates.noInitializer = 'Lates set via setter';
|
|
LatesGeneric.noInitializer = 'LatesGeneric set via setter';
|
|
|
|
// All statics should contain their set values.
|
|
Expect.equals('set via setter', noInitializer);
|
|
Expect.equals('Lates set via setter', Lates.noInitializer);
|
|
Expect.equals('LatesGeneric set via setter', LatesGeneric.noInitializer);
|
|
Expect.equals(1, withInitializer);
|
|
Expect.equals(2, Lates.withInitializer);
|
|
Expect.equals(3, LatesGeneric.withInitializer);
|
|
|
|
// Weak Null Safety - 12 total field resets
|
|
// - 3 isSet write/resets for uninitialized field writes.
|
|
// - 3 write/resets for the actual uninitialized field writes.
|
|
// - 3 isSet reads/resets for initialized field reads.
|
|
// - 3 reads/resets for the actual initialized field reads.
|
|
// Sound Null Safety - 6 total field resets:
|
|
// - 3 write/resets for the actual uninitialized field writes.
|
|
// - 3 reads/resets for the actual initialized field reads.
|
|
expectedResets = weakNullSafety
|
|
? expectThrowsResetFieldCount + 12
|
|
: expectThrowsResetFieldCount + 6;
|
|
Expect.equals(expectedResets, dart.resetFields.length);
|
|
|
|
dart.hotRestart();
|
|
dart.hotRestart();
|
|
|
|
// Late statics should throw on get when not initialized.
|
|
Expect.throws(() => noInitializer);
|
|
Expect.throws(() => Lates.noInitializer);
|
|
Expect.throws(() => LatesGeneric.noInitializer);
|
|
|
|
// Initialized statics should contain their values.
|
|
Expect.equals(1, withInitializer);
|
|
Expect.equals(2, Lates.withInitializer);
|
|
Expect.equals(3, LatesGeneric.withInitializer);
|
|
|
|
// Weak Null Safety - 9 total field resets:
|
|
// - 3 isSet reads/resets for uninitialized field reads.
|
|
// - 3 isSet reads/resets for initialized field reads.
|
|
// - 3 reads/resets for the actual initialized field reads.
|
|
//
|
|
// Sound Null Safety - 6 total field resets:
|
|
// - 3 reads/resets for actual uninitialized field reads.
|
|
// - 3 reads/resets for the actual initialized field reads.
|
|
expectedResets = weakNullSafety
|
|
? expectThrowsResetFieldCount + 9
|
|
: expectThrowsResetFieldCount + 6;
|
|
Expect.equals(expectedResets, dart.resetFields.length);
|
|
}
|