dart-sdk

mirror of https://github.com/dart-lang/sdk synced 2024-07-19 20:17:27 +00:00

History

Kenzie Schmoll 6607655382 [vm_snapshot_analysis] move `command/` `lib` files out of `bin` The files in `command/` were moved as part of https://dart-review.googlesource.com/c/sdk/+/154360. This CL responds to Slava's comment "FWIW having this files in bin violates pub layout guidelines and looks pretty different from all other packages we have: bin/ is a folder for scripts. Libraries should live in lib." I verified in DevTools that with this change, we can still import files from package:vm_snapshot_analysis and run on the web (as long as we do not import files that depend on dart:io - lib/commands/utils.dart) Change-Id: I8c4f2a55c9cf346260fa5b80116c21993ccfc249 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154481 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Commit-Queue: Kenzie Schmoll <kenzieschmoll@google.com>	2020-07-15 20:06:47 +00:00
..
analyse.dart	[vm_snapshot_analysis] move `command/*` `lib` files out of `bin`	2020-07-15 20:06:47 +00:00

Kenzie Schmoll 6607655382 [vm_snapshot_analysis] move command/* lib files out of bin

The files in `command/*` were moved as part of https://dart-review.googlesource.com/c/sdk/+/154360.

This CL responds to Slava's comment "FWIW having this files in bin violates pub layout guidelines and looks pretty different from all other packages we have: bin/ is a folder for scripts. Libraries should live in lib."

I verified in DevTools that with this change, we can still import files from package:vm_snapshot_analysis and run on the web (as long as we do not import files that depend on dart:io - lib/commands/utils.dart)

Change-Id: I8c4f2a55c9cf346260fa5b80116c21993ccfc249
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154481
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Kenzie Schmoll <kenzieschmoll@google.com>

2020-07-15 20:06:47 +00:00

analyse.dart [vm_snapshot_analysis] move command/* lib files out of bin 2020-07-15 20:06:47 +00:00