Oleh Prypin c0b40136e5 Revert "[ddc] Add non-null assertions when setting fields" ... This reverts commit c590001ef0. Reason for revert: Breaks google3 (b/247639927) Original change's description: > [ddc] Add non-null assertions when setting fields > > Re-land previously reverted change: > https://dart-review.googlesource.com/c/sdk/+/258780 > > Adds additional tests and more checks to ensure assertions are only > added in libraries that have been migrated to null safety. > > Issue: https://github.com/dart-lang/sdk/issues/49918 > Change-Id: If0b9bca9fe0d7db5e15023fe03ccac891af568e8 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259120 > Reviewed-by: Sigmund Cherem <sigmund@google.com> > Commit-Queue: Nicholas Shahan <nshahan@google.com> TBR=sigmund@google.com,nshahan@google.com,annagrin@google.com Change-Id: Iee2d33005cbabfacab7fc5c45046c6eeb8e31b01 Issue: https://github.com/dart-lang/sdk/issues/49918 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260106 Reviewed-by: Oleh Prypin <oprypin@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com>		2022-09-20 17:19:38 +00:00
..
abstract	[test] Replace non-implemented @DontInline() annotations	2021-07-26 13:22:31 +00:00
accessor_conflict	Migrate language_2/accessor_conflict to NNBD.	2020-02-04 09:52:03 +00:00
argument	Make update_static_error_tests work on Windows (again)	2020-09-10 06:21:13 +00:00
assert	[dart2js] Support AssertInitializer in dart2js	2021-03-05 09:14:37 +00:00
assign	Remove 'checked mode' from checked_mode_compile_time_errors	2020-07-31 19:20:58 +00:00
async	[tests] Address comments for language/async/await_user_defined_future_soundness_test	2022-07-02 10:11:42 +00:00
async_nested	Migrate language_2/async_nested to NNBD.	2020-02-12 20:46:37 +00:00
async_star	Fixed various typos in a lot of files	2022-07-25 12:21:59 +00:00
await	[vm] New async/async* implementation in JIT mode	2022-06-02 23:39:45 +00:00
bool	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
call	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
canonicalize	Migrate language_2/canonicalize to NNBD.	2020-03-31 00:42:49 +00:00
cascade	Analyzer: do not report an undefined getter with an empty name	2020-12-05 14:39:03 +00:00
class	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
closure	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
compile_time_constant	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
const	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
const_functions	[cfe] Report all compile-time errors found during constant evaluation	2021-08-24 11:42:53 +00:00
constants_2018	Fixed various typos in a lot of files	2022-07-25 12:21:59 +00:00
constructor	[vm] Throw error from external functions even if they have a body	2022-09-09 14:18:34 +00:00
control_flow_collections	Simplify asyncExpectThrows and enhance Expect.throws.	2022-01-06 17:06:47 +00:00
covariant	Add tests about covariant parameters and inherited methods	2021-09-01 23:47:47 +00:00
covariant_override	Fix typos	2022-06-15 11:08:28 +00:00
deferred	Reapply "Account for @pragma("vm:entry-point") creating additional "root" libraries when partitioning the program into loading units."	2022-06-27 18:56:12 +00:00
double	Move errors from StaticWarningCode to CompileTimeErrorCode.	2020-07-26 04:19:25 +00:00
double_literals	Migrate language_2/double_literals to NNBD.	2020-04-04 00:20:37 +00:00
dynamic	[cfe] Refactor TypeBuilders	2022-03-28 18:22:50 +00:00
enum	Roll dart_style 2.2.2 into the repo.	2022-03-04 13:06:42 +00:00
exception	Make tests not assume catch(e) gives e type dynamic.	2020-05-05 09:57:23 +00:00
export	[test] Fix bug in export/duplicate_import_libd	2021-06-30 07:44:52 +00:00
extension_methods	Fix typos	2022-06-10 15:48:54 +00:00
external_abstract_fields	[cfe] Implemenet abstract fields errors	2020-07-20 12:05:54 +00:00
factory	[cfe] Add UnresolvedKind for fine grained unresolved reporting	2021-08-25 09:51:54 +00:00
field	[dart2wasm] Initialize the function class early.	2022-03-18 17:44:57 +00:00
final	Flow analysis: ensure that not-yet-declared variables aren't marked as captured.	2022-01-11 15:42:04 +00:00
function	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
function_subtype	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
function_type	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
generic	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
generic_methods	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
getter	Fix reporting of INSTANCE_ACCESS_TO_STATIC_MEMBER from within an extension.	2021-10-17 06:22:30 +00:00
identifier	[cfe] Refactor TypeBuilders	2022-03-28 18:22:50 +00:00
identity	Migrate language_2/identity to NNBD.	2020-05-15 18:05:02 +00:00
if	Migrate language_2/if to NNBD.	2020-05-15 16:00:12 +00:00
if_null	Issue 48004. Report when null-aware operator is used on type.	2022-05-29 19:03:15 +00:00
implicit_creation	Fix typos	2022-04-28 12:53:43 +00:00
implicit_downcast_during	Reland "Flow analysis: promote to non-nullable on initialization"	2020-10-07 13:14:55 +00:00
import	[cfe] Add UnresolvedKind for fine grained unresolved reporting	2021-08-25 09:51:54 +00:00
inference	[cfe] Use combined member signature in override inference in legacy code	2020-12-09 17:33:20 +00:00
inference_update_1	Ensure that partial inference results aren't refined by later partial inference stages.	2022-05-10 15:10:44 +00:00
initializing_formal	Move codes from StaticTypeWarningCode into CompileTimeErrorCode.	2020-07-27 16:44:15 +00:00
instance	[cfe] Add UnresolvedKind for fine grained unresolved reporting	2021-08-25 09:51:54 +00:00
instantiate_to_bound	master branch to main	2021-09-15 06:22:23 +00:00
interceptor	Migrate language_2/interceptor to NNBD.	2020-05-26 16:04:15 +00:00
interface	[cfe] Add UnresolvedKind for fine grained unresolved reporting	2021-08-25 09:51:54 +00:00
invalid_returns	Move codes from StaticTypeWarningCode into CompileTimeErrorCode.	2020-07-27 16:44:15 +00:00
is	Document and test additional breaking change.	2022-09-08 16:05:05 +00:00
label	[parser] Add beforeSynthetic to SyntheticStringToken	2021-08-30 11:56:30 +00:00
lazy	[tests/nnbd] Fix tests/language/lazy/static8_test	2020-07-17 20:27:07 +00:00
least_upper_bound	Add test for upper bound with greatest closure	2021-01-21 08:51:53 +00:00
library	[gardening] Fix env_test/has_mirror_support.	2022-01-14 23:33:11 +00:00
list	[parser] More specific error messages when recovering new/const/Map/Set/List with said literals	2021-03-25 13:27:03 +00:00
loop	Migrate language_2/loop to NNBD.	2020-05-29 23:48:57 +00:00
main	[cfe] Report errors in invalid main declarations	2020-10-05 14:37:33 +00:00
malbounded	[cfe] Refactor bounds checking	2022-05-17 14:36:19 +00:00
malformed	[cfe] Refactor TypeBuilders	2022-03-28 18:22:50 +00:00
map	[js_runtime] Use custom hashCode for GeneralConstantMap	2021-07-16 22:58:02 +00:00
metadata	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
method	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
mixin	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
mixin_constructor_forwarding	Add test for mixin application constructor forwarding of default values.	2020-06-12 16:36:40 +00:00
mixin_declaration	Migrate language_2/mixin_declaration to NNBD.	2020-06-10 01:09:45 +00:00
named_arguments_anywhere	Roll dart_style 2.2.2 into the repo.	2022-03-04 13:06:42 +00:00
new	[cfe] Add UnresolvedKind for fine grained unresolved reporting	2021-08-25 09:51:54 +00:00
nnbd	Revert "[ddc] Add non-null assertions when setting fields"	2022-09-20 17:19:38 +00:00
no_such_method	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
nonfunction_type_aliases	Fixed various typos in a lot of files	2022-07-25 12:21:59 +00:00
nosuchmethod_forwarding	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
null	[tests] Migrate multi-test to static error test	2022-08-12 07:57:48 +00:00
null_aware	Flag additional code as unreachable due to types Null and Never.	2022-08-22 16:50:19 +00:00
number	[cfe] Add UnresolvedKind for fine grained unresolved reporting	2021-08-25 09:51:54 +00:00
operator	Deprecate IntegerDivisionByZeroException.	2021-10-19 16:07:52 +00:00
optimize	[test] Replace non-implemented @DontInline() annotations	2021-07-26 13:22:31 +00:00
override	Move codes from StaticTypeWarningCode into CompileTimeErrorCode.	2020-07-27 16:44:15 +00:00
parameter	Fix typos	2022-09-16 19:35:00 +00:00
part	Migrate language_2/part to NNBD.	2020-06-08 23:16:55 +00:00
prefix	[cfe] Add UnresolvedKind for fine grained unresolved reporting	2021-08-25 09:51:54 +00:00
private	[cfe] Add UnresolvedKind for fine grained unresolved reporting	2021-08-25 09:51:54 +00:00
propagate	Migrate language_2/propagate to NNBD.	2020-06-08 23:36:46 +00:00
records/simple	[vm] runtimeType for record instances and record type equality	2022-09-19 22:05:04 +00:00
redirecting	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
reg_exp	Migrate language_2/reg_exp to NNBD.	2020-06-09 18:45:33 +00:00
regress	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
resolution	Migrate language_2/resolution to NNBD.	2020-06-09 00:44:05 +00:00
return	Migrate language_2/return to NNBD.	2020-06-09 16:31:44 +00:00
rewrite	Move codes from StaticTypeWarningCode into CompileTimeErrorCode.	2020-07-27 16:44:15 +00:00
script	Delete unused files in test folders.	2021-05-19 08:05:05 +00:00
set_literals	[tests] Add const-big-set-literal test	2020-10-20 11:07:23 +00:00
setter	Do not report BODY_MIGHT_COMPLETE_NORMALLY for setters	2021-09-08 16:07:13 +00:00
spread_collections	Front end: Fix follow-on error arising from ill-typed spread element.	2021-03-04 15:52:57 +00:00
stack_trace	Reland "[vm/compiler] Move AssertAssignables out of closure bodies."	2020-11-18 22:42:31 +00:00
static	[ddc] Adding support for static setters of const fields	2022-04-01 23:51:15 +00:00
string	[parser-ish] Better errors on invalid unicode escapes	2022-03-17 13:57:45 +00:00
subtyping_static	Migrate language_2/subtyping_static to NNBD.	2020-06-15 20:53:55 +00:00
super	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
superinterface_variance	Migrate language_2/superinterface_variance to NNBD.	2020-06-25 20:21:42 +00:00
switch	Reland "Reland "[vm/compiler] Optimize switch statements""	2022-08-23 22:11:50 +00:00
symbol	Move codes from StaticTypeWarningCode into CompileTimeErrorCode.	2020-07-27 16:44:15 +00:00
sync_star	[VM] Fixes yield* exception handling in sync*.	2020-10-27 06:46:27 +00:00
syntax	Migrate language_2/syntax to NNBD.	2020-06-18 22:54:13 +00:00
this	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
top_level	Delete unused files in test folders.	2021-05-19 08:05:05 +00:00
type	[cfe] Check primitive equals in legacy libraries	2022-02-10 22:13:14 +00:00
type_object	Fix typos	2022-06-15 11:08:28 +00:00
type_promotion	Move codes from StaticTypeWarningCode into CompileTimeErrorCode.	2020-07-27 16:44:15 +00:00
type_variable	[cfe] Refactor bounds checking	2022-05-17 14:36:19 +00:00
typedef	Remove references to constructor-tearoff experiment.	2021-11-11 14:04:43 +00:00
unsorted	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
value_class	[cfe] Add Jenkins SMI hashcode combiner	2020-09-07 12:36:13 +00:00
variable	Report fewer duplicate errors for invalid superinitializers	2021-11-08 18:53:42 +00:00
variance	[cfe] Refactor bounds checking	2022-05-17 14:36:19 +00:00
vm	Remove uses of : as default value separator in some tests/ directories.	2022-09-07 14:49:17 +00:00
void	master branch to main	2021-09-15 06:22:23 +00:00
why_not_promoted	Rename some more incorrectly named tests.	2021-06-03 00:49:54 +00:00
await_type_error_test.dart	Analyzer: Don't do recursive flattening of FutureOr in await.	2020-01-28 11:16:07 +00:00
await_type_test.dart	Analyzer: Don't do recursive flattening of FutureOr in await.	2020-01-28 11:16:07 +00:00
dynamic_type_helper.dart	Migrate language_2/function to NNBD.	2020-04-25 01:53:20 +00:00
explicit_type_instantiation_parsing_test.dart	Remove references to constructor-tearoff experiment.	2021-11-11 14:04:43 +00:00
language.status	[ddc] Ensure status file entries are consistent	2022-08-08 17:23:50 +00:00
language_analyzer.status	Update all Slow tests to be Slow, Pass.	2020-02-01 00:17:42 +00:00
language_dart2js.status	Add a language test to check situations where implicit call tearoff does not occur.	2022-02-15 16:37:50 +00:00
language_dart2wasm.status	[dart2wasm] Initial commit for the Dart-to-WasmGC compiler.	2022-02-16 11:11:14 +00:00
language_dartdevc.status	[ddc] Ensure status file entries are consistent	2022-08-08 17:23:50 +00:00
language_kernel.status	[test] Remove obsolete Skips from status files	2022-08-11 08:41:05 +00:00
language_precompiled.status	[vm] Fix yield in async* to check if the stream was canceled while generator was suspended	2022-07-15 14:09:20 +00:00
language_spec_parser.status	[SDK] Removes non-exiting tests from .status	2021-02-04 06:46:13 +00:00
language_vm.status	[vm] Fix yield in async* to check if the stream was canceled while generator was suspended	2022-07-15 14:09:20 +00:00
library1.dart	Migrate language_2/function to NNBD.	2020-04-25 01:53:20 +00:00
library2.dart	Migrate language_2/function to NNBD.	2020-04-25 01:53:20 +00:00
library10.dart	Migrate language_2/function to NNBD.	2020-04-25 01:53:20 +00:00
library11.dart	Migrate language_2/function to NNBD.	2020-04-25 01:53:20 +00:00
library12.dart	Migrate language_2/function to NNBD.	2020-04-25 01:53:20 +00:00
record_literal_problems_test.dart	[parser] Empty record types, record types with 1 element	2022-08-30 11:04:10 +00:00
record_literal_test.dart	[parser] Record literals can be const and one-element only	2022-08-30 10:54:08 +00:00
record_type_problems_test.dart	Revert "Reland "[cfe,corelib] Add class 'Record' to the core library""	2022-09-19 13:52:01 +00:00
record_type_test.dart	Revert "Reland "[cfe,corelib] Add class 'Record' to the core library""	2022-09-19 13:52:01 +00:00
static_type_helper.dart	[test] Fix constructor tear off tests in language	2021-07-23 08:41:09 +00:00
syntax_helper.dart	Additional language tests for parsing behaviors around type arguments.	2021-05-18 14:06:13 +00:00