mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 02:17:14 +00:00
754e5f404c
This reverts commit 4118d3c793.
Crashes on hot reload/rollback bots.
Original change's description:
> [vm/extensions] Fix Loader::ReloadNativeExtensions(...).
>
> This method was not doing anything since the switch to Dart 2
> because extensions no longer were added as imports to the libraries
> which loaded them.
>
> This is a commandeer of https://dart-review.googlesource.com/c/sdk/+/90240 with a bug fix.
>
> Change-Id: Idfe2ec16ae714b5a31ed53332da6704248949915
> Reviewed-on: https://dart-review.googlesource.com/c/92180
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
TBR=rmacnak@google.com,sjindel@google.com
Change-Id: If8c8d6cf8ee2cb0a354601f94c609d3d7b5ddf03
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/92640
Reviewed-by: Samir Jindel <sjindel@google.com>
39 lines
1.6 KiB
Plaintext
39 lines
1.6 KiB
Plaintext
# Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
# for details. All rights reserved. Use of this source code is governed by a
|
|
# BSD-style license that can be found in the LICENSE file.
|
|
|
|
[ $arch == arm ]
|
|
sample_extension/test/*: Skip # Issue 14705
|
|
|
|
[ $builder_tag == optimization_counter_threshold ]
|
|
sample_extension/test/sample_extension_app_snapshot_test: SkipByDesign # This test is too slow for testing with low optimization counter threshold.
|
|
|
|
[ $compiler == app_jit ]
|
|
sample_extension/test/sample_extension_app_snapshot_test: RuntimeError
|
|
|
|
[ $compiler == precompiler ]
|
|
sample_extension/test/*: Skip # These tests attempt to spawn another script using the precompiled runtime.
|
|
|
|
[ $compiler == dart2js && $runtime == none ]
|
|
*: Fail, Pass # TODO(ahe): Triage these tests.
|
|
|
|
[ $compiler == none && $mode == debug && $runtime == vm && $system == windows ]
|
|
sample_extension/test/sample_extension_app_snapshot_test: Pass, RuntimeError # Issue 28842
|
|
|
|
[ $compiler == none && $runtime == vm && $system == fuchsia ]
|
|
*: Skip # Not yet triaged.
|
|
|
|
[ !$preview_dart_2 && ($runtime == dart_precompiled || $runtime == vm) ]
|
|
*: SkipByDesign # Deprecating all Dart1 modes of execution
|
|
|
|
[ $compiler == app_jitk || $compiler == dartk || $compiler == dartkb || $compiler == dartkp ]
|
|
sample_extension/test/sample_extension_app_snapshot_test: RuntimeError
|
|
sample_extension/test/sample_extension_test: RuntimeError
|
|
|
|
# Skip tests that use dart:io
|
|
[ $runtime == d8 || $browser ]
|
|
sample_extension/*: Skip
|
|
|
|
[ $hot_reload || $hot_reload_rollback ]
|
|
sample_extension/test/sample_extension_app_snapshot_test: SkipByDesign # Cannot reload with URI pointing to app snapshot.
|