languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/tools
History
Zach Anderson 7471994270 Revert "[vm/ffi] Add class modifiers" 
This reverts commit 1755f89092.

Reason for revert: This is a breaking change and is blocking the Dart -> Flutter roll. See https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Unopt/26896/overview.

Original change's description:
> [vm/ffi] Add class modifiers
>
> Adds class modifiers to `dart:ffi`.
>
> Migrates all user-defined subclasses of `Struct`, `Union`, `Opaque`,
> and `AbiSpecificInteger` to be `final class`es.
>
> Does not remove the manual error checking, so some errors will show up
> twice now in language version 3.0. In language version <3.0, only the
> FFI-specific error will show up.
>
> In a follow-up CL, we will try to make the language-errors to show up
> also <3.0 so that we can remove the FFI-specific errors.
>
> Examples of duplicated errors:
> pkg/analyzer/test/src/diagnostics/subtype_of_ffi_class_test.dart
>
> TEST=pkg/analyzer/test/ (for the analyzer)
> TEST=pkg/front_end/testcases/ (for the CFE)
> TEST=test/ffi/ (for the VM)
>
> CoreLibraryReviewExempt: No need for dart2js to review.
> Bug: https://github.com/dart-lang/sdk/issues/51683
> Change-Id: I2964ceccb7db59fbdaf6be5319f5e4ec2dabe0f3
> Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-win-release-try,pkg-mac-release-try,vm-precomp-ffi-qemu-linux-release-riscv64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-android-debug-arm-try,vm-reload-rollback-linux-debug-x64-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289223
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Reviewed-by: Devon Carew <devoncarew@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Jackson Gardner <jacksongardner@google.com>
> Reviewed-by: Lasse Nielsen <lrn@google.com>
> Commit-Queue: Daco Harkes <dacoharkes@google.com>

Bug: https://github.com/dart-lang/sdk/issues/51683
Change-Id: Ie5b8a08aea6d64b1991ace4814322b21ffb670c7
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-win-release-try,pkg-mac-release-try,vm-precomp-ffi-qemu-linux-release-riscv64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-android-debug-arm-try,vm-reload-rollback-linux-debug-x64-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289640
Commit-Queue: Slava Egorov <vegorov@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
2023-03-20 11:15:59 +00:00
..
bots Add a flag to disable the new unified_analytics for a single session. 2023-03-16 18:00:57 +00:00
buildtools Spelling tools 2022-12-21 17:26:48 +00:00
dart2js
dom [sdk docs] update sdk libraries to use triple slash docs 2023-03-14 19:10:25 +00:00
fuchsia
linux_dist_support Fix building Debian packages for not-x64. 2023-02-28 23:18:07 +00:00
package_deps
patches Spelling tools 2023-01-09 15:48:57 +00:00
sdks [release] Update checked-in SDKs to 2.19.0 2023-01-26 07:26:36 +00:00
spec_parser [ANTLR] Move optional trailing question mark up. 2023-03-17 11:33:59 +00:00
test_generators
testing
verify_docs Revert "[vm/ffi] Add class modifiers" 2023-03-20 11:15:59 +00:00
.gitignore
3xhead_flutter_hooks.sh
addlatexhash.dart
analysis_options.yaml
build.py [build] Switch builds to the ninja in DEPS 2022-09-27 11:24:03 +00:00
canary.dart
copy_dart.py
copy_tree.py Spelling tools 2023-01-09 15:48:57 +00:00
create_pkg_manifest.py
diff_results.dart Spelling tools 2023-01-09 15:48:57 +00:00
download_chromium_sysroot.sh
experimental_features.yaml [flip-patterns] Enable "records" and "patterns" experiment flags. 2023-03-10 20:02:23 +00:00
FAKE_COMMITS [flip-modifiers]: flip the flags for sealed classes and class modifiers 2023-03-10 05:27:57 +00:00
find_depot_tools.py
gen_fuchsia_test_manifest.py
generate_buildfiles.py
generate_experimental_flags.dart
generate_idefiles.py [build] Switch builds to the ninja in DEPS 2022-09-27 11:24:03 +00:00
generate_package_config.dart [_fe_analyzer_shared][cfe][analyzer] Initial implementation of exhaustiveness checking 2023-01-24 13:34:46 +00:00
generate_package_config.py
generate_sdk_version_file.py
get_dot_git_folder.py
git_cl_try.sh
gn.py Reland x3 [dart2wasm] Include wasm-opt in the shipped dart-sdk. 2023-03-10 18:34:10 +00:00
gn_helpers.py
line_doc_comments.dart
list_dart_files.py
list_dart_files_as_depfile.py
make_version.py [infra] Create a GIT_TIMESTAMP file for tarball 2023-02-06 09:15:01 +00:00
manage_deps.dart [deps] update the rev script to handle 'main' branches 2023-02-06 18:04:11 +00:00
minidump.py
opt_out_files.dart
OWNERS
OWNERS_ANALYZER
OWNERS_BUILD
OWNERS_CFE
OWNERS_ECOSYSTEM [owners] add mosum@ to the OWNERS_ECOSYSTEM file 2022-09-16 17:51:55 +00:00
OWNERS_ENG
OWNERS_FOUNDATION
OWNERS_GOOGLE3
OWNERS_INFRA
OWNERS_PRODUCT
OWNERS_PUB
OWNERS_VM [OWNERS] Fix VM owners file entries. 2022-11-11 20:25:03 +00:00
OWNERS_WASM
OWNERS_WEB
presubmit.sh
promote.py [infra] Promote beta to stable when stable is ahead of beta. 2023-02-17 11:20:20 +00:00
publish_pkg.py
rev_sdk_deps.dart [deps] update the rev script to handle 'main' branches 2023-02-06 18:04:11 +00:00
run_offsets_extractor.sh
run_with_coredumps_enabled.py
set_ia32_sysroot.sh
set_x64_sysroot.sh
spec_parse.py
task_kill.py
test.dart
test.py
utils.py [infra] Promote beta to stable when stable is ahead of beta. 2023-02-17 11:20:20 +00:00
validate_test_matrix.dart
VERSION [3.0 alpha] Bump version to 3.0.0 2022-12-06 02:40:36 +00:00
write_dartdoc_options_file.py
write_revision_file.py
write_version_file.py
yaml2json.dart