mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 01:59:38 +00:00
6fd24ef3c4
There are two ways the test runner might want to parse and show errors from analyzer: 1. When a static error test's output doesn't match the expected errors. 2. When a normal runtime test produces unexpected errors. The former were correctly migrated over to parse and read the analyzer's JSON output. The latter wasn't. It was still trying to parse the old "|"-separated machine format. Worse, when migrating to the new JSON output, a try-catch-block was added to handle any unexpected errors. That had the unintended side effect of silently catching this parse error and then continuing. The end result is that if an analyzer test failed on a normal runtime test, the test runner didn't print any of the analyzer errors. :( This fixes that. It uses a single code path to parse the JSON output to AnalyzerError. Then, for static error tests, it converts those to StaticErrors. Change-Id: I51c1277f0ed04faead82f579d668f8897f379a49 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201382 Auto-Submit: Bob Nystrom <rnystrom@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Bob Nystrom <rnystrom@google.com> |
||
|---|---|---|
| .. | ||
| bin | ||
| lib | ||
| test | ||
| tool | ||
| .gitignore | ||
| analysis_options.yaml | ||
| pubspec.yaml | ||