mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 16:41:07 +00:00
ed3824a220
It's a badly designed class, but this change makes it slightly better. (We should consider moving it to package:collection and removing it from the platform libraries. Eventually.) The changes decouples the public `DoubleLinkedQueueEntry` class from the actual queue implementation classes, avoiding the latter having to share a generic `_Link<DoubleLinkedQueueEntry>` interface which would force them to do otherwise unnecessary casts. The public class should have been abstract, but isn't. It's mainly used as the API of the entries exposed by DoubleLinkedQueue, but it can also be used by itself to build double-linked lists that are not part of a Queue, and the class can be extended. If anyone does either, it should keep working, so it needs to be a concrete, self-contained class with a generative constructor. That class is moved to dart:_internal to avoid its private implementation fields from interfering with the queue implementation classes, which have similar fields, but can now have them at different types. That's a hack, but it works. The internal implementation of the DoubleLinkedQueue and its entries are updated to better follow current programming idioms, and avoids having fields on classes which don't need them. Also fixes #27920 (`clear`ing a list now detaches each entry from the list so later `.contains` won't give the wrong answer). And moves queue tests from tests/corelib to tests/lib/collection, since Queue isn't exposed by `dart:core`. BUG= https://github.com/dart-lang/sdk/issues/27920 Change-Id: Ia3bb340a75886de160cc0e449947e8e7ee587061 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211265 Commit-Queue: Lasse R.H. Nielsen <lrn@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> |
||
|---|---|---|
| .. | ||
| failing_list_test.dart | ||
| hash_map_test.dart | ||
| hash_set_test.dart | ||
| linked_list_test.dart | ||
| list_test.dart | ||
| queue_first_test.dart | ||
| queue_iterator_test.dart | ||
| queue_last_test.dart | ||
| queue_single_test.dart | ||
| queue_test.dart | ||