Find a file
Jackson Gardner 67f0d4daf0 Revert "[dart2wasm] Replace struct.new_default with struct.new for object"
This reverts commit 5a4b252252.

Reason for revert: Causing Flutter engine unit test failures, see https://github.com/dart-lang/sdk/issues/53506

Original change's description:
> [dart2wasm] Replace `struct.new_default` with `struct.new` for object
> allocation.
>
> When using the `struct.new_default` instruction for object allocation,
> fields are always nullable and mutable. By using the `struct.new`
> instruction instead, class fields can now have the same mutability and
> nullability in Wasm as declared in Dart. In addition, the class ID and
> type parameters (which are also stored in an object's struct), can now
> be immutable and nonnullable as well.
>
> To do this, object construction is now split into three functions:
> (1) Initializer: evaluates initializers for instance fields and
> constructor initializers (this constructor before super constructor).
> (2) Constructor body: executes the constructor body (super constructor
> before this constructor), with `this` pointed to the constructed object.
> (3) Constructor allocator: which calls (1), allocates the object using
> `struct.new`, then calls (2).
>
> Because fields now have the correct mutability and nullability in Wasm,
> this removes unnecessary null checks for nonnullable fields, and may
> allow for better optimisations by Binaryen.
>
> Fixes https://github.com/dart-lang/sdk/issues/51492
>
> Change-Id: Ib26046686f772a70509a870301217e9b1c91b77e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315820
> Commit-Queue: Jess Lally <jessicalally@google.com>
> Reviewed-by: Aske Simon Christensen <askesc@google.com>

Change-Id: I034d3acf3715abadc6811a7393ba780bee974329
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325445
Commit-Queue: Martin Kustermann <kustermann@google.com>
Commit-Queue: Jackson Gardner <jacksongardner@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2023-09-12 20:16:56 +00:00
.dart_tool
.github Bump actions/upload-artifact from 3.1.2 to 3.1.3 2023-09-11 17:02:56 +00:00
benchmarks [benchmarks] Publish some more Dart benchmarks 2023-09-04 15:57:53 +00:00
build [Fuchsia] Create CFv2 support 2023-09-12 01:40:52 +00:00
docs
pkg Revert "[dart2wasm] Replace struct.new_default with struct.new for object" 2023-09-12 20:16:56 +00:00
runtime [vm] Remove dead ARMv5 code. 2023-09-12 16:22:19 +00:00
samples [infra] Make the sanitizer a first-class status variable. 2023-07-10 17:46:31 +00:00
sdk Revert "[dart2wasm] Replace struct.new_default with struct.new for object" 2023-09-12 20:16:56 +00:00
tests Fix parsing of folded header field values. 2023-09-11 21:13:58 +00:00
third_party [devtools] Remove obsolete update script. 2023-09-01 12:48:31 +00:00
tools [Fuchsia] Create CFv2 support 2023-09-12 01:40:52 +00:00
utils [ddc] Cleanup old "dartdevc" build targets 2023-08-29 21:33:48 +00:00
.clang-format
.gitattributes
.gitconfig
.gitignore [tool] Bisection tool 2023-07-13 13:22:26 +00:00
.gn [Fuchsia] Import test scripts from chromium and use it to download image 2023-08-22 19:59:25 +00:00
.mailmap
.style.yapf
.vpython
AUTHORS
BUILD.gn [Fuchsia] Create CFv2 support 2023-09-12 01:40:52 +00:00
CHANGELOG.md Add changelog entry for NativeCallable 2023-09-11 22:25:06 +00:00
codereview.settings
CONTRIBUTING.md
DEPS [co19] Roll co19 to 5b9b08fb3210ee83a92ab4afe2268326761dd9a9 2023-09-12 08:44:26 +00:00
LICENSE
OWNERS
PATENT_GRANT
PRESUBMIT.py [presubmit] Remove check to keep _2 suites in sync 2023-07-21 16:08:49 +00:00
README.dart-sdk
README.md
sdk.code-workspace
sdk_args.gni
SECURITY.md
WATCHLISTS

Dart

A client-optimized language for fast apps on any platform

Dart is:

  • Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.

  • Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.

  • Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.

Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:

  • Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.

  • Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).

Dart platforms illustration

License & patents

Dart is free and open source.

See LICENSE and PATENT_GRANT.

Using Dart

Visit dart.dev to learn more about the language, tools, and to find codelabs.

Browse pub.dev for more packages and libraries contributed by the community and the Dart team.

Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).

Building Dart

If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.

There are more documents on our wiki.

Contributing to Dart

The easiest way to contribute to Dart is to file issues.

You can also contribute patches, as described in Contributing.