Michael Powell dfcc52f909 [vm/dart:io/fuchsia] Improve fdio_pipe_half signature, step 2. ... The return value on fdio_pipe_half conflated two things: the error code on failure (as a zx_status_t) or a file descriptor on success. This technically worked, because they're both ints, the error code was always negative, and the file descriptor always positive. However, the stated return type of zx_status_t was misleading. This changes the signature such that it always returns an actual zx_status_t, and the file descriptor is returned through a pointer argument. Also remove the last argument, since it was always given the same value. This needs to be done as a soft transition because it's called from the Dart runtime. The steps are as follows: 1. Add fdio_pipe_half2 with the new signature. 2. Update the Dart runtime to call fdio_pipe_half2. 3. Change fdio_pipe_half to be identical to fdio_pipe_half2. 4. Update the Dart runtime to call the updated fdio_pipe_half. 5. Delete fdio_pipe_half2. This is step 2. Change-Id: Ieac841c5f8055f34000851cef364a12b6c0aca2a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96664 Commit-Queue: Zach Anderson <zra@google.com> Auto-Submit: Michael Powell <mikepowell@google.com> Reviewed-by: Zach Anderson <zra@google.com>		2019-03-28 17:45:55 +00:00
..
vmservice	[VM / Observatory ] Remove needless stacktrace print when adding to closed socket	2019-02-28 18:35:03 +00:00
abi_version.h	Move use_abi_version from vm directory to bin	2019-03-15 22:35:25 +00:00
abi_version_in.cc	Move use_abi_version from vm directory to bin	2019-03-15 22:35:25 +00:00
address_sanitizer.cc
BUILD.gn	[vm] Load kernel service from ABI versioned dill file	2019-03-22 16:14:16 +00:00
builtin.cc
builtin.dart
builtin.h
builtin_common.cc
builtin_gen_snapshot.cc
builtin_impl_sources.gni	Move use_abi_version from vm directory to bin	2019-03-15 22:35:25 +00:00
builtin_in.cc
builtin_natives.cc
builtin_sources.gni
cli.cc
cli_impl_sources.gni
cli_patch.dart
cli_sources.gni
common_patch.dart	[vm/aot] Remove unnecessary closurization of some entry-points.	2019-02-20 10:44:21 +00:00
console.h
console_posix.cc
console_win.cc
crashpad.cc
crashpad.h
crypto.cc
crypto.h
crypto_android.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
crypto_fuchsia.cc
crypto_linux.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
crypto_macos.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
crypto_test.cc
crypto_win.cc
dart_embedder_api_impl.cc	Removes superfluous Dart_ExitScope() call in CreateVmServiceIsolate.	2019-03-13 13:58:04 +00:00
dart_io_api_impl.cc
dartutils.cc	[vm] Delete disallowed constructors/operators	2019-03-23 00:52:41 +00:00
dartutils.h
dfe.cc	[vm] Load kernel service from ABI versioned dill file	2019-03-22 16:14:16 +00:00
dfe.h	[vm] Load kernel service from ABI versioned dill file	2019-03-22 16:14:16 +00:00
directory.cc
directory.h
directory_android.cc	[vm] Add macro for fallthrough annotations	2019-02-15 01:12:01 +00:00
directory_fuchsia.cc	[vm] Add macro for fallthrough annotations	2019-02-15 01:12:01 +00:00
directory_linux.cc	[vm] Add macro for fallthrough annotations	2019-02-15 01:12:01 +00:00
directory_macos.cc	[vm] Add macro for fallthrough annotations	2019-02-15 01:12:01 +00:00
directory_patch.dart	[vm/aot] Remove unnecessary closurization of some entry-points.	2019-02-20 10:44:21 +00:00
directory_test.cc
directory_win.cc
entrypoints_verification_test_extension.cc	[vm] Respect entry-point annotation on constructors during obfuscation.	2019-02-14 20:18:19 +00:00
entrypoints_verification_test_extension_dllmain_win.cc
error_exit.cc
error_exit.h
eventhandler.cc
eventhandler.h
eventhandler_android.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
eventhandler_android.h	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
eventhandler_fuchsia.cc	Deflake socket reads on Fuchsia	2019-03-26 22:28:50 +00:00
eventhandler_fuchsia.h
eventhandler_linux.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
eventhandler_linux.h	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
eventhandler_macos.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
eventhandler_macos.h	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
eventhandler_patch.dart
eventhandler_test.cc
eventhandler_win.cc	[standalone] Name dart:io threads, take 2.	2019-02-13 20:29:46 +00:00
eventhandler_win.h
extensions.cc
extensions.h
extensions_android.cc
extensions_fuchsia.cc
extensions_linux.cc
extensions_macos.cc
extensions_win.cc
fdutils.h
fdutils_android.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
fdutils_fuchsia.cc
fdutils_linux.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
fdutils_macos.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
ffi_test_dynamic_library.cc	[vm / library] Foreign function interface prototype	2019-02-13 12:42:47 +00:00
ffi_test_functions.cc	[vm] Support FFI on 32-bit Intel.	2019-03-20 17:45:23 +00:00
file.cc
file.h
file_android.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
file_fuchsia.cc	[vm,dart:io,fuchsia] Be happy with any open fd for Stdio handles if fstat fails	2019-03-13 20:20:01 +00:00
file_linux.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
file_macos.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
file_patch.dart	[vm/aot] Remove unnecessary closurization of some entry-points.	2019-02-20 10:44:21 +00:00
file_support.cc
file_system_entity_patch.dart
file_system_watcher.cc
file_system_watcher.h
file_system_watcher_android.cc
file_system_watcher_fuchsia.cc
file_system_watcher_linux.cc
file_system_watcher_macos.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
file_system_watcher_win.cc
file_test.cc
file_win.cc
filter.cc
filter.h
filter_patch.dart
gen_snapshot.cc	[vm] Fix memory leaks in --load_compilation_trace and --load_type_feedback.	2019-03-14 19:26:13 +00:00
gzip.cc
gzip.h
hashmap_test.cc
io_buffer.cc
io_buffer.h
io_impl_sources.gni
io_natives.cc
io_natives.h
io_service.cc
io_service.h
io_service_no_ssl.cc
io_service_no_ssl.h
io_service_patch.dart
io_sources.gni
isolate_data.cc
isolate_data.h
loader.cc
loader.h
lockers.h
log.h
log_android.cc
log_fuchsia.cc
log_linux.cc
log_macos.cc
log_win.cc
main.cc	Reland "[ VM / dart:isolate ] Added ability to set names for spawned isolates."	2019-03-28 16:39:50 +00:00
main_options.cc	[vm] Remove support for '-c', '--checked' flags and '--enable-checked-mode'	2019-03-22 17:08:56 +00:00
main_options.h	Move use_abi_version from vm directory to bin	2019-03-15 22:35:25 +00:00
namespace.cc
namespace.h
namespace_android.cc
namespace_fuchsia.cc
namespace_fuchsia.h
namespace_linux.cc
namespace_macos.cc
namespace_patch.dart	[vm/aot] Remove unnecessary closurization of some entry-points.	2019-02-20 10:44:21 +00:00
namespace_win.cc
observatory_assets_empty.cc
options.cc
options.h
platform.cc
platform.h
platform_android.cc	[vm] Also print version information in assertion failures, not just faults.	2019-03-06 20:02:18 +00:00
platform_fuchsia.cc
platform_linux.cc	[vm] Also print version information in assertion failures, not just faults.	2019-03-06 20:02:18 +00:00
platform_macos.cc	[vm] Also print version information in assertion failures, not just faults.	2019-03-06 20:02:18 +00:00
platform_patch.dart
platform_win.cc	[vm] Also print version information in assertion failures, not just faults.	2019-03-06 20:02:18 +00:00
process.cc
process.h
process_android.cc	[VM] Parentenvironment for Macos and Android	2019-03-20 21:29:03 +00:00
process_fuchsia.cc	[vm/dart:io/fuchsia] Improve fdio_pipe_half signature, step 2.	2019-03-28 17:45:55 +00:00
process_linux.cc	[VM-Runtime] set environment when creating detached process	2019-03-12 21:09:35 +00:00
process_macos.cc	[VM] Parentenvironment for Macos and Android	2019-03-20 21:29:03 +00:00
process_patch.dart	[vm/aot] Remove unnecessary closurization of some entry-points.	2019-02-20 10:44:21 +00:00
process_test.cc
process_win.cc
reference_counting.h
root_certificates_unsupported.cc
run_vm_tests.cc	Reland "[ VM / dart:isolate ] Added ability to set names for spawned isolates."	2019-03-28 16:39:50 +00:00
secure_socket_filter.cc
secure_socket_filter.h
secure_socket_patch.dart
secure_socket_unsupported.cc
secure_socket_utils.cc
secure_socket_utils.h
security_context.cc
security_context.h
security_context_android.cc
security_context_fuchsia.cc
security_context_linux.cc
security_context_macos.cc
security_context_win.cc
snapshot_empty.cc
snapshot_in.cc
snapshot_utils.cc
snapshot_utils.h
socket.cc
socket.h
socket_android.cc
socket_base.cc
socket_base.h
socket_base_android.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
socket_base_android.h
socket_base_fuchsia.cc
socket_base_fuchsia.h
socket_base_linux.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
socket_base_linux.h
socket_base_macos.cc	[VM] Remove retry logic from close(fd) calls	2019-02-15 23:28:17 +00:00
socket_base_macos.h
socket_base_win.cc
socket_base_win.h
socket_fuchsia.cc	Deflake socket reads on Fuchsia	2019-03-26 22:28:50 +00:00
socket_linux.cc
socket_macos.cc
socket_patch.dart	[vm/aot] Remove unnecessary closurization of some entry-points.	2019-02-20 10:44:21 +00:00
socket_win.cc
stdio.cc
stdio.h
stdio_android.cc
stdio_fuchsia.cc
stdio_linux.cc
stdio_macos.cc
stdio_patch.dart
stdio_win.cc
sync_socket.cc
sync_socket.h
sync_socket_android.cc
sync_socket_fuchsia.cc
sync_socket_linux.cc
sync_socket_macos.cc
sync_socket_patch.dart
sync_socket_win.cc
test_extension.c
test_extension_dllmain_win.cc
thread.h	[standalone] Name dart:io threads, take 2.	2019-02-13 20:29:46 +00:00
thread_android.cc	[standalone] Name dart:io threads, take 2.	2019-02-13 20:29:46 +00:00
thread_android.h
thread_fuchsia.cc	[standalone] Name dart:io threads, take 2.	2019-02-13 20:29:46 +00:00
thread_fuchsia.h
thread_linux.cc	[standalone] Name dart:io threads, take 2.	2019-02-13 20:29:46 +00:00
thread_linux.h
thread_macos.cc	[standalone] Name dart:io threads, take 2.	2019-02-13 20:29:46 +00:00
thread_macos.h
thread_win.cc	[ VM / Windows ] Removed call to SetThreadDescription which is only supported in new Win 10 builds	2019-02-26 01:00:26 +00:00
thread_win.h
typed_data_utils.cc
typed_data_utils.h
utils.h
utils_android.cc
utils_fuchsia.cc
utils_linux.cc
utils_macos.cc
utils_win.cc
utils_win.h
vmservice_impl.cc
vmservice_impl.h