dart-sdk/runtime/vm/debugger_kbc.cc
Régis Crelier ffea2b3245 [vm/debugger] Implement debug breaks in interpreter without bytecode patching.
The list of bytecodes that are checked for debug breaks and single stepping
can be tuned later (as well as performance if needed).

Fix identification of Dart top activation frame in debugger.

Change-Id: Ieab804ba25f84efe173531431c6d311005163433
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104922
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2019-06-05 17:39:04 +00:00

57 lines
1.5 KiB
C++

// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
#include "vm/globals.h"
#if !defined(DART_PRECOMPILED_RUNTIME)
#include "vm/debugger.h"
#include "vm/instructions_kbc.h"
#include "vm/interpreter.h"
namespace dart {
#ifndef PRODUCT
void CodeBreakpoint::SetBytecodeBreakpoint() {
ASSERT(!is_enabled_);
is_enabled_ = true;
Interpreter::Current()->set_is_debugging(true);
}
void CodeBreakpoint::UnsetBytecodeBreakpoint() {
ASSERT(is_enabled_);
is_enabled_ = false;
if (!Isolate::Current()->single_step() &&
!Isolate::Current()->debugger()->HasEnabledBytecodeBreakpoints()) {
Interpreter::Current()->set_is_debugging(false);
}
}
bool Debugger::HasEnabledBytecodeBreakpoints() const {
CodeBreakpoint* cbpt = code_breakpoints_;
while (cbpt != nullptr) {
if (cbpt->IsEnabled() && cbpt->IsInterpreted()) {
return true;
}
cbpt = cbpt->next();
}
return false;
}
bool Debugger::HasBytecodeBreakpointAt(const KBCInstr* next_pc) const {
CodeBreakpoint* cbpt = code_breakpoints_;
while (cbpt != nullptr) {
if ((reinterpret_cast<uword>(next_pc)) == cbpt->pc_ && cbpt->IsEnabled()) {
ASSERT(cbpt->IsInterpreted());
return true;
}
cbpt = cbpt->next();
}
return false;
}
#endif // !PRODUCT
} // namespace dart
#endif // !defined(DART_PRECOMPILED_RUNTIME)