dart-sdk/runtime/vm/code_observers.h
Clement Skau 844626c4e6 [VM] Copies Dart_CodeObserver in Init to prevent use-after-free.
Dart_CodeObserver is a struct (in dart_api.h) with two pointers:
  void* data;
  void (*Dart_OnNewCodeCallback)(...) on_new_code;

Change-Id: I556b73e0e3488a10f9fd162af24e36ad4f240fa1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111723
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
2019-08-05 10:46:29 +00:00

90 lines
2.4 KiB
C++

// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
#ifndef RUNTIME_VM_CODE_OBSERVERS_H_
#define RUNTIME_VM_CODE_OBSERVERS_H_
#include "vm/allocation.h"
#include "vm/globals.h"
#include "include/dart_api.h"
namespace dart {
#ifndef PRODUCT
class Mutex;
// An abstract representation of comments associated with the given code
// object. We assume that comments are sorted by PCOffset.
class CodeComments : public ValueObject {
public:
CodeComments() = default;
virtual ~CodeComments() = default;
virtual intptr_t Length() const = 0;
virtual intptr_t PCOffsetAt(intptr_t index) const = 0;
virtual const char* CommentAt(intptr_t index) const = 0;
};
// Object observing code creation events. Used by external profilers and
// debuggers to map address ranges to function names.
class CodeObserver {
public:
CodeObserver() {}
virtual ~CodeObserver() {}
// Returns true if this observer is active and should be notified
// about newly created code objects.
virtual bool IsActive() const = 0;
// Notify code observer about a newly created code object with the
// given properties.
virtual void Notify(const char* name,
uword base,
uword prologue_offset,
uword size,
bool optimized,
const CodeComments* comments) = 0;
private:
DISALLOW_COPY_AND_ASSIGN(CodeObserver);
};
class CodeObservers : public AllStatic {
public:
static void Init();
static void RegisterExternal(Dart_CodeObserver observer);
static void Register(CodeObserver* observer);
// Notify all active code observers about a newly created code object.
static void NotifyAll(const char* name,
uword base,
uword prologue_offset,
uword size,
bool optimized,
const CodeComments* comments);
// Returns true if there is at least one active code observer.
static bool AreActive();
static void Cleanup();
static Mutex* mutex() { return mutex_; }
private:
static Mutex* mutex_;
static intptr_t observers_length_;
static CodeObserver** observers_;
};
#endif // !PRODUCT
} // namespace dart
#endif // RUNTIME_VM_CODE_OBSERVERS_H_