mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 08:24:39 +00:00
0425997b31
This reverts commit 3d14b75f97.
An Isolate Group (IG) is a collection of isolates which were spawned from the
same source. This allows the VM to:
* have a guarantee that all isolates within one IG can safely exchange
structured objects (currently we rely on embedder for this
guarantee)
* hot-reload all isolates together (currently we only reload one
isolate, leaving same-source isolates in inconsistent state)
* make a shared heap for all isolates from the same IG, which paves
the way for faster communication and sharing of immutable objects.
All isolates within one IG will share the same IsolateGroupSource.
**Embedder changes**
This change makes breaking embedder API changes to support this new
concept of Isolate Groups: The existing isolate lifecycle callbacks
given to Dart_Initialize will become Isolate Group lifecycle callbacks.
A new callback `initialize_isolate` callback will be added which can
initialize a new isolate within an existing IG.
Existing embedders can be updated by performing the following renames
Dart_CreateIsolate -> Dart_CreateIsolateGroup
Dart_IsolateCreateCallback -> Dart_IsolateGroupCreateCallback
Dart_IsolateCleanupCallback -> Dart_IsolateGroupShutdownCallback
Dart_CreateIsolateFromKernel -> Dart_CreateIsolateGroupFromKernel
Dart_CurrentIsolateData -> Dart_CurrentIsolateGroupData
Dart_IsolateData -> Dart_IsolateGroupData
Dart_GetNativeIsolateData -> Dart_GetNativeIsolateGroupData
Dart_InitializeParams.create -> Dart_InitializeParams.create_group
Dart_InitializeParams.cleanup -> Dart_InitializeParams.shutdown_group
Dart_InitializeParams.shutdown -> Dart_InitializeParams.shutdown_isolate
By default `Isolate.spawn` will cause the creation of a new IG.
Though an embedder can opt-into supporting multiple isolates within one IG by
providing a callback to the newly added `Dart_InitializeParams.initialize_isolate`.
The responsibility of this new callback is to initialize an existing
isolate (which was setup by re-using source code from the spawning
isolate - i.e. the one which used `Isolate.spawn`) by setting native
resolvers, initializing global state, etc.
Issue https://github.com/dart-lang/sdk/issues/36648
Issue https://github.com/dart-lang/sdk/issues/36097
Original review: https://dart-review.googlesource.com/c/sdk/+/105241
Difference to original review:
* Give each isolate it's own [Loader] (for now)
* Sort classes during initialization for spawned isolates if app-jit is used (to match main isolate)
* Fix IsolateData memory leak if isolate startup fails
Difference to first reland(Patchset 2):
* Fix typo where memory was freed twice.
Change-Id: Ib1c83fe83b629cd50ae6af90ee99fdd44da882d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108367
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
85 lines
2.7 KiB
C++
85 lines
2.7 KiB
C++
// Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_INCLUDE_DART_EMBEDDER_API_H_
|
|
#define RUNTIME_INCLUDE_DART_EMBEDDER_API_H_
|
|
|
|
#include "include/dart_api.h"
|
|
#include "include/dart_tools_api.h"
|
|
|
|
namespace dart {
|
|
namespace embedder {
|
|
|
|
// Initialize all subsystems of the embedder.
|
|
// Returns true on success and false otherwise, in which case error would
|
|
// contain error message.
|
|
DART_WARN_UNUSED_RESULT bool InitOnce(char** error);
|
|
|
|
// Common arguments that are passed to isolate creation callback and to
|
|
// API methods that create isolates.
|
|
struct IsolateCreationData {
|
|
// URI for the main script that will be running in the isolate.
|
|
const char* script_uri;
|
|
|
|
// Advisory name of the main method that will be run by isolate.
|
|
// Only used for error messages.
|
|
const char* main;
|
|
|
|
// Isolate creation flags. Might be absent.
|
|
Dart_IsolateFlags* flags;
|
|
|
|
// Isolate group callback data.
|
|
void* isolate_group_data;
|
|
|
|
// Isolate callback data.
|
|
void* isolate_data;
|
|
};
|
|
|
|
// Create and initialize kernel-service isolate. This method should be used
|
|
// when VM invokes isolate creation callback with DART_KERNEL_ISOLATE_NAME as
|
|
// script_uri.
|
|
// The isolate is created from the given snapshot (might be kernel data or
|
|
// app-jit snapshot).
|
|
DART_WARN_UNUSED_RESULT Dart_Isolate
|
|
CreateKernelServiceIsolate(const IsolateCreationData& data,
|
|
const uint8_t* buffer,
|
|
intptr_t buffer_size,
|
|
char** error);
|
|
|
|
// Service isolate configuration.
|
|
struct VmServiceConfiguration {
|
|
enum {
|
|
kBindHttpServerToAFreePort = 0,
|
|
kDoNotAutoStartHttpServer = -1
|
|
};
|
|
|
|
// Address to which HTTP server will be bound.
|
|
const char* ip;
|
|
|
|
// Default port. See enum above for special values.
|
|
int port;
|
|
|
|
// TODO(vegorov) document these ones.
|
|
bool dev_mode;
|
|
bool deterministic;
|
|
bool disable_auth_codes;
|
|
};
|
|
|
|
// Create and initialize vm-service isolate. This method should be used
|
|
// when VM invokes isolate creation callback with DART_VM_SERVICE_ISOLATE_NAME
|
|
// as script_uri.
|
|
// The isolate is created from the given kernel binary that is expected to
|
|
// contain all necessary vmservice libraries.
|
|
DART_WARN_UNUSED_RESULT Dart_Isolate
|
|
CreateVmServiceIsolate(const IsolateCreationData& data,
|
|
const VmServiceConfiguration& config,
|
|
const uint8_t* kernel_buffer,
|
|
intptr_t kernel_buffer_size,
|
|
char** error);
|
|
|
|
} // namespace embedder
|
|
} // namespace dart
|
|
|
|
#endif // RUNTIME_INCLUDE_DART_EMBEDDER_API_H_
|