mirror of
https://github.com/dart-lang/sdk
synced 2024-10-14 16:55:08 +00:00
5230995e3a
This change fixes the following 2 bugs related to unwinding records on Windows: 1) When cross-compiling from another OS to Windows, unwinding records were not added to the end of the code section. Later, when loading AOT snapshot, arbitrary bytes at the end of the code section were used as the unwinding data, which could result in the errors returned from Windows API calls. 2) When code section is mapped, its size was rounded up to the page size; when looking for unwinding record, size of the unwinding record was subtracted from the rounded size. This is not correct as unwinding record is placed right at the end of code section, so code section size should be used before rounding. Also, magic value is added to the unwinding record in order to verify that it is preserved and correctly found. TEST=Manually tested repro from b/320642692 TEST=ffi/ffi_induce_a_crash_test Fixes b/320642692 Fixes https://github.com/dart-lang/sdk/issues/54206 Change-Id: Id0c6413cd1b759da9e9f25f7617eef55f33b04a2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/346940 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com> |
||
---|---|---|
.. | ||
co19 | ||
corelib | ||
dartdevc | ||
ffi | ||
language | ||
lib | ||
modular | ||
standalone | ||
web | ||
legacy_status_dart2js.csv | ||
OWNERS | ||
README.md |
This directory contains tests of the language and core library implementations. For more information, see https://github.com/dart-lang/sdk/wiki/Testing.