mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 01:30:32 +00:00
51fa4aaac8
Address comments from Lasse in https://dart-review.googlesource.com/c/sdk/+/331210. Namely: * Use 100ms for the interval, so avoid overlap with the safety-margin of 40ms * Rewrite comment to only discuss the safety margin in terms of an early dispatch * Only use the safety margin on web backends. Unlike timer_test, I am using the presence of `dart.library.js` instead. Going forward it's possible that dart2wasm hits this issue if it relies on browser's timers. I also copied the changes to lib_2 since flakiness is seen there too. Change-Id: I71b6365346cccc7667dbe3da809b1bfd192ff38a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333057 Reviewed-by: Lasse Nielsen <lrn@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com> |
||
|---|---|---|
| .. | ||
| analyzer | ||
| async | ||
| collection | ||
| convert | ||
| developer | ||
| fix_data_tests | ||
| html | ||
| isolate | ||
| js | ||
| js_interop_unsafe | ||
| math | ||
| mirrors | ||
| typed_data | ||
| web | ||
| lib.status | ||
| lib_analyzer.status | ||
| lib_app_jit.status | ||
| lib_dart2js.status | ||
| lib_dartdevc.status | ||
| lib_kernel.status | ||
| lib_precompiled.status | ||
| lib_vm.status | ||