dart-sdk/tests/lib/async
Sigmund Cherem 51fa4aaac8 [tests] follow up comments on peridic_timer tests
Address comments from Lasse in
https://dart-review.googlesource.com/c/sdk/+/331210. Namely:

* Use 100ms for the interval, so avoid overlap with the safety-margin of 40ms
* Rewrite comment to only discuss the safety margin in terms of an early
  dispatch
* Only use the safety margin on web backends. Unlike timer_test, I am
  using the presence of `dart.library.js` instead. Going forward it's
  possible that dart2wasm hits this issue if it relies on browser's
  timers.

I also copied the changes to lib_2 since flakiness is seen there too.

Change-Id: I71b6365346cccc7667dbe3da809b1bfd192ff38a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333057
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2023-11-07 17:47:20 +00:00
..
async_await_sync_completer_test.dart [nnbd/test] Fix tests that are failing in strong mode 2020-03-27 00:14:40 +00:00
async_await_zones_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
async_no_await_zones_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors.dart Add onError extension method to Future. 2021-01-21 23:13:56 +00:00
catch_errors2_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors3_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors4_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors5_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors6_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors7_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors8_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors11_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors12_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors13_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors14_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors15_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors16_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors17_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors18_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors19_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors20_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors21_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors22_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors23_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors24_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors25_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors26_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors27_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors28_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
catch_errors_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
dart2js_uncaught_error_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
event_helper.dart Remove uses of : as default value separator in some tests/ directories. 2022-09-07 14:49:17 +00:00
first_regression_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
future_constructor2_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
future_constructor_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
future_delayed_error_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
future_error_test.dart Remove uses of, and need for, Expect.throwsNullCheckedError. 2020-11-11 13:30:30 +00:00
future_extension_test.dart Spelling tests 2022-12-19 12:56:47 +00:00
future_foreach_test.dart [cfe] Report error on missing return from non-nullable function 2020-03-24 08:21:36 +00:00
future_future_test.dart Fix errors in Future implementation around Future<Future<X>>. 2020-12-14 16:34:28 +00:00
future_iterable_extension_test.dart Typo in future_iterable_extension_test 2023-04-17 08:20:14 +00:00
future_microtask_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
future_onerror_test.dart Update Future.onError extension method. 2023-02-18 12:01:45 +00:00
future_or_bad_type_test.dart Migrate corelib and lib tests off @compile-error. 2023-04-20 19:19:01 +00:00
future_or_only_in_async_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
future_or_strong_test.dart [tests] Cleaning up strong mode tests. 2020-03-16 16:54:56 +00:00
future_or_type_test.dart [nnbd] Fix the remaining futures tests in strong mode 2020-04-15 18:30:23 +00:00
future_record_extension_test.dart Add record-related wait extensions on Future tuples. 2023-04-04 11:39:49 +00:00
future_regression_48493_test.dart Reland "Fix bug in Completer.complete." 2023-05-02 19:33:57 +00:00
future_test.dart Refactor tests away from onError which is deprecated 2022-09-07 14:42:27 +00:00
future_timeout_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
future_value_chain2_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
future_value_chain3_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
future_value_chain4_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
future_value_chain_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
futures_test.dart [cfe] Update greatest closure of ? to Object? 2020-05-04 08:14:43 +00:00
intercept_print1_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
intercept_schedule_microtask1_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
intercept_schedule_microtask2_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
intercept_schedule_microtask3_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
intercept_schedule_microtask4_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
intercept_schedule_microtask5_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
intercept_schedule_microtask6_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
multiple_timer_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
null_future_zone_test.dart Revert "Make nullFuture be per-zone." 2022-06-24 14:13:39 +00:00
periodic_timer2_test.dart [tests] follow up comments on peridic_timer tests 2023-11-07 17:47:20 +00:00
periodic_timer3_test.dart [tests] follow up comments on peridic_timer tests 2023-11-07 17:47:20 +00:00
periodic_timer4_test.dart [tests] follow up comments on peridic_timer tests 2023-11-07 17:47:20 +00:00
regress46319_test.dart [ddc] Add unspecified nullability regression test 2021-06-10 20:18:53 +00:00
regress154963234_strong_test.dart [tests] Add regression tests for internal issue 2020-04-28 23:49:43 +00:00
regress154963234_weak_test.dart [tests] Add regression tests for internal issue 2020-04-28 23:49:43 +00:00
run_zoned1_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
run_zoned4_test.dart New implementation of runZoned. 2020-03-25 00:24:33 +00:00
run_zoned5_test.dart New implementation of runZoned. 2020-03-25 00:24:33 +00:00
run_zoned6_test.dart New implementation of runZoned. 2020-03-25 00:24:33 +00:00
run_zoned7_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
run_zoned8_test.dart [nnbd] Fix some async tests in strong mode 2020-04-09 22:01:42 +00:00
run_zoned9_test.dart Refactor tests away from onError which is deprecated 2022-09-07 14:42:27 +00:00
schedule_microtask2_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
schedule_microtask3_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
schedule_microtask5_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
schedule_microtask_test.dart [cfe] Report error on missing return from non-nullable function 2020-03-24 08:21:36 +00:00
slow_consumer2_test.dart Add interface to a few classes which had missed it. 2023-05-24 14:04:27 +00:00
slow_consumer3_test.dart Add interface to a few classes which had missed it. 2023-05-24 14:04:27 +00:00
slow_consumer_test.dart Add interface to a few classes which had missed it. 2023-05-24 14:04:27 +00:00
stack_trace01_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stack_trace02_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace03_test.dart Improve asynchronous test failures and async_minitest. 2020-03-11 01:12:48 +00:00
stack_trace04_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stack_trace05_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace06_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace07_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace08_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace09_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stack_trace10_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stack_trace11_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace12_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace13_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace14_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace15_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace16_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace17_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace18_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace19_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stack_trace20_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stack_trace21_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stack_trace22_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stack_trace23_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stack_trace24_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stack_trace25_test.dart [cfe] Handle throw in return type inference 2020-03-27 15:59:27 +00:00
stream_controller_add_error_test.dart Remove uses of, and need for, Expect.throwsNullCheckedError. 2020-11-11 13:30:30 +00:00
stream_controller_async_test.dart [cfe] Update greatest closure of ? to Object? 2020-05-04 08:14:43 +00:00
stream_controller_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_distinct_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_empty_test.dart Fix behavior of Stream.empty. 2023-08-17 15:26:59 +00:00
stream_error_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_event_transformed_test.dart New implementation of runZoned. 2020-03-25 00:24:33 +00:00
stream_first_where_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_from_futures_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_from_iterable_test.dart Refactor to implement Stream.fromIterator more directly. 2022-06-16 11:39:30 +00:00
stream_iterator_double_cancel_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_iterator_test.dart Harden StreamIterator against out-of-order events. 2020-10-16 20:20:02 +00:00
stream_join_test.dart [nnbd] Fix remaining async tests in strong mode. 2020-04-16 21:15:45 +00:00
stream_last_where_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_listen_zone_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_multi_test.dart Fix bug in Stream.multi. 2020-08-21 09:53:10 +00:00
stream_periodic2_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_periodic3_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_periodic4_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_periodic5_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_periodic6_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_periodic_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_single_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_single_to_multi_subscriber_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_state_helper.dart Spelling tests 2023-01-19 16:24:29 +00:00
stream_state_nonzero_timer_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_state_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_subscription_as_future_test.dart New implementation of runZoned. 2020-03-25 00:24:33 +00:00
stream_subscription_cancel_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_take_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_timeout_test.dart Make StackTrace generally not nullable in migrated NNBD library. 2020-03-19 23:31:30 +00:00
stream_transform_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_transformation_broadcast_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_transformer_from_bind_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_transformer_from_handlers_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_transformer_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_type_test.dart [cfe] Report error on missing return from non-nullable function 2020-03-24 08:21:36 +00:00
stream_value_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_view_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
stream_zones_test.dart New implementation of runZoned. 2020-03-25 00:24:33 +00:00
syncstar_mixed_iterators_test.dart [vm] Cleanup old async/async*/sync* implementation from kernel 2022-07-11 18:12:41 +00:00
timer_cancel1_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
timer_cancel2_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
timer_cancel_test.dart Fix timer_cancel_test. 2020-02-15 02:40:00 +00:00
timer_isActive_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
timer_repeat_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
timer_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
unawaited_error_test.dart [cfe] Add UnresolvedKind for fine grained unresolved reporting 2021-08-25 09:51:54 +00:00
unawaited_test.dart Make unawaited accept a nullable argument. 2021-09-27 11:58:16 +00:00
uncaught_error_handler_throws_test.dart Reland "Make throwing Zone.uncaughtError handlers propagate the error to their parent zone." 2021-04-23 05:24:41 +00:00
wait_for_cancel_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_async_error_test.dart Remove uses of, and need for, Expect.throwsNullCheckedError. 2020-11-11 13:30:30 +00:00
zone_bind_callback_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_bind_callback_unary_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_bind_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_create_periodic_timer_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_create_timer2_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_create_timer_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_debug_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_empty_description2_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_empty_description_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_error_callback_test.dart [tests/nnbd] Fix lib/async/zone_error_callback_test for NNBD strong mode 2020-04-03 21:47:37 +00:00
zone_fork_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_future_schedule_microtask_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_register_callback_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_register_callback_unary_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_root_bind_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_run_guarded_test.dart Migrate lib_2/async to NNBD. 2020-01-09 22:04:37 +00:00
zone_run_test.dart [cfe] Report error on missing return from non-nullable function 2020-03-24 08:21:36 +00:00
zone_run_unary_test.dart [cfe] Update greatest closure of ? to Object? 2020-05-04 08:14:43 +00:00
zone_value_test.dart Fixed various typos in a lot of files 2022-07-25 12:21:59 +00:00