755432f73e
This reverts parts of https://dart-review.googlesource.com/c/sdk/+/289444 The code needs to be reinstated as flutter has tests which verify that certain data-driven fixes work, which happen to be uses of deprecated members, from the same package. See this failure for example: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8785707696655090305/+/u/analyze_flutter_flutter/stdout?format=raw The linter bump is kept the same, and some code which was unnecessarily coupled tightly with DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE is kept the same. The big test refactor which was included in 289444 is also kept the same, only a few tests are added to verify HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE gets reported. Bug: https://github.com/dart-lang/sdk/issues/51678 Change-Id: I6852376b299d8375c720ea56dc6a6a6119de3364 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291054 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> |
||
---|---|---|
.. | ||
_fe_analyzer_shared | ||
_js_interop_checks | ||
analysis_server | ||
analysis_server_client | ||
analyzer | ||
analyzer_cli | ||
analyzer_plugin | ||
analyzer_utilities | ||
async_helper | ||
build_integration | ||
compiler | ||
dart2js_info | ||
dart2js_runtime_metrics | ||
dart2js_tools | ||
dart2native | ||
dart2wasm | ||
dart_internal | ||
dartdev | ||
dds | ||
dds_service_extensions | ||
dev_compiler | ||
expect | ||
front_end | ||
frontend_server | ||
js | ||
js_ast | ||
js_runtime | ||
js_shared | ||
kernel | ||
language_versioning_2_7_test | ||
meta | ||
mmap | ||
modular_test | ||
native_stack_traces | ||
nnbd_migration | ||
scrape | ||
smith | ||
sourcemap_testing | ||
status_file | ||
telemetry | ||
test_runner | ||
testing | ||
vm | ||
vm_service | ||
vm_snapshot_analysis | ||
wasm_builder | ||
.gitignore | ||
analysis_options.yaml | ||
BUILD.gn | ||
OWNERS | ||
pkg.dart | ||
pkg.status | ||
README.md |
Package validation
The packages in pkg/
are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps
package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/
which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency