mirror of
https://github.com/dart-lang/sdk
synced 2024-11-05 18:22:09 +00:00
0aa481ad94
The asyncStart/asyncEnd implementation maintains a counter that will
signify to the test framework the test is done as soon as the counter
reaches 0 again.
This means we have to ensure the counter is >0 as long as any test is
running.
The standalone/io/http_client_connect_test wasn't doing that as it has
code like this
main() async {
...
await foo();
await bar();
...
}
foo() async {
asyncStart();
...
asyncEnd();
}
bar() async {
asyncStart();
...
asyncEnd();
}
So the test is considered done after the `await foo()` decremented the
counter back to 0.
TEST=Fixes flaky standalone{,_2}/io/http_client_connect_test on iso-stress builder
Change-Id: I71a89d740a814df7364153ef79bad9dd85dc9b3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/327862
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
|
||
|---|---|---|
| .. | ||
| co19 | ||
| co19_2 | ||
| corelib | ||
| corelib_2 | ||
| dartdevc | ||
| dartdevc_2 | ||
| ffi | ||
| ffi_2 | ||
| language | ||
| language_2 | ||
| lib | ||
| lib_2 | ||
| modular | ||
| standalone | ||
| standalone_2 | ||
| web | ||
| web_2 | ||
| legacy_status_dart2js.csv | ||
| OWNERS | ||
| README.md | ||
This directory contains tests of the language and core library implementations. For more information, see https://github.com/dart-lang/sdk/wiki/Testing.