dart-sdk/pkg
Oleh Prypin 6bd0bb4fec Revert "[dart2js] Use symbols for isolate tags"
This reverts commit 58f4b3a7a6.

Reason for revert: Causes build failures in google3 - b/295404395

Original change's description:
> [dart2js] Use symbols for isolate tags
>
> All supported browsers have JavaScript Symbols so use Symbols.
> Avoiding string property names should fix a bug where separate
> programs running in separate iframes arrive at using the same
> property.
>
> Issue: #53154
> Change-Id: I470dc47de3ad381aeab670cf62d62e53f2e72873
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319865
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Commit-Queue: Stephen Adams <sra@google.com>

Issue: #53154
Change-Id: I581fe08aee6ac9e2d74e813641a942223553cf5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/319980
Auto-Submit: Oleh Prypin <oprypin@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Oleh Prypin <oprypin@google.com>
2023-08-11 12:48:31 +00:00
..
_fe_analyzer_shared [parser] Fix issue 52954 about nested record destructuring with shorthand 2023-08-11 09:19:31 +00:00
_js_interop_checks [dart:js_interop] Disallow user @staticInterop classes from subtyping most dart:_js_types types 2023-08-08 19:17:25 +00:00
analysis_server [analysis_server] Fix flaky test 2023-08-10 19:01:24 +00:00
analysis_server_client [analysis_server] Change LSP-over-Legacy to be wrapped with the original protocol 2023-08-06 14:32:18 +00:00
analyzer Extension types. Report deferred superinterfaces. 2023-08-10 23:17:35 +00:00
analyzer_cli Update old linter site links to dart.dev 2023-08-04 19:45:23 +00:00
analyzer_plugin [analysis_server] Don't produce fix-all-in-file fixes when there's no individual fix 2023-08-08 18:20:39 +00:00
analyzer_utilities
async_helper
bisect_dart [tool] Bisection tool 2023-07-13 13:22:26 +00:00
build_integration
compiler Revert "[dart2js] Use symbols for isolate tags" 2023-08-11 12:48:31 +00:00
dap
dart2js_info [dart2js] cleanup backend usage (I) 2023-08-10 22:45:54 +00:00
dart2js_runtime_metrics
dart2js_tools
dart2native
dart2wasm [dart2wasm] Fix normalization of nullable FutureOr 2023-08-11 09:08:32 +00:00
dart_internal Increase maximum sdk version constraint on dart_internal to 3.3.0 2023-07-27 00:29:42 +00:00
dartdev [deps] rev native 2023-08-08 19:32:30 +00:00
dds [ DDS ] Prepare for 2.9.4 release 2023-08-01 22:59:17 +00:00
dds_service_extensions
dev_compiler [ddc] Stop modifying the native JavaScript Object prototype 2023-08-10 19:45:59 +00:00
expect
front_end [cfe] Compute instantiated representation type 2023-08-11 10:32:00 +00:00
frontend_server
js
js_ast
js_runtime
js_shared
kernel [cfe] Compute instantiated representation type 2023-08-11 10:32:00 +00:00
language_versioning_2_7_test
meta meta 1.10.0 2023-08-09 18:07:32 +00:00
mmap
modular_test [modular_test] second attempt to fix shards. 2023-07-27 22:29:07 +00:00
native_stack_traces [vm] Rework awaiter stack unwinding. 2023-06-30 14:03:03 +00:00
nnbd_migration Expose greatestLowerBound() from TypeSystem. 2023-08-04 20:47:46 +00:00
scrape
smith
sourcemap_testing
status_file [infra] Make the sanitizer a first-class status variable. 2023-07-10 17:46:31 +00:00
telemetry
test_runner [ddc] Seal the native Object prototype in test infra 2023-08-10 19:45:59 +00:00
testing
vm [cfe] Compute instantiated representation type 2023-08-11 10:32:00 +00:00
vm_service [dart:developer] Add static Service.getObjectId method 2023-08-04 14:18:38 +00:00
vm_service_protos
vm_snapshot_analysis [pkg/vm_snapshot_analysis] Allow old 'patched_class_' field. 2023-07-07 11:36:59 +00:00
wasm_builder [wasm_builder] Fix failure type of br_on_cast[_fail] 2023-08-09 08:24:37 +00:00
.gitignore
analysis_options.yaml
BUILD.gn
OWNERS
pkg.dart
pkg.status
README.md

Package validation

The packages in pkg/ are automatically validated on the LUCI CI bots. The validation is largely done by the tools/package_deps package; it can be tested locally via:

dart tools/package_deps/bin/package_deps.dart

Packages which are published

There are several packages developed in pkg/ which are published to pub. Validation of these packages is particularly important because the pub tools are not used for these packages during development; we get our dependency versions from the DEPS file. Its very easy for the dependencies specified in a package's pubspec file to get out of date wrt the packages and versions actually used.

In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that we don't use relative path deps to pkg/ or third_party/ packages

Packages which are not published

For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:

# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none

These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.

We validate:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that a reference to a pkg/ package is done via a relative path dependency