mirror of
https://github.com/dart-lang/sdk
synced 2024-11-02 08:44:27 +00:00
92e5746494
This is a reland of commit 1755f89092
Can land after (or with) the Flutter PR:
https://github.com/flutter/engine/pull/40434
Original change's description:
> [vm/ffi] Add class modifiers
>
> Adds class modifiers to `dart:ffi`.
>
> Migrates all user-defined subclasses of `Struct`, `Union`, `Opaque`,
> and `AbiSpecificInteger` to be `final class`es.
>
> Does not remove the manual error checking, so some errors will show up
> twice now in language version 3.0. In language version <3.0, only the
> FFI-specific error will show up.
>
> In a follow-up CL, we will try to make the language-errors to show up
> also <3.0 so that we can remove the FFI-specific errors.
>
> Examples of duplicated errors:
> pkg/analyzer/test/src/diagnostics/subtype_of_ffi_class_test.dart
>
> TEST=pkg/analyzer/test/ (for the analyzer)
> TEST=pkg/front_end/testcases/ (for the CFE)
> TEST=test/ffi/ (for the VM)
>
> CoreLibraryReviewExempt: No need for dart2js to review.
> Bug: https://github.com/dart-lang/sdk/issues/51683
> Change-Id: I2964ceccb7db59fbdaf6be5319f5e4ec2dabe0f3
> Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-win-release-try,pkg-mac-release-try,vm-precomp-ffi-qemu-linux-release-riscv64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-android-debug-arm-try,vm-reload-rollback-linux-debug-x64-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289223
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Reviewed-by: Devon Carew <devoncarew@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Jackson Gardner <jacksongardner@google.com>
> Reviewed-by: Lasse Nielsen <lrn@google.com>
> Commit-Queue: Daco Harkes <dacoharkes@google.com>
TEST=pkg/analyzer/test/ (for the analyzer)
TEST=pkg/front_end/testcases/ (for the CFE)
TEST=test/ffi/ (for the VM)
CoreLibraryReviewExempt: No need for dart2js to review.
Bug: https://github.com/dart-lang/sdk/issues/51683
Change-Id: I2ee3f0ac31d4162068a2346a06320029b2263ee2
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-win-release-try,pkg-mac-release-try,vm-precomp-ffi-qemu-linux-release-riscv64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-android-debug-arm-try,vm-reload-rollback-linux-debug-x64-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289781
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
104 lines
2.2 KiB
Dart
104 lines
2.2 KiB
Dart
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:ffi';
|
|
|
|
import "package:expect/expect.dart";
|
|
import "package:ffi/ffi.dart";
|
|
|
|
main(List<String> arguments) {
|
|
for (int i = 0; i < 100; i++) {
|
|
testStoreLoad();
|
|
testReifiedGeneric();
|
|
testCompoundLoadAndStore();
|
|
}
|
|
}
|
|
|
|
testStoreLoad() {
|
|
final p = calloc<Int8>(2);
|
|
p.value = 10;
|
|
Expect.equals(10, p.value);
|
|
p[1] = 20;
|
|
Expect.equals(20, p[1]);
|
|
if (sizeOf<IntPtr>() == 4) {
|
|
// Test round tripping.
|
|
Expect.equals(20, p.elementAt(0x100000001).value);
|
|
Expect.equals(20, p[0x100000001]);
|
|
}
|
|
|
|
// Test negative index.
|
|
final pUseNegative = p.elementAt(1);
|
|
Expect.equals(10, pUseNegative[-1]);
|
|
|
|
final p1 = calloc<Double>(2);
|
|
p1.value = 10.0;
|
|
Expect.approxEquals(10.0, p1.value);
|
|
p1[1] = 20.0;
|
|
Expect.approxEquals(20.0, p1[1]);
|
|
calloc.free(p1);
|
|
|
|
final p2 = calloc<Pointer<Int8>>(2);
|
|
p2.value = p;
|
|
Expect.equals(p, p2.value);
|
|
p2[1] = p;
|
|
Expect.equals(p, p2[1]);
|
|
calloc.free(p2);
|
|
calloc.free(p);
|
|
|
|
final p3 = calloc<Foo>();
|
|
Foo foo = p3.ref;
|
|
foo.a = 1;
|
|
Expect.equals(1, foo.a);
|
|
calloc.free(p3);
|
|
|
|
final p4 = calloc<Foo>(2);
|
|
Foo src = p4[1];
|
|
src.a = 2;
|
|
p4.ref = src;
|
|
Foo dst = p4.ref;
|
|
Expect.equals(2, dst.a);
|
|
calloc.free(p4);
|
|
}
|
|
|
|
testReifiedGeneric() {
|
|
final p = calloc<Pointer<Int8>>();
|
|
Pointer<Pointer<NativeType>> p2 = p;
|
|
Expect.isTrue(p2.value is Pointer<Int8>);
|
|
calloc.free(p);
|
|
}
|
|
|
|
testCompoundLoadAndStore() {
|
|
final foos = calloc<Foo>(10);
|
|
final reference = foos.ref..a = 10;
|
|
|
|
for (var i = 1; i < 9; i++) {
|
|
foos[i] = reference;
|
|
Expect.isTrue(foos[i].a == 10);
|
|
|
|
foos.elementAt(i).ref = reference;
|
|
Expect.isTrue(foos.elementAt(i).ref.a == 10);
|
|
}
|
|
|
|
final bars = calloc<Bar>(10);
|
|
bars[0].foo = reference;
|
|
|
|
for (var i = 1; i < 9; i++) {
|
|
bars[i] = bars[0];
|
|
Expect.isTrue(bars.elementAt(i).ref.foo.a == 10);
|
|
}
|
|
|
|
calloc.free(foos);
|
|
calloc.free(bars);
|
|
}
|
|
|
|
final class Foo extends Struct {
|
|
@Int8()
|
|
external int a;
|
|
}
|
|
|
|
final class Bar extends Union {
|
|
external Foo foo;
|
|
@Int32()
|
|
external int baz;
|
|
}
|