languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 18:31:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/runtime
History
Ivan Inozemtsev 3370a4e393 Revert "Reapply "[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer"" 
This reverts commit 44d4451476.

Reason for revert: b/350443042

Original change's description:
> Reapply "[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer"
>
> In the previous version of this change, if the user had 'dart' on their
> PATH and invoked 'dart compile js' (which spawns the VM service after
> compilation completes), the VM service would attempt to spawn DDS using
> './dart' as the executable path instead of 'dart'. This would result in
> DDS failing to start, causing the VM to print an error and hang.
>
> This updated change checks to see if the parent directory of
> `Platform.executable` is '.' and then verifies if './dart' exists or
> not. If it doesn't, 'dart' is likely on the user's PATH and should be
> used directly as the executable path.
>
> See https://github.com/dart-lang/sdk/issues/56087 for details.
>
> This reverts commit 4b88698e48.
>
> TEST=pkg/dds/test/control_web_server_starts_dds_with_dart_on_path_test.dart
>
> Change-Id: Id0f1dadd01d9202cbf7717f31393b43171cf3968
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373561
> Auto-Submit: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Derek Xu <derekx@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>

Change-Id: I424c4b91b0b108ae4c9dffa0059ed90c918897e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373744
Reviewed-by: Siva Annamalai <asiva@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
2024-07-01 18:30:28 +00:00
..
bin Reland "[vm] Move ResolveUri to bin" 2024-06-26 11:10:06 +00:00
docs [vm] Cleanup obsolete pragma vm:non-nullable-result-type 2024-06-20 20:24:44 +00:00
include Add 'coverage' flag, defaulting to true, but let the gn application_snapshot default it to false 2024-06-18 09:10:00 +00:00
lib Reland "[vm] Move ResolveUri to bin" 2024-06-26 11:10:06 +00:00
observatory Revert "Reapply "[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer"" 2024-07-01 18:30:28 +00:00
platform Reland "[vm] Move ResolveUri to bin" 2024-06-26 11:10:06 +00:00
tests [vm,aot] Fix type check in implicit setter of a covariant field 2024-06-25 14:34:20 +00:00
tools [vm] Remove --[no-]lazy-dispatchers flag. 2024-06-06 10:56:12 +00:00
vm [vm/compiler] Improve ConstantPoolTrait::Hash 2024-06-30 22:49:32 +00:00
.clang-tidy
.gitignore
BUILD.gn [vm, compiler] Allow targeting TSAN or MSAN by passing a flag to gen_snapshot. 2024-05-08 17:03:59 +00:00
codereview.settings
configs.gni
CPPLINT.cfg
OWNERS
PRESUBMIT.py
runtime_args.gni Reland "[Fuchsia] Remove the legacy gn build rules for fuchsia" 2024-03-14 20:22:12 +00:00
vm-jit.shard.cml [test] Cleanup building Fuchsia packages/components. 2023-10-31 17:11:51 +00:00
vm.shard.cml [fuchsia][sysmem2] route fuchsia.sysmem2.Allocator 2024-05-10 17:00:29 +00:00