mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 03:36:59 +00:00
d00bc2e89b
The named import makes it into the kernel class name (meaning it has a dot in it). That is currently not cleaned up when creating js code, but it is catched as a non-legal js identifier. ``` Unhandled exception: Invalid argument (name): not a valid identifier: "_Object$collection.ListMixin" #0 new Identifier (package:dev_compiler/src/js_ast/nodes.dart:1148) #1 ProgramCompiler._emitClassStatement (package:dev_compiler/src/kernel/compiler.dart:573) #2 ProgramCompiler._defineClass (package:dev_compiler/src/kernel/compiler.dart:679) #3 ProgramCompiler._emitClassDeclaration (package:dev_compiler/src/kernel/compiler.dart:501) #4 ProgramCompiler._emitClass (package:dev_compiler/src/kernel/compiler.dart:450) #5 List.forEach (dart:core-patch/dart:core/growable_array.dart:274) #6 ProgramCompiler._emitLibrary (package:dev_compiler/src/kernel/compiler.dart:393) #7 Iterable.forEach (dart:core/iterable.dart:226) #8 ProgramCompiler.emitProgram (package:dev_compiler/src/kernel/compiler.dart:282) #9 compileToJSModule (package:dev_compiler/src/kernel/command.dart:166) #10 _compile (package:dev_compiler/src/kernel/command.dart:145) ``` Bug: Change-Id: Ibb5a1c908c2ddba63600446f6062ced1b5dd34c2 Reviewed-on: https://dart-review.googlesource.com/28662 Reviewed-by: Peter von der Ahé <ahe@google.com> Commit-Queue: Jens Johansen <jensj@google.com> |
||
---|---|---|
.. | ||
angular | ||
co19 | ||
compiler | ||
corelib | ||
corelib_2 | ||
dart | ||
html | ||
isolate | ||
kernel | ||
language | ||
language_2 | ||
lib | ||
lib_2 | ||
search | ||
standalone | ||
standalone_2 | ||
light_unittest.dart | ||
README |
Run Existing Tests ================== See the output of ../tools/test.py --help for how to run tests. See also https://code.google.com/p/dart/wiki/Building#Testing for detailed examples. Create New Tests ================ See comments above factory StandardTestSuite.forDirectory in ../tools/testing/dart/test_suite.dart for the default test directory layout. By default test-file names must end in "_test.dart", but some test suites, such as ./co19, subclass StandardTestSuite and override this default. See comments at the beginning of ../tools/testing/dart/multitest.dart for how to create tests that pass by failing with a known error. For example, ... int x = "not an int"; /// 01: static type warning ... as part of a test will only pass the "--compiler dart2analyzer" test if the assignment generates a static type warning.