dart-sdk/pkg
Clement Skau 1bf25798fa Reland "[VM] Remove unnecessary Closure.clone() from sync*."
This reverts commit 430c75b5fa.

Reason for revert: We probably don't care about the dartkb breakages.

Original change's description:
> Revert "[VM] Remove unnecessary Closure.clone() from sync*."
> 
> This reverts commit ca94ad7112.
> 
> Reason for revert: Appears to break dartkb.
> 
> Original change's description:
> > [VM] Remove unnecessary Closure.clone() from sync*.
> > 
> > Instead, this CL wraps sync*'s sync_op in an additional function
> > that captures local copies of the necessary closure state.
> > Notably this state includes the parameters of the original sync* function
> > as these also need to be cloned for each instance.
> > 
> > 
> > Note: a large number of .expect files have a small number of changes
> > due to the additional wrapper function, as well as some extra plumbing.
> > 
> > Bug: https://github.com/dart-lang/sdk/issues/37753
> > Change-Id: If099dbfe9e5d62979626b852386fd0173fc76de5
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136190
> > Commit-Queue: Clement Skau <cskau@google.com>
> > Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> 
> TBR=vegorov@google.com,cskau@google.com
> 
> Change-Id: I89e517196f03622337f909f0fcecbdc77c9dda93
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: https://github.com/dart-lang/sdk/issues/37753
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144920
> Reviewed-by: Clement Skau <cskau@google.com>
> Commit-Queue: Clement Skau <cskau@google.com>

TBR=vegorov@google.com,cskau@google.com

Change-Id: I78589c83cbb17151ca4ab8f811b4f18f252fb9c1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/37753
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144921
Reviewed-by: Clement Skau <cskau@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
2020-04-28 06:17:20 +00:00
..
_fe_analyzer_shared Issue 40957. Report the language feature, and recommend to set SDK constraint. 2020-04-27 22:11:46 +00:00
_js_interop_checks Disallow non-external generative JS constructors 2020-03-06 17:06:39 +00:00
analysis_server Remove _coverageMarker and uses 2020-04-28 04:32:17 +00:00
analysis_server_client Enable omit_loval_variable_types in analysis_server_client 2020-03-30 03:59:07 +00:00
analysis_tool
analyzer analyzer: Fix message of REDIRECT_TO_INVALID_TYPE 2020-04-28 03:59:37 +00:00
analyzer_cli Treat the expect and async_helper packages as opted in to NNBD. 2020-04-27 21:04:56 +00:00
analyzer_plugin Completion bug fix - extended types will now be completable in extension declarations 2020-04-27 19:20:08 +00:00
async_helper Treat the expect and async_helper packages as opted in to NNBD. 2020-04-27 21:04:56 +00:00
build_integration
compiler [dart2js] Treat Object as a top type in weak mode. 2020-04-28 02:27:26 +00:00
dart2js_tools Use source-maps in test runner to expand JavaScript stack traces. 2020-01-24 20:00:13 +00:00
dart2native Treat the expect and async_helper packages as opted in to NNBD. 2020-04-27 21:04:56 +00:00
dart_internal analyzer: Do not allow errors to be ignored inline. Fixes #27218 2020-04-10 17:16:24 +00:00
dartdev [ VM / DartDev ] Make DartDev help message the default when running dart --help 2020-04-27 22:39:06 +00:00
dartfix Switch migration to the isolate client. 2020-04-08 19:55:14 +00:00
dds [ package:dds / Service ] Add support for service extensions to DDS 2020-04-24 17:13:57 +00:00
dev_compiler Revert "[BUILD] - Initial CL to unfork the NNBD Dart SDK" 2020-04-27 05:00:10 +00:00
diagnostic
expect Treat the expect and async_helper packages as opted in to NNBD. 2020-04-27 21:04:56 +00:00
front_end Reland "[VM] Remove unnecessary Closure.clone() from sync*." 2020-04-28 06:17:20 +00:00
frontend_server Treat the expect and async_helper packages as opted in to NNBD. 2020-04-27 21:04:56 +00:00
js Remove some stale JS interop known differences 2020-02-26 00:52:43 +00:00
js_ast
kernel Reland "[VM] Remove unnecessary Closure.clone() from sync*." 2020-04-28 06:17:20 +00:00
meta Opt package:meta in to null safety. 2020-04-28 03:54:48 +00:00
modular_test Fix another modular test expectation file. 2020-02-15 02:39:46 +00:00
native_stack_traces [vm] Fix non-symbolic stack traces with --lazy-async-stacks. 2020-04-23 09:31:08 +00:00
nnbd_migration Implement Factor in flow analysis. 2020-04-27 18:47:08 +00:00
smith [infra] Reduce duplication in configuring the sanitizer bots. 2020-04-08 20:26:33 +00:00
sourcemap_testing
status_file
telemetry [analyzer] initial implementation of SDK, file based configuration of the analysis server 2020-03-24 14:07:59 +00:00
test_runner Revert "[BUILD] - Initial CL to unfork the NNBD Dart SDK" 2020-04-27 05:00:10 +00:00
testing [testing] Fix path relativization on Windows 2020-04-20 08:21:46 +00:00
vm Reland "[VM] Remove unnecessary Closure.clone() from sync*." 2020-04-28 06:17:20 +00:00
vm_service [ Service / package:vm_service ] Document getClassList RPC, bump VM service version to 3.32, release package:vm_service 4.0.2 2020-04-23 22:05:52 +00:00
.gitignore
BUILD.gn [BUILD] - Format gn files, this is being done to ensure the unfork CL 2020-03-10 21:56:11 +00:00
pkg.status Skip pkg/nnbd_migration/tool tests on dart2js. 2020-04-24 18:37:08 +00:00