mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 00:13:50 +00:00
0a0dcce390
Eventually we may want to revisit whether it is worth running this test at all on the web backends. The test was designed to ensure the VM didn't produce memory leaks when capturing state in closures, as such, it may be better placed on a different suite. Today, the test passes in most web configurations. The two exceptions are: * ddc-linux-chrome is flaky and times out 50% of the time * ddc-linux-firefox consistently times out. Locally, on a machine much faster than our bots, the former completes in 5s and the latter in 25s. In the last 60 days, the chrome configuration has seen runs on the bots ranging from 8 to 60s (hitting the timeout). I expect marking the test as slow will fix the flakiness on chrome, but given that it is 5 times slower on FF, I fear it may not be enough to make the test pass in FF. Given that it doesn't provide much value to also have the coverage in FF, I'm inclined to skip it there instead. Change-Id: Ice25eb401b6af3c6ab8ba3f4b43bf3ce9ee38c83 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335020 Reviewed-by: Nicholas Shahan <nshahan@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com>
20 lines
1.2 KiB
Plaintext
20 lines
1.2 KiB
Plaintext
# Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
|
|
# for details. All rights reserved. Use of this source code is governed by a
|
|
# BSD-style license that can be found in the LICENSE file.
|
|
|
|
# Sections in this file should contain "$compiler == ddc".
|
|
|
|
[ $compiler == ddc ]
|
|
async_star/async_star_await_for_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/51086
|
|
async_star/throw_in_catch_test: Skip # Times out. Issue 29920
|
|
closure/cycles_test: Pass, Slow # Long test to pressure GC, periodically times out
|
|
external_abstract_fields/external_fields_test: SkipByDesign # Non-JS-interop external members are not supported
|
|
inference_update_2/external_field_test: SkipByDesign # Non-JS-interop external members are not supported
|
|
inference_update_2/why_not_promoted_external_error_test: SkipByDesign # Non-JS-interop external members are not supported
|
|
number/int64_literal_runtime*_test: Skip # This is testing Dart 2.0 int64 semantics.
|
|
superinterface_variance/*: Skip # Issue dart-lang/language#113
|
|
vm/*: SkipByDesign # VM only tests.; VM only tests.
|
|
|
|
[ $compiler == ddc && $runtime == ff ]
|
|
closure/cycles_test: SkipByDesign # Long test to pressure GC, consistently slow and times out on FF
|