mirror of
https://github.com/dart-lang/sdk
synced 2024-10-14 12:14:36 +00:00
9e3842d624
The method ObservatoryApplication._switchVM calls newVM.onDisconnect and requires the resulting future to be completed with a String. In normal operation, this is satisfied and we just need to change a few static types to enforce it. But when FakeVM was in use, the future was completed with `this`. Since ObservatoryApplication._switchVM is the only call site that cares what the future is completed with, it makes sense to just change all the types to Future<String> and modify FakeVM accordingly. Change-Id: Id94d27ac6a42f31ab19ccc9ad8dd270ecf4042b4 Reviewed-on: https://dart-review.googlesource.com/57400 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Paul Berry <paulberry@google.com> |
||
---|---|---|
.. | ||
bin | ||
include | ||
lib | ||
observatory | ||
platform | ||
tests/vm | ||
third_party | ||
tools | ||
vm | ||
.gitignore | ||
BUILD.gn | ||
codereview.settings | ||
configs.gni | ||
CPPLINT.cfg | ||
PRESUBMIT.py | ||
runtime_args.gni |