3911ef982d
It really looks like `_SubstitutedTypeParameters` factory constructor assumes its `substitution` argument doesn't include any of `elements` neither as a key, nor anywhere it the result types. Since if it does contains a key from `elements` that part of `substitution` will be lost, overriden by `...substitution2.map` part of `Substitution.fromMap` call. And if it has `elements` mentioned anywhere in values of the `substitution` map, those won't be renamed. But sometimes `_SubstitutedTypeParameters._SubstitutedTypeParameters` is called with a `subtitution` that includes some of `elements`. For example, that's what happens in both added tests. I assume it never breaks, because the part of `substitution` that acts on `elements` is trivial: just renaming a type variable to a fresh name. And since `_SubstitutedTypeParameters` just gets yet another fresh name for it, that works. One small problem arises though if a type variable renamed by `substitution` has a bound that references the type variable itself (like `T extends Foo<T>`). In that case bound gets substituted with the `substitution` first, so `substitution2` doesn't work on it anymore. So we end up with an element `T0 extends Foo<T1>`, where `T0` and `T1` and two different fresh names for `T`. This commit changes the order of substitutions when handling bounds, such that the part of `substitution` that substitutes `elements` is effectively ignored. That agrees with the existing behavior of rewriting this part of `substitution` in the result, so it shouldn't make things worse. Change-Id: I8f68c4342aad0c8f59f7c01a6cfac074946529ef Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/312401 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Ilya Yanok <yanok@google.com> |
||
|---|---|---|
| .dart_tool | ||
| .github | ||
| benchmarks | ||
| build | ||
| docs | ||
| pkg | ||
| runtime | ||
| samples | ||
| sdk | ||
| tests | ||
| third_party | ||
| tools | ||
| utils | ||
| .clang-format | ||
| .gitattributes | ||
| .gitconfig | ||
| .gitignore | ||
| .gn | ||
| .mailmap | ||
| .style.yapf | ||
| .vpython | ||
| AUTHORS | ||
| BUILD.gn | ||
| CHANGELOG.md | ||
| codereview.settings | ||
| CONTRIBUTING.md | ||
| DEPS | ||
| LICENSE | ||
| OWNERS | ||
| PATENT_GRANT | ||
| PRESUBMIT.py | ||
| README.dart-sdk | ||
| README.md | ||
| sdk.code-workspace | ||
| sdk_args.gni | ||
| SECURITY.md | ||
| WATCHLISTS | ||
Dart
A client-optimized language for fast apps on any platform
Dart is:
-
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
-
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
-
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
-
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
-
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
License & patents
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Using Dart
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
Building Dart
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
Contributing to Dart
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.