Ben Konyi 3849b5061c Revert "[ VM / DartDev ] Launch DartDev in an isolate within a single main Dart process" ... This reverts commit ffe258d2d4. Reason for revert: Failures on bots Original change's description: > [ VM / DartDev ] Launch DartDev in an isolate within a single main Dart process > > This CL changes how DartDev is run and how the run command handles executing a Dart program (will port additional commands in a separate CL). Rather than using DartDev to spawn a child process to run user code, the VM will instead launch a DartDev isolate after doing some VM options processing. DartDev will communicate information like exit codes and script/arg pairs with the VM via isolate ports. Once DartDev runs to completion and notifies the VM that a script should be run, the VM will move on to spawning another isolate with user code and continue executing in the same VM process. > > By moving DartDev into an isolate within the same process that user code will eventually run in we're able to resolve the following issues that arose due to signal handling and IPC issues: > > VM hangs when --enable-vm-service is supplied and there are compile time errors (https://github.com/dart-lang/sdk/issues/42630) > Dart daemon spinning in exit code handler / zombie Dart processes (https://github.com/dart-lang/sdk/issues/41978) > Signal handling in children of 'dartdev run' is problematic (https://github.com/dart-lang/sdk/issues/41978) > > Change-Id: I1c6b1425831b691ad20284716aa80f817dbaf607 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152588 > Commit-Queue: Ben Konyi <bkonyi@google.com> > Reviewed-by: Siva Annamalai <asiva@google.com> > Reviewed-by: Ryan Macnak <rmacnak@google.com> TBR=bkonyi@google.com,rmacnak@google.com,asiva@google.com Change-Id: Idb1d24a4524bdc3ccfb199a82710f3c0d9db539a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154702 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>		2020-07-16 19:50:57 +00:00
..
bin	[Core Libraries] Eliminate the fork in the core libraries.	2020-06-16 23:37:36 +00:00
lib	Revert "[ VM / DartDev ] Launch DartDev in an isolate within a single main Dart process"	2020-07-16 19:50:57 +00:00
api_readme.md	Update the API docs readme	2020-01-16 21:23:09 +00:00
BUILD.gn	Revert "[ VM / DartDev ] Launch DartDev in an isolate within a single main Dart process"	2020-07-16 19:50:57 +00:00