mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 00:13:50 +00:00
35223586a3
When constructing the command line for creating the kernel service snapshot, the variable `abs_output` actually contains a relative path, which means that copy/pasting the generated command line fails if not within the root build directory. This CL fixes that. Previous revert: https://dart-review.googlesource.com/c/sdk/+/200940 Passes `--depfile-output-filename` with the path relative to the output folder so that the written depfiles do not contain the absolute file paths. ninja only accepts paths relative to the build folder in the .d files. Manually tested that the dependencies now work with running the build twice: `tools/build.py --no-start-goma -mrelease create_platform_sdk` Inspecting the .d file in question that caused the revert: `cat out/ReleaseX64/gen/kernel-service.dart.snapshot.d` TEST=SDK build Change-Id: Id781d2ed94ad7a0041e5899b8fded598de81242b Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try,dart-sdk-mac-try,dart-sdk-win-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200876 Reviewed-by: Tess Strickland <sstrickl@google.com> Commit-Queue: Daco Harkes <dacoharkes@google.com> |
||
|---|---|---|
| .. | ||
| analysis_server | ||
| bazel | ||
| compiler | ||
| dart2native | ||
| dartanalyzer | ||
| dartdev | ||
| dartdevc | ||
| dartdoc | ||
| dartfmt | ||
| dds | ||
| gen_kernel | ||
| kernel-service | ||
| peg | ||
| pub | ||
| tests/peg | ||
| application_snapshot.gni | ||
| compile_platform.gni | ||
| create_timestamp.gni | ||