mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 00:13:50 +00:00
![Ryan Macnak](/assets/img/avatar_default.png)
Currently we have things called XPtr which are not what you get from ptr().
Old world:
handle->raw() returns RawObject* (tagged)
raw_obj->ptr() returns RawObject* (untagged)
After 6fe15f6df9
:
handle->raw() returns ObjectPtr
obj_ptr->ptr() returns ObjectLayout*
New world:
handle->ptr() returns ObjectPtr
obj_ptr->untag() returns UntaggedObject*
TEST=ci
Change-Id: I6c7f34014cf20737607caaf84979838300d12df2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149367
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
39 lines
1.3 KiB
C++
39 lines
1.3 KiB
C++
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/globals.h"
|
|
#if defined(TARGET_ARCH_ARM)
|
|
|
|
#include "vm/compiler/assembler/assembler.h"
|
|
#include "vm/cpu.h"
|
|
#include "vm/instructions.h"
|
|
#include "vm/stub_code.h"
|
|
#include "vm/unit_test.h"
|
|
|
|
namespace dart {
|
|
|
|
#define __ assembler->
|
|
|
|
ASSEMBLER_TEST_GENERATE(Call, assembler) {
|
|
// Code is generated, but not executed. Just parsed with CallPattern.
|
|
__ set_constant_pool_allowed(true); // Uninitialized pp is OK.
|
|
SPILLS_LR_TO_FRAME({}); // Clobbered LR is OK.
|
|
__ BranchLinkPatchable(StubCode::InvokeDartCode());
|
|
RESTORES_LR_FROM_FRAME({}); // Clobbered LR is OK.
|
|
__ Ret();
|
|
}
|
|
|
|
ASSEMBLER_TEST_RUN(Call, test) {
|
|
// The return address, which must be the address of an instruction contained
|
|
// in the code, points to the Ret instruction above, i.e. one instruction
|
|
// before the end of the code buffer.
|
|
uword end = test->payload_start() + test->code().Size();
|
|
CallPattern call(end - Instr::kInstrSize, test->code());
|
|
EXPECT_EQ(StubCode::InvokeDartCode().ptr(), call.TargetCode());
|
|
}
|
|
|
|
} // namespace dart
|
|
|
|
#endif // defined TARGET_ARCH_ARM
|