languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/pkg
History
Srujan Gaddam 2767fca6fe Revert "[dart:js_interop] Remove Object.toJS and JSNumber.toDart" 
This reverts commit 16fcfe7eae.

Reason for revert: Flutter changes haven't landed to google3 yet.

Original change's description:
> [dart:js_interop] Remove Object.toJS and JSNumber.toDart
>
> Modifies JSBoxedDartObject reified type on JS backends and also
> modifies JSBoxedDartObject.toDart now that a proper box is introduced.
> Also uses a JS symbol in JSBoxedDartObject.toDart for a property
> check so that different Dart apps don't accidentally share Dart
> objects. It's now an error to call this function on non-boxed objects.
>
> Fixes a type issue where creating a new object literal with the JS
> foreign function was resulting in dart2js thinking toJSBox would
> always throw. Changing the typeDescription to PlainJavaScriptObject
> instead of =Object fixes that issue.
>
> CoreLibraryReviewExempt: Backend-specific library.
> Change-Id: I5cfb1f32ff4328fafdf9831b0d8da806c39391d9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/309082
> Reviewed-by: Joshua Litt <joshualitt@google.com>
> Commit-Queue: Srujan Gaddam <srujzs@google.com>

Change-Id: I469ad04db7b49ffef47a46ccac97e909e4865719
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313580
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2023-07-13 21:06:05 +00:00
..
_fe_analyzer_shared Flow analysis: remove redundant assertion from constructor. 2023-07-11 21:03:29 +00:00
_js_interop_checks Revert "[dart:js_interop] Remove Object.toJS and JSNumber.toDart" 2023-07-13 21:06:05 +00:00
analysis_server [analysis_server] Remove unused parameters and related TODOs 2023-07-13 15:57:47 +00:00
analysis_server_client
analyzer Issue 52918. Report -TYPE_PARAMETER_REFERENCED_BY_STATIC for extension. 2023-07-13 17:53:38 +00:00
analyzer_cli [analyzer_cli] [dartdev] Fix several tests on Windows 2023-06-04 19:26:11 +00:00
analyzer_plugin Deprecate ExecutableElement.returnType, use returnType2 instead. 2023-06-29 23:16:59 +00:00
analyzer_utilities [analysis_server] Fix generation tests on Windows 2023-06-04 19:18:51 +00:00
async_helper
bisect_dart [tool] Bisection tool 2023-07-13 13:22:26 +00:00
build_integration
compiler [dart2js] Revert invalid refinement change. 2023-07-12 15:56:09 +00:00
dap [dap] Regenerate DAP classes based on latest published version of spec 2023-06-20 17:29:24 +00:00
dart2js_info
dart2js_runtime_metrics
dart2js_tools
dart2native [vm/ffi] dartdev CLI native-assets 2023-05-30 09:10:28 +00:00
dart2wasm [dart2wasm|js] Add support for JS backed subtypes of 64 bit typed data. 2023-07-13 15:29:37 +00:00
dart_internal Update package:dart_internal to work with SDK 3.2.0. 2023-06-21 01:14:38 +00:00
dartdev [gardening][pkg] Fix test expects 2023-07-12 16:04:38 +00:00
dds [dds/dap] Support translating VM Instance IDs -> DAP variablesReferences and back for DAP-over-DDS 2023-07-12 15:04:20 +00:00
dds_service_extensions Revert "Revert "Send DAP events through DDS"" - only check for event handler when DDS URI is also set. 2023-06-22 21:43:22 +00:00
dev_compiler [ddc] Fix default type args signature on native classes 2023-07-06 23:34:20 +00:00
expect [vm] Add @pragma('vm:keep-name') annotation 2023-06-16 10:22:23 +00:00
front_end [cfe] Ensure default value on super parameter tear-off 2023-07-13 08:05:50 +00:00
frontend_server [frontend_server] Add --canary flag 2023-06-27 22:21:04 +00:00
js [pkg:js] Update min sdk version to 3.1.0-66.0.dev 2023-05-04 15:56:41 +00:00
js_ast [dart2js] Better const Maps and Sets 2023-06-20 23:44:08 +00:00
js_runtime [dart2js] Improve deferred part file logging. 2023-06-09 17:05:11 +00:00
js_shared
kernel [cfe] Handle inline class representation field in object pattern 2023-07-10 11:02:50 +00:00
language_versioning_2_7_test
meta
mmap [pkg] Support mmap with all the Linux architectures. 2023-05-11 17:15:26 +00:00
modular_test
native_stack_traces [vm] Rework awaiter stack unwinding. 2023-06-30 14:03:03 +00:00
nnbd_migration Add InterfaceElementImpl, move many methods into it. 2023-07-04 01:41:38 +00:00
scrape Deprecate IfElement/IfStatement.condition, use 'expression'. 2023-04-19 17:17:28 +00:00
smith [infra] Change default NNBD to strong. 2023-05-24 20:48:36 +00:00
sourcemap_testing
status_file [infra] Make the sanitizer a first-class status variable. 2023-07-10 17:46:31 +00:00
telemetry Implement broad-spectrum filtering for possible path and filenames in exception strings. 2023-05-16 15:25:37 +00:00
test_runner [test_runner] Don't assign all vm/cc tests to the first shard. 2023-07-12 17:56:59 +00:00
testing [cfe] Remove unnecessary_null_comparison code 2023-06-08 08:46:47 +00:00
vm Make utf8.encode() have Uint8List return type 2023-07-11 08:54:33 +00:00
vm_service [VM/Debugger] Fix behaviour of ActivationFrame::EvaluateCompiledExpression when paused inside a closure 2023-07-11 18:41:04 +00:00
vm_service_protos [VM/Service] Create package:vm_service_protos for distributing code for working with Perfetto protos 2023-06-15 19:01:00 +00:00
vm_snapshot_analysis [pkg/vm_snapshot_analysis] Allow old 'patched_class_' field. 2023-07-07 11:36:59 +00:00
wasm_builder [dart2wasm] Close parens in compile-time error messages 2023-04-05 16:36:27 +00:00
.gitignore
analysis_options.yaml
BUILD.gn
OWNERS
pkg.dart
pkg.status [deps/ffi] Unbundle package:native_assets_builder 2023-06-28 09:09:09 +00:00
README.md

README.md

Package validation

The packages in pkg/ are automatically validated on the LUCI CI bots. The validation is largely done by the tools/package_deps package; it can be tested locally via:

dart tools/package_deps/bin/package_deps.dart

Packages which are published

There are several packages developed in pkg/ which are published to pub. Validation of these packages is particularly important because the pub tools are not used for these packages during development; we get our dependency versions from the DEPS file. Its very easy for the dependencies specified in a package's pubspec file to get out of date wrt the packages and versions actually used.

In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that we don't use relative path deps to pkg/ or third_party/ packages

Packages which are not published

For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:

# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none

These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.

We validate:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that a reference to a pkg/ package is done via a relative path dependency