languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 05:16:40 +00:00
Code Issues Packages Projects Releases Wiki Activity
dart-sdk/pkg
History
Johnni Winther deaf9ce16e Revert "[cfe] Support external constructor with final fields" 
This reverts commit c70d266270.

Reason for revert: Crash detected

Original change's description:
> [cfe] Support external constructor with final fields
>
> This adds support for having a final field and an external constructor
> without error, assuming that the external constructor initializes the
> final field. This supports the inline class with external members use
> case.
>
> Change-Id: Ie297ccc39b0a0731c146f9ac0698bba3fd83bfeb
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278502
> Reviewed-by: Srujan Gaddam <srujzs@google.com>
> Commit-Queue: Johnni Winther <johnniwinther@google.com>
> Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I339d9008cb84cda8dc20f29d1e103289bb5596b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278820
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Auto-Submit: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2023-01-10 17:20:01 +00:00
..
_fe_analyzer_shared Flow analysis: remove logic to handle implicitly declared variables. 2023-01-10 13:24:01 +00:00
_js_interop_checks Spelling samples 2023-01-09 17:44:29 +00:00
analysis_server Generate a diagnostic for language overrides prior to 2.12 2023-01-10 05:27:48 +00:00
analysis_server_client Remove all support for super-mixins option 2022-12-13 18:13:37 +00:00
analyzer Flow analysis: add assertions to verify that declare isn't called unnecessarily. 2023-01-10 13:15:58 +00:00
analyzer_cli Generate a diagnostic for language overrides prior to 2.12 2023-01-10 05:27:48 +00:00
analyzer_plugin Support copying the file header in the move to file refactoring 2023-01-09 17:31:00 +00:00
analyzer_utilities Remove some unnecessary ignore comments in analyzer packages 2022-12-09 21:33:18 +00:00
async_helper
build_integration
compiler Revert "[cfe] Support external constructor with final fields" 2023-01-10 17:20:01 +00:00
dart2js_info [dart2js:dump_info] put version and program info first... 2022-11-23 23:30:32 +00:00
dart2js_runtime_metrics Stop using strong-mode options in dart2js_runtime_metrics and scrape 2022-12-13 18:27:22 +00:00
dart2js_tools
dart2native [pkg/dart2native] Add checks to avoid MachO-related regressions. 2022-12-14 20:16:57 +00:00
dart2wasm [dart2wasm] Fix invocation forwarder named argument adjustment 2023-01-10 13:37:33 +00:00
dart_internal
dartdev Generate a diagnostic for language overrides prior to 2.12 2023-01-10 05:27:48 +00:00
dds [ package:dds ] Add support for registering external DevTools servers with DDS 2023-01-10 16:03:41 +00:00
dds_service_extensions [3.0 alpha][VM/Service] Update VM Service spec to v4.0 2023-01-03 16:16:18 +00:00
dev_compiler [3.0 alpha][ddc] Remove unused command line args 2023-01-03 20:14:12 +00:00
expect Reland "[test] Fix some tests for Dart2Wasm." 2022-11-04 16:10:39 +00:00
front_end Revert "[cfe] Support external constructor with final fields" 2023-01-10 17:20:01 +00:00
frontend_server Remove some unnecessary ignore comments in frontend_server 2022-12-12 18:40:40 +00:00
js [pkg:js] Prep 0.6.6 release 2022-12-16 20:14:23 +00:00
js_ast [dart2js] Migrate ssa/codegen.dart 2022-11-16 21:32:00 +00:00
js_runtime [dart2js] loadLibrary priority annotation 2022-11-18 19:22:29 +00:00
js_shared
kernel Revert "[cfe] Support external constructor with final fields" 2023-01-10 17:20:01 +00:00
language_versioning_2_7_test Generate a diagnostic for language overrides prior to 2.12 2023-01-10 05:27:48 +00:00
meta Revert "[analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter" 2022-11-07 20:17:09 +00:00
modular_test
native_stack_traces Reland "[native_stack_traces] Remove initial spaces check in stack trace lines." 2022-12-22 11:52:18 +00:00
nnbd_migration Flow analysis: add assertions to verify that declare isn't called unnecessarily. 2023-01-10 13:15:58 +00:00
scrape Stop using strong-mode options in dart2js_runtime_metrics and scrape 2022-12-13 18:27:22 +00:00
smith Change the default architecture in test.py from x64 to host. 2022-12-15 20:41:33 +00:00
sourcemap_testing
status_file
telemetry
test_runner [dart2wasm] Generate js runtime at compile time. 2023-01-10 13:16:29 +00:00
testing
vm Spelling samples 2023-01-09 17:44:29 +00:00
vm_service [3.0 alpha][VM/Service] Update VM Service spec to v4.0 2023-01-03 16:16:18 +00:00
vm_snapshot_analysis [gardening] Fix instruction_sizes_test on Windows 2022-11-03 01:50:48 +00:00
wasm_builder [dart2wasm] Put function types of imports in singleton rec groups 2022-12-13 20:43:22 +00:00
.gitignore
BUILD.gn
OWNERS
pkg.status [pkg/dartdev] add windows support for 'dart bug' 2022-11-30 20:13:05 +00:00
README.md

README.md

Package validation

The packages in pkg/ are automatically validated on the LUCI CI bots. The validation is largely done by the tools/package_deps package; it can be tested locally via:

dart tools/package_deps/bin/package_deps.dart

Packages which are published

There are several packages developed in pkg/ which are published to pub. Validation of these packages is particularly important because the pub tools are not used for these packages during development; we get our dependency versions from the DEPS file. Its very easy for the dependencies specified in a package's pubspec file to get out of date wrt the packages and versions actually used.

In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that we don't use relative path deps to pkg/ or third_party/ packages

Packages which are not published

For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:

# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none

These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.

We validate:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that a reference to a pkg/ package is done via a relative path dependency