mirror of
https://github.com/dart-lang/sdk
synced 2024-10-14 11:03:19 +00:00
06a8cc8dea
Previously, NullError runtime entry was used both to throw NoSuchMethodError and _CastError. _CastError was used if selector is null. However, with --dwarf-stack-traces CodeSourceMap is not preserved and selector is not available, so wrong exception type was thrown. This is fixed by introducing separate NullCastError runtime entry along with corresponding shared stubs. NullErrorSlowPath is extended to support 3 exception types (NoSuchMethodError, ArgumentError and CastError). NullArgErrorSlowPath is removed as it duplicates NullErrorSlowPath. Fixes vm/dart/null_checks_with_dwarf_stack_traces_test Fixes https://github.com/dart-lang/sdk/issues/42149 Change-Id: I4f2b34ad2b161459491de60d8737bb4f87117336 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153040 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com> |
||
|---|---|---|
| .. | ||
| bin | ||
| docs | ||
| include | ||
| lib | ||
| llvm_codegen | ||
| observatory | ||
| platform | ||
| tests/vm | ||
| third_party | ||
| tools | ||
| vm | ||
| .clang-tidy | ||
| .gitignore | ||
| BUILD.gn | ||
| codereview.settings | ||
| configs.gni | ||
| CPPLINT.cfg | ||
| PRESUBMIT.py | ||
| runtime_args.gni | ||