dart-sdk/pkg
Paul Berry 1859824f74 Shared patterns analysis: Separate handling of logical and/or.
As I'm beginning to work on flow analysis for logical and/or patterns
I'm realizing that the shared analysis methods for handling
logical-and and logical-or patterns are going to need to have
different parameters, so it makes sense to separate them.

This makes the code clearer anyhow, since they weren't sharing any
functionality.

Bug: https://github.com/dart-lang/sdk/issues/50419
Change-Id: I17b0ad53f916f48ee02ccb1c9c23488261a6a1b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274920
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2022-12-12 19:55:56 +00:00
..
_fe_analyzer_shared Shared patterns analysis: Separate handling of logical and/or. 2022-12-12 19:55:56 +00:00
_js_interop_checks Add bindings emitter for web libraries 2022-12-09 19:23:31 +00:00
analysis_server Do not apply the fix for avoid_function_literals_in_foreach_calls when body is not sync 2022-12-12 18:12:57 +00:00
analysis_server_client Remove some unnecessary ignore comments in analyzer packages 2022-12-09 21:33:18 +00:00
analyzer Shared patterns analysis: Separate handling of logical and/or. 2022-12-12 19:55:56 +00:00
analyzer_cli [3.0 alpha] Remove deprecated dart:core apis 2022-12-12 11:46:58 +00:00
analyzer_plugin Remove some unnecessary ignore comments in analyzer packages 2022-12-09 21:33:18 +00:00
analyzer_utilities Remove some unnecessary ignore comments in analyzer packages 2022-12-09 21:33:18 +00:00
async_helper
build_integration
compiler [dart2js] fix minified_names_test. 2022-12-10 01:24:54 +00:00
dart2js_info [dart2js:dump_info] put version and program info first... 2022-11-23 23:30:32 +00:00
dart2js_runtime_metrics
dart2js_tools
dart2native [3.0 alpha][VM/Runtime] - Flip flag to make strong null safety the default. 2022-12-06 04:04:23 +00:00
dart2wasm Remove some unnecessary ignore comments in dart2wasm 2022-12-12 18:38:12 +00:00
dart_internal
dartdev [VM/CLI] Remove dartdev.dill 2022-12-12 18:02:47 +00:00
dds Revert "[ VM Service / DDS ] Add custom service stream support" 2022-12-12 11:24:37 +00:00
dds_service_extensions
dev_compiler [ddc] Fix unsound await expressions 2022-12-12 19:43:55 +00:00
expect Reland "[test] Fix some tests for Dart2Wasm." 2022-11-04 16:10:39 +00:00
front_end Flow analysis: update exhaustiveness logic for patterns. 2022-12-12 19:15:53 +00:00
frontend_server Remove some unnecessary ignore comments in frontend_server 2022-12-12 18:40:40 +00:00
js
js_ast [dart2js] Migrate ssa/codegen.dart 2022-11-16 21:32:00 +00:00
js_runtime [dart2js] loadLibrary priority annotation 2022-11-18 19:22:29 +00:00
js_shared [ddc] Add basic support for new interface types 2022-10-28 19:26:50 +00:00
kernel Remove some unnecessary ignore comments in kernel 2022-12-12 18:46:15 +00:00
language_versioning_2_7_test
meta Revert "[analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter" 2022-11-07 20:17:09 +00:00
modular_test
native_stack_traces
nnbd_migration Flow analysis: account for implicit break at the end of switch statement cases. 2022-12-09 17:20:38 +00:00
scrape Remove an unnecessary override 2022-10-31 20:30:47 +00:00
smith
sourcemap_testing
status_file
telemetry
test_runner Remove some unnecessary ignore comments in test_runner 2022-12-12 18:21:00 +00:00
testing
vm [3.0 alpha][VM/Runtime] - Flip flag to make strong null safety the default. 2022-12-06 04:04:23 +00:00
vm_service [3.0 alpha] Bump version to 3.0.0 2022-12-06 02:40:36 +00:00
vm_snapshot_analysis [gardening] Fix instruction_sizes_test on Windows 2022-11-03 01:50:48 +00:00
wasm_builder [dart2wasm] Add Wasm bottom heap types 2022-11-18 11:43:52 +00:00
.gitignore
BUILD.gn
OWNERS
pkg.status [pkg/dartdev] add windows support for 'dart bug' 2022-11-30 20:13:05 +00:00
README.md

Package validation

The packages in pkg/ are automatically validated on the LUCI CI bots. The validation is largely done by the tools/package_deps package; it can be tested locally via:

dart tools/package_deps/bin/package_deps.dart

Packages which are published

There are several packages developed in pkg/ which are published to pub. Validation of these packages is particularly important because the pub tools are not used for these packages during development; we get our dependency versions from the DEPS file. Its very easy for the dependencies specified in a package's pubspec file to get out of date wrt the packages and versions actually used.

In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that we don't use relative path deps to pkg/ or third_party/ packages

Packages which are not published

For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:

# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none

These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.

We validate:

  • that the dependencies listed in the pubspec are used in the package
  • that all the packages used by the source are listed in the pubspec
  • that a reference to a pkg/ package is done via a relative path dependency