mirror of
https://github.com/dart-lang/sdk
synced 2024-10-14 12:48:10 +00:00
164f8588d6
Avoid quadratic behavior when multiple chunks fail to have a line break, and the carry-over string gets repeatedly extended. In the original chunked conversion code, the chunk handling code retained the trailing, non-line-terminated text of the previous chunk, then eagerly concatenated it with the next chunk in order to continue looking for lines. That's moderately effective when lines are shorter than chunks, and neither are too large. However, a very long line spread across many chunks would perform repeated string concatenation with quadratic time complexity. This change gives `LineSplitter` the option of using a `StringBuffer` to collect multiple carry-over line parts. The buffer is needed whenever a chunk does not contain a line break, and needs to be combined with a previous chunk's carry-over. This avoids ever directly concatenating any more than two strings. The `StringBuffer` is not allocated until it's first needed, so if lines are generally shorter than chunks, the buffer won't be used. Once allocated, the buffer is retained in case a buffer will be needed again, but cleared when its contents are used. The code optimizes for the simple case of each chunk having a line break. Fixes #51167 Bug: https://github.com/dart-lang/sdk/issues/51167 Change-Id: I600a011e02aa9f1ad6f88e45764df5b2e8eccfa3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280100 Reviewed-by: Leaf Petersen <leafp@google.com> Reviewed-by: Stephen Adams <sra@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Reviewed-by: Aske Simon Christensen <askesc@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com> |
||
|---|---|---|
| .. | ||
| co19 | ||
| co19_2 | ||
| corelib | ||
| corelib_2 | ||
| dartdevc | ||
| dartdevc_2 | ||
| ffi | ||
| ffi_2 | ||
| language | ||
| language_2 | ||
| lib | ||
| lib_2 | ||
| modular | ||
| standalone | ||
| standalone_2 | ||
| web | ||
| web_2 | ||
| legacy_status_dart2js.csv | ||
| OWNERS | ||
| README.md | ||
This directory contains tests of the language and core library implementations. For more information, see https://github.com/dart-lang/sdk/wiki/Testing.