mirror of
https://github.com/dart-lang/sdk
synced 2024-10-06 15:50:01 +00:00
da4bf60a09
- Imported things (modules, globals, tables, functions) don't need to declared before defining things, as we don't assign indices to things before finalizing the IR, and when finalizing we assign ids to imported things before defined things, in `finalizeImportsAndBuilders`. Remove documentation saying imports should be declared before definitions. `FunctionsBuilder._functions` list was used in the name section, and required imports to come before definitions. This list is now removed, instead we pass `[...imported, ...defined]` to the names section. - Stop upcasting imported things to `Import` before we need to upcast. - Fix global lists passed to `NameSection`. These lists need to include imports as well (even though we never name them, wasm_builder doesn't allow naming them yet) otherwise the indices in the name section will be incorrect. wasm_builder doesn't allow importing types yet, so we don't need to do the same for the types list. Change-Id: Id05632c3af7937bd66d7581d89d538137020f6e6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366601 Commit-Queue: Ömer Ağacan <omersa@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> |
||
---|---|---|
.. | ||
lib | ||
analysis_options.yaml | ||
OWNERS | ||
pubspec.yaml |