dart-sdk/pkg/dev_compiler/tool
Nicholas Shahan ee9dba1217 [ddc/dart2js] Add failure case when setting list length
NNBD spec states expanding the length of a list of non-nullable
elements should produce a runtime error.
https://github.com/dart-lang/language/blob/master/accepted/future-releases/nnbd/feature-specification.md#core-library-changes

Add private method `_setLengthUnsafe()` as a replacement for the
existing length setter to call internally when it is known to
be safe that skips the checks.

This breaks the corelib/list_test but it needs to be rewritten
pending a decision regarding the `ListMixin` implementation.
See: https://github.com/dart-lang/sdk/issues/42496

Issue: https://github.com/dart-lang/sdk/issues/39777
Change-Id: I081451227b332b68bb75bf08f3268e360bae090c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152423
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2020-06-29 18:39:43 +00:00
..
check_nnbd_sdk.dart [Core Libraries] Eliminate the fork in the core libraries. 2020-06-16 23:37:36 +00:00
compile_dartdevc_sdk.dart [dartdevc] Apply always_declare_return_types lint and cleanup violations 2020-01-29 07:17:22 +00:00
dart2js_nnbd_sdk_error_golden.txt [ddc/dart2js] Add failure case when setting list length 2020-06-29 18:39:43 +00:00
dartdevc_nnbd_sdk_error_golden.txt Update Duration.toString() description 2020-06-29 18:23:13 +00:00
ddb [ddc] Update ddb script to use SDK js from gen dir 2020-06-04 21:10:39 +00:00
ddc (ddc) Fix deps tracking for the ddc sdk. 2019-11-23 00:21:58 +00:00
kernel_sdk.dart [dartdevc] record metrics 2020-03-23 15:38:37 +00:00
patch_sdk.dart Use AllowedExperiments in analyzer. 2020-05-20 20:42:31 +00:00
vm_nnbd_sdk_error_golden.txt [VM/libraries] Fix final set of warnings in dart:core and dart:typed_data 2020-01-27 19:51:14 +00:00