mirror of
https://github.com/dart-lang/sdk
synced 2024-09-16 00:19:48 +00:00
9920801424
Closes: https://github.com/dart-lang/sdk/issues/40233 This CL creates nnbd versions of the tests and runs them on the nnbd sdk. This CL does not (1) migrate sdk_nnbd/lib/ffi fully yet, and does not (2) fix all the tests/ffi (which is NNBD tests) yet. Uncovered new issues: Issue: https://github.com/dart-lang/sdk/issues/40234 nullptr should have type Pointer<Never>. Issue: https://github.com/dart-lang/sdk/issues/40247 Structs need external fields. Issue: https://github.com/dart-lang/sdk/issues/40271 Callbacks hit assert in debug. Change-Id: Icb1b83577e03ed283165eb17703fc8dfc7fa5960 Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,dart-sdk-linux-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try,front-end-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try,analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132604 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Bob Nystrom <rnystrom@google.com>
213 lines
6.3 KiB
Dart
213 lines
6.3 KiB
Dart
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
//
|
|
// Dart test programing for testing that optimizations do wrongly assume loads
|
|
// from and stores to C memory are not aliased.
|
|
//
|
|
// SharedObjects=ffi_test_functions
|
|
// VMOptions=--deterministic --optimization-counter-threshold=50
|
|
|
|
import 'dart:ffi';
|
|
|
|
import "package:ffi/ffi.dart";
|
|
import "package:expect/expect.dart";
|
|
|
|
import 'ffi_test_helpers.dart';
|
|
|
|
void main() {
|
|
for (int i = 0; i < 100; ++i) {
|
|
testNonAlias();
|
|
testAliasCast();
|
|
testAliasCast2();
|
|
testAliasOffsetBy();
|
|
testAliasOffsetBy2();
|
|
testAliasElementAt();
|
|
testAliasElementAt2();
|
|
testAliasFromAddress();
|
|
testAliasFromAddress2();
|
|
testAliasFromAddressViaMemory();
|
|
testAliasFromAddressViaMemory2();
|
|
testAliasFromAddressViaNativeFunction();
|
|
testAliasFromAddressViaNativeFunction2();
|
|
testPartialOverlap();
|
|
}
|
|
}
|
|
|
|
void testNonAlias() {
|
|
final source = allocate<Int64>();
|
|
source.value = 42;
|
|
final int a = source.value;
|
|
source.value = 1984;
|
|
// alias.value should be re-executed, as we wrote to alias.
|
|
Expect.notEquals(a, source.value);
|
|
free(source);
|
|
}
|
|
|
|
void testAliasCast() {
|
|
final source = allocate<Int64>();
|
|
final alias = source.cast<Int8>().cast<Int64>();
|
|
source.value = 42;
|
|
final int a = source.value;
|
|
alias.value = 1984;
|
|
// source.value should be re-executed, we wrote alias which aliases source.
|
|
Expect.notEquals(a, source.value);
|
|
free(source);
|
|
}
|
|
|
|
void testAliasCast2() {
|
|
final source = allocate<Int64>();
|
|
final alias = source.cast<Int16>().cast<Int64>();
|
|
final alias2 = source.cast<Int8>().cast<Int64>();
|
|
alias.value = 42;
|
|
final int a = alias.value;
|
|
alias2.value = 1984;
|
|
// alias.value should be re-executed, we wrote alias2 which aliases alias.
|
|
Expect.notEquals(a, alias.value);
|
|
free(source);
|
|
}
|
|
|
|
void testAliasOffsetBy() {
|
|
final source = allocate<Int64>(count: 2);
|
|
final alias = source.offsetBy(8).offsetBy(-8);
|
|
source.value = 42;
|
|
final int a = source.value;
|
|
alias.value = 1984;
|
|
// source.value should be re-executed, we wrote alias which aliases source.
|
|
Expect.notEquals(a, source.value);
|
|
free(source);
|
|
}
|
|
|
|
void testAliasOffsetBy2() {
|
|
final source = allocate<Int64>(count: 3);
|
|
final alias = source.offsetBy(16).offsetBy(-16);
|
|
final alias2 = source.offsetBy(8).offsetBy(-8);
|
|
alias.value = 42;
|
|
final int a = alias.value;
|
|
alias2.value = 1984;
|
|
// alias.value should be re-executed, we wrote alias2 which aliases alias.
|
|
Expect.notEquals(a, alias.value);
|
|
free(source);
|
|
}
|
|
|
|
void testAliasElementAt() {
|
|
final source = allocate<Int64>(count: 2);
|
|
final alias = source.elementAt(1).elementAt(-1);
|
|
source.value = 42;
|
|
final int a = source.value;
|
|
alias.value = 1984;
|
|
// source.value should be re-executed, we wrote alias which aliases source.
|
|
Expect.notEquals(a, source.value);
|
|
free(source);
|
|
}
|
|
|
|
void testAliasElementAt2() {
|
|
final source = allocate<Int64>(count: 3);
|
|
final alias = source.elementAt(2).elementAt(-2);
|
|
final alias2 = source.elementAt(1).elementAt(-1);
|
|
alias.value = 42;
|
|
final int a = alias.value;
|
|
alias2.value = 1984;
|
|
// alias.value should be re-executed, we wrote alias2 which aliases alias.
|
|
Expect.notEquals(a, alias.value);
|
|
free(source);
|
|
}
|
|
|
|
void testAliasFromAddress() {
|
|
final source = allocate<Int64>();
|
|
final alias = Pointer<Int64>.fromAddress(source.address);
|
|
source.value = 42;
|
|
final int a = source.value;
|
|
alias.value = 1984;
|
|
// source.value should be re-executed, we wrote alias which aliases source.
|
|
Expect.notEquals(a, source.value);
|
|
free(source);
|
|
}
|
|
|
|
void testAliasFromAddress2() {
|
|
final source = allocate<Int64>();
|
|
final alias = Pointer<Int64>.fromAddress(source.address);
|
|
final alias2 = Pointer<Int64>.fromAddress(source.address);
|
|
alias.value = 42;
|
|
final int a = alias.value;
|
|
alias2.value = 1984;
|
|
// alias.value should be re-executed, we wrote alias2 which aliases alias.
|
|
Expect.notEquals(a, alias.value);
|
|
free(source);
|
|
}
|
|
|
|
void testAliasFromAddressViaMemory() {
|
|
final helper = allocate<IntPtr>();
|
|
final source = allocate<Int64>();
|
|
helper.value = source.address;
|
|
final alias = Pointer<Int64>.fromAddress(helper.value);
|
|
source.value = 42;
|
|
final int a = source.value;
|
|
alias.value = 1984;
|
|
// source.value should be re-executed, we wrote alias which aliases source.
|
|
Expect.notEquals(a, source.value);
|
|
free(helper);
|
|
free(source);
|
|
}
|
|
|
|
void testAliasFromAddressViaMemory2() {
|
|
final helper = allocate<IntPtr>();
|
|
final source = allocate<Int64>();
|
|
helper.value = source.address;
|
|
final alias = Pointer<Int64>.fromAddress(helper.value);
|
|
final alias2 = Pointer<Int64>.fromAddress(helper.value);
|
|
alias.value = 42;
|
|
final int a = alias.value;
|
|
alias2.value = 1984;
|
|
// alias.value should be re-executed, we wrote alias2 which aliases alias.
|
|
Expect.notEquals(a, alias.value);
|
|
free(helper);
|
|
free(source);
|
|
}
|
|
|
|
typedef NativeQuadOpSigned = Int64 Function(Int8, Int16, Int32, Int64);
|
|
typedef QuadOp = int Function(int, int, int, int);
|
|
|
|
QuadOp intComputation = ffiTestFunctions
|
|
.lookupFunction<NativeQuadOpSigned, QuadOp>("IntComputation");
|
|
|
|
void testAliasFromAddressViaNativeFunction() {
|
|
final source = allocate<Int64>();
|
|
final alias =
|
|
Pointer<Int64>.fromAddress(intComputation(0, 0, 0, source.address));
|
|
source.value = 42;
|
|
final int a = source.value;
|
|
alias.value = 1984;
|
|
// source.value should be re-executed, we wrote alias which aliases source.
|
|
Expect.notEquals(a, source.value);
|
|
free(source);
|
|
}
|
|
|
|
void testAliasFromAddressViaNativeFunction2() {
|
|
final source = allocate<Int64>();
|
|
final alias =
|
|
Pointer<Int64>.fromAddress(intComputation(0, 0, 0, source.address));
|
|
final alias2 =
|
|
Pointer<Int64>.fromAddress(intComputation(0, 0, 0, source.address));
|
|
alias.value = 42;
|
|
final int a = alias.value;
|
|
alias2.value = 1984;
|
|
// alias.value should be re-executed, we wrote alias2 which aliases alias.
|
|
Expect.notEquals(a, alias.value);
|
|
free(source);
|
|
}
|
|
|
|
@pragma('vm:never-inline')
|
|
Pointer<Int8> makeDerived(Pointer<Int64> source) =>
|
|
source.offsetBy(7).cast<Int8>();
|
|
|
|
testPartialOverlap() {
|
|
final source = allocate<Int64>(count: 2);
|
|
final derived = makeDerived(source);
|
|
source.value = 0x1122334455667788;
|
|
final int value = source.value;
|
|
derived.value = 0xaa;
|
|
Expect.notEquals(value, source.value);
|
|
free(source);
|
|
}
|