032738141e
I maintain the choice to _not_ rewrite a PrefixedIdentifier to a ConstructorReference in the case that it is the left side of an AssignmentExpression, because doing so requires extra additional checking during assignment verification, and probably a new error code saying a constructor cannot be assigned to, similar to the error code saying that a method cannot be assigned to. This is all feasible, but I think it is very reasonable, in AstRewrite, to say, "This prefixed identifier does seem to refer to a constructor, but it's the left side of an assignment, so I'm not going to confidently do a rewrite; instead I will leave this alone and let the assignment verification code handle it." Bug: b/200948019 Change-Id: I90c6a157c2992d4935acfb593f38518f0388bced Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214320 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com> |
||
|---|---|---|
| .. | ||
| _fe_analyzer_shared | ||
| _js_interop_checks | ||
| analysis_server | ||
| analysis_server_client | ||
| analyzer | ||
| analyzer_cli | ||
| analyzer_plugin | ||
| analyzer_utilities | ||
| async_helper | ||
| build_integration | ||
| compiler | ||
| dart2js_info | ||
| dart2js_runtime_metrics | ||
| dart2js_tools | ||
| dart2native | ||
| dart_internal | ||
| dartdev | ||
| dds | ||
| dev_compiler | ||
| diagnostic | ||
| expect | ||
| front_end | ||
| frontend_server | ||
| js | ||
| js_ast | ||
| js_runtime | ||
| kernel | ||
| language_versioning_2.7_test | ||
| meta | ||
| modular_test | ||
| native_stack_traces | ||
| nnbd_migration | ||
| scrape | ||
| smith | ||
| sourcemap_testing | ||
| status_file | ||
| telemetry | ||
| test_runner | ||
| testing | ||
| vm | ||
| vm_service | ||
| vm_snapshot_analysis | ||
| .gitignore | ||
| BUILD.gn | ||
| pkg.status | ||
| README.md | ||
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency