languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-06-28 22:05:22 +00:00
Code Issues Projects Releases Wiki Activity
master
dart-sdk/runtime
History
Ben Konyi 44d4451476 Reapply "[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer" 
In the previous version of this change, if the user had 'dart' on their
PATH and invoked 'dart compile js' (which spawns the VM service after
compilation completes), the VM service would attempt to spawn DDS using
'./dart' as the executable path instead of 'dart'. This would result in
DDS failing to start, causing the VM to print an error and hang.

This updated change checks to see if the parent directory of
`Platform.executable` is '.' and then verifies if './dart' exists or
not. If it doesn't, 'dart' is likely on the user's PATH and should be
used directly as the executable path.

See https://github.com/dart-lang/sdk/issues/56087 for details.

This reverts commit 4b88698e48.

TEST=pkg/dds/test/control_web_server_starts_dds_with_dart_on_path_test.dart

Change-Id: Id0f1dadd01d9202cbf7717f31393b43171cf3968
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373561
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2024-06-27 22:47:46 +00:00
..
bin Reland "[vm] Move ResolveUri to bin" 2024-06-26 11:10:06 +00:00
docs [vm] Cleanup obsolete pragma vm:non-nullable-result-type 2024-06-20 20:24:44 +00:00
include Add 'coverage' flag, defaulting to true, but let the gn application_snapshot default it to false 2024-06-18 09:10:00 +00:00
lib Reland "[vm] Move ResolveUri to bin" 2024-06-26 11:10:06 +00:00
observatory Reapply "[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer" 2024-06-27 22:47:46 +00:00
platform Reland "[vm] Move ResolveUri to bin" 2024-06-26 11:10:06 +00:00
tests [vm,aot] Fix type check in implicit setter of a covariant field 2024-06-25 14:34:20 +00:00
tools [vm] Remove --[no-]lazy-dispatchers flag. 2024-06-06 10:56:12 +00:00
vm [vm] Avoid GetBlock in EliminateEnvironments and DelayAllocations 2024-06-27 21:58:57 +00:00
.clang-tidy
.gitignore
BUILD.gn [vm, compiler] Allow targeting TSAN or MSAN by passing a flag to gen_snapshot. 2024-05-08 17:03:59 +00:00
codereview.settings
configs.gni [Runtime] Add extra_product_deps and extra_nonproduct_deps params to "library_for_all_configs_with_compiler" template 2023-04-14 19:51:40 +00:00
CPPLINT.cfg [cpplint] Disable runtime/references lint 2023-01-23 18:21:48 +00:00
OWNERS
PRESUBMIT.py Reland "Reland "[VM] Begin supporting Perfetto file recorder"" 2023-04-18 19:39:05 +00:00
runtime_args.gni Reland "[Fuchsia] Remove the legacy gn build rules for fuchsia" 2024-03-14 20:22:12 +00:00
vm-jit.shard.cml [test] Cleanup building Fuchsia packages/components. 2023-10-31 17:11:51 +00:00
vm.shard.cml [fuchsia][sysmem2] route fuchsia.sysmem2.Allocator 2024-05-10 17:00:29 +00:00