languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 15:17:07 +00:00
Code Issues Projects Releases Packages Wiki Activity
39491 commits 11 branches 6011 tags 1.4 GiB
Commit graph

39491 commits

This branch
This branch
All branches
Author SHA1 Message Date
Zachary Anderson
5475ab6fbb Fuchsia: Builds run_vm_tests and a wrapper program for running it. 
This CL adds rules to the GN build for building run_vm_tests for
Fuchsia. It also adds a wrapper program in
//runtime/bin/run_vm_tests_fuchsia.cc and a file containing the
output of 'run_vm_tests --list', //runtime/bin/fuchsia_vm_tests.txt.
The wrapper program and text file make it easier to run the tests
on Fuchsia, and should be able to go away once we are out of the
bootstrapping phase.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2187153003 .
 2016-07-28 10:35:25 -07:00
John McCutchan
1d7b59fa9e Add another tear off closure reload test 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2184403002 .
 2016-07-28 10:21:27 -07:00
John McCutchan
a6e2a7f0cd Add debug only counters to profiler 
- [x] Count the reasons why we don't walk the stack.
- [x] Count the reasons why we only sample a single frame.
- [x] Count the stack walkers used.

These counters are returned as part of the profile over the vm-service and can be used to debug profiler failures in the future.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2183993007 .
 2016-07-28 09:56:15 -07:00
pq
d7104c4a6c Update DEPS to pull in Linter 0.1.23. 
* Removes `whitespace_around_ops` pending re-name and re-design (#249).

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2191903002 .
 2016-07-28 09:28:28 -07:00
Konstantin Shcheglov
491775e1cc Record names of classes which unnamed constructor are used in SuperConstructorInvocation. 
So, if the unnamed constructor is changed, we can invalidate resolution.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2189783002 .
 2016-07-28 08:27:09 -07:00
William Hesse
118d55d79e Update status for html/js_util_test on IE. 
This test was introduced in
https://codereview.chromium.org/2150313003

BUG=https://github.com/dart-lang/sdk/issues/26978
R=eernst@google.com

Review URL: https://codereview.chromium.org/2188663004 .
 2016-07-28 15:30:48 +02:00
Regis Crelier
093bca5909 Temporarily skip test that became flaky after fixing #26941. 
Review URL: https://codereview.chromium.org/2192723002 .
 2016-07-27 22:38:42 -07:00
Regis Crelier
f10ce1eb69 Skip new regression test crashing when precompiled. 
Review URL: https://codereview.chromium.org/2186493005 .
 2016-07-27 18:31:50 -07:00
Regis Crelier
47cf4c1877 Set correct token position in moveNext call of for-in loops (fixes #26941). 
R=hausner@google.com

Review URL: https://codereview.chromium.org/2188763003 .
 2016-07-27 18:15:20 -07:00
Stephen Adams
478106bce2 dart2js inferrer: don't infer widened type when unreachable 
'&' and '|' were missing the case to return 'empty' if the argument was empty, causing the widened (default) type to be propagated.

There are a few bitwise operations in the streams code that have better code from being slightly more precise.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1583623002 .
 2016-07-27 17:25:56 -07:00
Vijay Menon
c6daafb260 Roll to latest DDC 
This includes jmesserly's fixes to work with the latest analyzer.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2176373008 .
 2016-07-27 16:57:20 -07:00
Ryan Macnak
d37ea681f5 RELOAD: Check if an implicit closure needs rebinding at compile time and adjust closure equality. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2187433006 .
 2016-07-27 16:51:11 -07:00
Carlo Bernaschina
daa16ff86b Added missing entry into runtime/observatory/observatory_sources.gypi 
TBR=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2184913004 .
 2016-07-27 16:05:20 -07:00
Konstantin Shcheglov
64a83d2665 Always set correspondingStaticParameters and correspondingPropagatedParameters, to clear when we don't have them. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2187863003 .
 2016-07-27 14:19:25 -07:00
Regis Crelier
11d340c51d Force local context allocation in finally clauses (fixes #26948). 
Add regression test.

R=fschneider@google.com, hausner@google.com

Review URL: https://codereview.chromium.org/2188863002 .
 2016-07-27 14:03:25 -07:00
Jacob Richman
8e787a74b0 Fix case caught by test where getUnescapedJSInteropName wasn't called. 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/2187893003 .
 2016-07-27 13:53:53 -07:00
Carlo Bernaschina
cb468c2c47 Converted Observatory vm-connect element 
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2180803002 .
 2016-07-27 13:43:38 -07:00
Carlo Bernaschina
131acbe82e Removed dynamic Symbol creation and marked Bindable classes 
R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2184873002 .
 2016-07-27 13:24:01 -07:00
Konstantin Shcheglov
528b32d997 Tests for several SummaryDataStore and ResynthesizerResultProvider features. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2186143002 .
 2016-07-27 12:58:16 -07:00
Konstantin Shcheglov
351cbb5a92 Invalidate results, which compound results of other targets. 
These results might become invalid even if the source does not use
directly any of changed names.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2172973002 .
 2016-07-27 12:51:03 -07:00
Konstantin Shcheglov
1d436a0298 Add a couple of new tests for DartWorkManager. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2184243002 .
 2016-07-27 12:40:23 -07:00
Ryan Macnak
634a62c9df DBC: Add missing deopt info after stack overflow checks. 
Fixes collecting a debugger stack trace at an interrupt.

Enable most vm-service tests.

R=zra@google.com

Review URL: https://codereview.chromium.org/2183993004 .
 2016-07-27 12:25:54 -07:00
Ryan Macnak
68957e5fc7 Check for lack of debugger support in the embedding API. 
BUG=http://dartbug.com/26949
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2176393002 .
 2016-07-27 12:03:30 -07:00
Konstantin Shcheglov
d64ebe26f2 DartWorkManager.getLibrariesContainingPart() should ask the ResultProvider for CONTAINING_LIBRARIES. 
Otherwise, because we don't actually parse units for summarized sources,
we don't build this information in DartWorkManager. But we have it
in summaries.

This fixes the problem when user opens a SDK unit and does not see any semantic highlighting, navigation, etc - because we were not able to create its fully resolved AST (which is library specific, so we need to know containing libraries). Less obvious, but similar problem is that search for references to elements defined in SDK was not working, because IDEA asks search using file and offset _in the SDK_, not at the place in workspace where it is used.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2188523004 .
 2016-07-27 11:11:24 -07:00
Danny Tuppeny
e76537e4eb Fix formatting of comment in HttpHeaders class (#26937) 2016-07-27 19:44:20 +02:00
pq
722d4a13b0 Default trailing comma support to true (#26647). 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2185873002 .

See: https://github.com/dart-lang/sdk/issues/26647.
 2016-07-27 09:42:12 -07:00
pq
da84692f57 DEPS bump to pull in linter 0.1.22. 
Linter `0.1.22`.

* Grinder support (`rule:rule_name` and `docs:location`) for rule stub and doc generation (respectively).
* Fix to allow leading underscores in `non_constant_identifier_names`.
* New `valid_regexps` lint (#277).
* New `whitespace_around_ops` lint (#249).
* Fix to `overridden_fields` to flag overridden static fields (#274).
* New `list_remove_unrelated_type` to detect passing a non-`T` value to `List.remove()`` (#271).
* New `empty_catches` lint to catch empty catch blocks (#43).
* Fixed `close_sinks` false positive (#268).
* Added `linter` support for `--strong` to allow for running linter in strong mode.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2185833004 .
 2016-07-27 09:17:52 -07:00
Kevin Moore
17a2ddfd42 Update dependency on pkg/package_compiler 
For analysis_server, analyzer, analyzer_cli, compiler packages

Progress on https://github.com/dart-lang/sdk/issues/26711

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2172683002 .
 2016-07-27 08:42:05 -07:00
Konstantin Shcheglov
41ac430887 Issue 26748. Apply existing import/export elements to corresponding directive nodes in DirectiveResolver using just offsets. 
If the source was not changes, then AST and elements correspond to
each other, otherwise both should have been invalidated. As it is now,
it seems that checking creates more problems than it solves.

R=brianwilkerson@google.com, pquitslund@google.com
BUG= https://github.com/dart-lang/sdk/issues/26748

Review URL: https://codereview.chromium.org/2188563002 .
 2016-07-27 08:35:15 -07:00
Terry Lucas
87d0c3049a Update to latest WebKit 
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/2188523003 .
 2016-07-27 06:33:05 -07:00
Stephen Adams
9d5fd9d5bd Avoid using call-through stub on calls to fields. 
This usually removes the demand for the call-through stub and sometimes enables optimizations on the field load, e.g.:

    WhereIterator: {
      "^": "Iterator;_iterator,_f",
      moveNext$0: function() {
        for (var t1 = this._iterator; t1.moveNext$0();)
          if (this._f$1(t1.get$current()) === true)
            return true;
        return false;
      },
      _f$1: function(arg0) {
        return this._f.call$1(arg0);
      }
      ...
-->
    WhereIterator: {
      "^": "Iterator;_iterator,_f",
      moveNext$0: function() {
        var t1, t2;
        for (t1 = this._iterator, t2 = this._f; t1.moveNext$0();)
          if (t2.call$1(t1.get$current()) === true)
            return true;
        return false;
      },
      ...

BUG= https://github.com/dart-lang/sdk/issues/22197
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2180363002 .
 2016-07-26 18:02:05 -07:00
Ryan Macnak
d4e1f13644 Fix profiler access to the Dart stack pointer on ARM64. 
Cf. 642f754219.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2184903002 .
 2016-07-26 16:59:16 -07:00
Priscilla Lee
9fa7b5effe Removed io dependencies in analyzer to allow compiler to run in the browser 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org/2176363002 .
 2016-07-26 16:43:34 -07:00
John McCutchan
a458f45a02 Enable WebSocket compression for the service protocol 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2184793002 .
 2016-07-26 15:25:05 -07:00
Stephen Adams
67f8356601 Untested hacks to swarm to avoid warnings. 
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1766533002 .
 2016-07-26 15:24:36 -07:00
Konstantin Shcheglov
a3b1936567 Fix for SearchEngine.searchMemberDeclarations() - search exact names. 
R=pquitslund@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2183263002 .
 2016-07-26 14:47:32 -07:00
Terry Lucas
9f03b11a5d Updated to latest WebKit changes 
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/2183613004 .
 2016-07-26 12:30:17 -07:00
Lars Bak
a4a314251b Added use of from_. 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2183703003 .
 2016-07-26 11:22:40 -07:00
Lars Bak
293c6116e9 Implemented schema change for the isolate reload operation. 
I'll add more tests to isolate_reload_test.cc while waiting for the first round of comments.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2179983002 .
 2016-07-26 11:13:28 -07:00
pq
9f424fa9d5 Remove duplicated import. 
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2181423002 .
 2016-07-26 10:56:22 -07:00
Konstantin Shcheglov
f4b1d502f3 Issue 26747. Report HintCode.UNDEFINED_SHOWN_NAME, but not HintCode.UNUSED_SHOWN_NAME for unresolved shown names. 
R=pquitslund@google.com, brianwilkerson@google.com, srawlins@google.com
BUG= https://github.com/dart-lang/sdk/issues/26747

Review URL: https://codereview.chromium.org/2182593004 .
 2016-07-26 10:36:29 -07:00
Ryan Macnak
708334c614 DBC: Fix reading locals out of a deopt frame. 
R=zra@google.com

Review URL: https://codereview.chromium.org/2176413003 .
 2016-07-26 10:36:07 -07:00
Konstantin Shcheglov
4211fb7525 Remove unused code from limited invalidation. 
We now perform the whole cache visits to gather changed elements,
so there is no need in the limited in-the-same-unit updates.

R=pquitslund@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2185713002 .
 2016-07-26 10:28:01 -07:00
Jacob Richman
a711a35021 Fix missing line for js_util in dart_server.platform 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/2181403002 .
 2016-07-26 10:26:29 -07:00
pq
065238943a Associate excludes with context data. 
A step towards centralizing file exclusion handling (which is currently duplicated by all analyzer clients).

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2183003003 .
 2016-07-26 10:24:39 -07:00
Stephen Adams
94df5a0c24 dart2js: Avoid empty else clauses in generators. 
R=sigurdm@google.com

Committed: a02c5798a4

Review URL: https://codereview.chromium.org/1916863002 .

Reverted: 803826256d
 2016-07-26 09:58:34 -07:00
Zachary Anderson
9eca0e5714 DBC: Fix 32-bit build 
Review URL: https://codereview.chromium.org/2178413002 .
 2016-07-26 07:50:54 -07:00
Zachary Anderson
e14263a09a Remove duplicate entries from a .gypi file 
+cbernaschina@google.com FYI

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2179843003 .
 2016-07-26 07:37:23 -07:00
John McCutchan
50c141d298 Mark closure identity test as pass, fail for reload bots 
BUG=

Review URL: https://codereview.chromium.org/2181233003 .
 2016-07-26 06:38:06 -07:00
Konstantin Shcheglov
cc290c1dc0 Fix for false positive in field (not-)overriding. 
Fields can also override setters.

R=pquitslund@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2174423005 .
 2016-07-25 22:49:01 -07:00