Brian Wilkerson
213f0322f9
Fix missed version number
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//1165763002
2015-06-01 09:50:57 -07:00
Konstantin Shcheglov
9a70cb5333
Remove AnalysisContext.visibleLibraries getter.
...
It is not used anymore.
It's functionality is not clear.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1156223005
2015-06-01 09:40:30 -07:00
Brian Wilkerson
07dd6b7649
Add lineLength parameter to edit.format request (issue 23519)
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//1154303005
2015-06-01 09:39:02 -07:00
Konstantin Shcheglov
9dc5bc79f1
Issue 23518. Match prefixes of prefixed types.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23518
Review URL: https://codereview.chromium.org//1149953005
2015-06-01 09:27:29 -07:00
Todd Turnidge
f6d3d4681d
Rename some service protocol errors.
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1164463005
2015-06-01 09:26:54 -07:00
danrubel
0e39092fd0
add enum suggestions
...
and update LocalDeclarationVisitor to visit enum declarations
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1157113004
2015-06-01 12:10:46 -04:00
Paul Berry
c9b672a6dd
Make analyzer DDC warning clean.
...
R=brianwilkerson@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//1153503005
2015-06-01 08:54:13 -07:00
Konstantin Shcheglov
4f7799c258
Fix two applyChanges() tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1152553005
2015-06-01 08:30:28 -07:00
Brian Wilkerson
089038b085
Move index closer to the plugin API
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1156493004
2015-06-01 08:25:40 -07:00
Johnni Winther
5252749865
Reinsert registration of dependency.
...
BUG=
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//1149743005
2015-06-01 16:34:38 +02:00
John McCutchan
864f9a3c9b
Cap the number of pending accepts on Windows
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1151753008
2015-06-01 06:38:22 -07:00
Johnni Winther
3b52900308
Element model cleanup + prepare for easier reimplementation.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1162603006
2015-06-01 15:00:48 +02:00
Johnni Winther
96efb7bde8
Introduce WorldImpact
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1146813009
2015-06-01 14:43:30 +02:00
Johnni Winther
d46101e3bb
Split semantic_visitor_test.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1160273002
2015-06-01 13:44:17 +02:00
Johnni Winther
a40267cb91
Copy for splitting semantic_visitor_test.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1158803005
2015-06-01 13:38:19 +02:00
Rico Wind
bf1bd86352
Don't run pkg_tested on the arm bots
...
R=whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//1156993017
2015-06-01 13:32:27 +02:00
Asger Feldthaus
bd4e1d726f
dart2js cps: Track underlying value of interceptors in type propagation.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1154173002
2015-06-01 11:19:36 +02:00
Karl Klose
b1c1c34029
Update dart2js-cps_ir test expectations.
...
TBR=johnniwinther@google.com
Review URL: https://codereview.chromium.org//1165703002
2015-06-01 11:00:02 +02:00
Karl Klose
207328a868
Disable failing assertion.
...
BUG= http://dartbug.com/23555
TBR=sra@google.com
Review URL: https://codereview.chromium.org//1157773009
2015-06-01 10:35:26 +02:00
Karl Klose
44f04fa0f7
Revert "Trust inferred type when propagating types in the SSA backend."
...
This uncovered a bug in optimizations that would introduce a return into an async* function.
This reverts commit 8a544b0754
.
R=sigurdm@google.com
Review URL: https://codereview.chromium.org//1166653002
2015-06-01 10:27:45 +02:00
Ivan Posva
ccf44becd2
- Use #if defined(DEBUG)
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1152773003
2015-05-29 17:43:36 -07:00
Natalie Weizenbaum
011fa23682
Add pub tests to pkg_tested.status
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//1157863006
2015-05-29 16:34:41 -07:00
Natalie Weizenbaum
6c2bda657c
Add pub to dartium's DEPS file.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//1149983005
2015-05-29 15:58:39 -07:00
Ryan Macnak
4102b0c446
Canonicalize mixin type during class finalization. Add asserts that most types are canonical.
...
R=regis@google.com
Review URL: https://codereview.chromium.org//1167583002
2015-05-29 15:29:04 -07:00
Natalie Weizenbaum
3d8c06c4e9
Start pulling pub from its own repo.
...
Pub now lives in third_party/pkg/pub (it's in pkg to make it possible to import
using "package:" imports).
R=ricow@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org//1165473002
2015-05-29 14:50:18 -07:00
Ivan Posva
8f1506e817
- Determine whether the simulator is being used in globals.h
...
- Make sure to switch on HOST_ARCH_ and on USING_SIMULATOR
where appropriate.
- Avoid allocating in new generation when running in the VM isolate.
BUG=
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1156053006
2015-05-29 14:35:29 -07:00
Ryan Macnak
c6ebef9526
Address hints in the Observatory.
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org//1161553013
2015-05-29 13:42:31 -07:00
Regis Crelier
601da25b92
Fix issue 23500
...
BUG=
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1146993003
2015-05-29 13:31:16 -07:00
Todd Turnidge
8adf7de6d1
Introduce Instance.kind.
...
Use this instead of subclassing Instance in the service protocol.
Revise many instance property names.
BUG=
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org//1162133002
2015-05-29 13:02:36 -07:00
Sigmund Cherem
013897fe29
Add support for null-aware operators to the CPS-IR.
...
R=johnniwinther@google.com , kmillikin@google.com
Review URL: https://codereview.chromium.org//1160833003
2015-05-29 12:01:42 -07:00
Siva Annamalai
7af681ead9
Fix for issue 23547, return an proper ApiError instead of a string when we report outstanding typed data acquire errors.
...
BUG=23547
R=koda@google.com
Review URL: https://codereview.chromium.org//1156993012
2015-05-29 11:13:33 -07:00
Paul Berry
1017ea0fca
Verify that new task manager invalidation code handles cycles.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1165573002
2015-05-29 11:07:33 -07:00
danrubel
ecf44e960d
remove keyword suggestions in constructor names and prefixed expressions
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1158413003
2015-05-29 13:28:34 -04:00
Harry Terkelsen
5e11a7038b
Bump package_config version to 0.0.2+4
...
BUG=
R=pquitslund@google.com
Review URL: https://codereview.chromium.org//1160033003
2015-05-29 10:23:29 -07:00
Sigmund Cherem
7e2dc9eb2a
Improve error for non-const implicit super constructor
...
BUG= http://dartbug.com/23543
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//1156923007
2015-05-29 09:24:00 -07:00
Daniel Andersson
092d27cf34
Remove serializer whitelisting for 'dart:collection'
...
Since LinkedHashMap is now VM-internal, this exception is no longer needed.
BUG=22982
R=asiva@google.com
Review URL: https://codereview.chromium.org//1149933007
2015-05-29 09:17:55 -07:00
Srdjan Mitrovic
d7d0d92ec3
Do not eagerly add guarded leaf classes with CHA; do not add them for private names.
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1158673004
2015-05-29 08:57:34 -07:00
Asger Feldthaus
ac4ab2b5b7
dart2js cps: Remove dart2dart from cps pipeline and clean up.
...
Removing dart2dart stuff is the most radical change, but there's also
a bunch of general clean up, some of it somewhat unrelated, but long
overdue.
I've focused on making the IR easier to read end-to-end.
For instance, I've stripped out a complicated assertion on InvokeMethod,
because it is distracting and hasn't paid off. AFAIK it never caught a
single bug, but a few times it has spuriously failed and needed
patching.
Some notable changes in the IR:
- Removed FieldDefinition, ConstructorDefinition, Initializers.
- Removed RootNode. There was only one subclass left.
- Removed Body. Has been inlined into FunctionDefinition.
- MutableVariable can no longer be a function parameter.
- Removed default parameter values and local constants from the IR.
I decided to keep nested functions for the time being because there is
a slight chance they might come in handy for async/await.
I'm not sure yet. We can strip them out later if they are not needed.
I've also left the subclassing JsIrBuilder <: IrBuilder for now,
even though the classes could be merged. Same with the visitor.
BUG=
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//1155463005
2015-05-29 17:39:00 +02:00
Johnni Winther
073a202b06
Allow this?.foo (again)
...
BUG=
Review URL: https://codereview.chromium.org//1151063003
2015-05-29 16:16:23 +02:00
Johnni Winther
76728304e9
Compute more SendStructures on ResolverVisitor.
...
BUG=
R=karlklose@google.com
Review URL: https://codereview.chromium.org//1157333003
2015-05-29 15:26:28 +02:00
Johnni Winther
a6bbcc3c87
Support implicit super constructor invocation in SemanticDeclarationVisitor.
...
BUG=
R=ajohnsen@google.com , karlklose@google.com
Review URL: https://codereview.chromium.org//1160153002
2015-05-29 14:49:59 +02:00
Lasse R.H. Nielsen
babcd4e9c0
Revert "Make EfficientLength public, as EfficientLengthIterable."
...
It's still not a good solution for detecting an Iterable with an efficient
length. It's not inherited by, e.g., a DelegatingIterable wrapper or similar
generic Iterable transformers.
Keep this as an internal optimization for quickly detecting the most common
efficient-length Iterable classes (List, Set, Queue, Map.keys/values), but
don't make it public.
A *real* solution would be adding a hasEfficientLength getter to Iterable, or
adding an efficientLength getter that may return null if it's not efficient.
This would something that a wrapper can attach to.
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1154263003
2015-05-29 12:52:45 +02:00
Florian Schneider
88d316fbc0
VM: Fix two incorrect function fingerprints.
...
The checking code was broken for a while, so this mismatch was not noticed.
BUG=
R=vegorov@google.com
Review URL: https://codereview.chromium.org//1156423002
2015-05-29 12:20:09 +02:00
Rico Wind
a237ebf344
Run pkg_tested on the pkg/pub bots
...
R=whesse@google.com
BUG=
Review URL: https://codereview.chromium.org//1153193010
2015-05-29 11:34:08 +02:00
Lasse R.H. Nielsen
542e675fed
Fix typo in dart2js typed_data.
...
Review URL: https://codereview.chromium.org//1163653002
2015-05-29 11:18:01 +02:00
Lasse R.H. Nielsen
cf4eaae5a6
Change RangeError instances to use RangeError.range.
...
This avoids using the (sometimes confusing) "[...)" notation for half-open ranges.
Also change argument tests to simpler interval tests, and move error handling to the end of the functions.
Mostly in VM typed-data libraries.
R=sgjesse@google.com , srdjan@google.com
Committed: 932bcc6901
Review URL: https://codereview.chromium.org//1132603003
2015-05-29 10:50:20 +02:00
Karl Klose
993338408e
cps_ir: Handle malformed type arguments and type checks.
...
R=asgerf@google.com
Review URL: https://codereview.chromium.org//1156373008
2015-05-29 09:53:35 +02:00
Harry Terkelsen
abe76176b6
Roll package_config forward to 0.0.2+3
...
BUG=
R=pquitslund@google.com
Review URL: https://codereview.chromium.org//1161613008
2015-05-28 16:31:19 -07:00
pq
e78621b0a1
Bump package_config to 0.0.2+2.
...
R=sethladd@google.com
Review URL: https://codereview.chromium.org//1155813003
2015-05-28 14:05:41 -07:00
Todd Turnidge
67adc6102d
Add getVersion and setLibraryDebuggable RPCs to the service protocol.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1149373006
2015-05-28 13:34:23 -07:00