They might depend on each other, we cannot infer one or another first.
R=brianwilkerson@google.com
Change-Id: I9639a53561ec12d556fa1b45c44cf8aeb497f618
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Also added missing awaits to several previously committed tests.
Change-Id: Ide2d714b02e36f097f7c958b609dd780ff333253
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109420
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Incomplete but enough there for some initial feedback.
Change-Id: I186b376826d7ffdd8ed2be8e263231abb78cc187
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Use BigInt arithmetic when intermediate products might overflow.
Web versions range-check inputs to avoid working on truncated inputs.
Bug: 37469
Change-Id: I27d2da2fff7901ce6dbfa5929c6998e87e8808e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109360
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
Adds the --serialize_flow_graphs_to flag, which takes a
filename to which to serialize all compiled functions.
This flag is only active for the AOT compiler.
Bug: https://dartbug.com/36882
Change-Id: Ib7e328ad93373168806539f0a61ec0a07506a51d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107400
Commit-Queue: Teagan Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Not a huge different, just closer to what we might want in the future.
I decided to make it explicit opt-in for now, until we kow better.
R=brianwilkerson@google.com
Change-Id: Ied8defe87bfd8b35117af085389cbab7e9b7d589
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109315
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
the recent regression seen in flutter hot reload benchmarks
after the roll of Dart BE into flutter post 1.7 release.
Change-Id: I188fa4aafdd7cdfa6b793de9d7ab00c9dae05409
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109361
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
This reverts commit 33a757284b.
Reason for revert: This CL seems to depend on
@pragma('vm:never-inline')`
@pragma('vm:prefer-inline')`
being implemented which has been reverted.
Original change's description:
> [vm/compiler] Use pragmas instead of separately-maintained lists for inlining.
>
> This closes https://github.com/dart-lang/sdk/issues/36571.
>
> Change-Id: I4d77192f2c33dd4872d58ef07ccd32069b8b63df
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99154
> Commit-Queue: Teagan Strickland <sstrickl@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
TBR=kustermann@google.com,sstrickl@google.com
Change-Id: Ied0686ad282f2ed772ff9adbc551f64ba8855aff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109340
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
This reverts commit 629f38cf87.
Reason for revert: This CL seems to depend on constant_update_2018 flag being turned on by default. The CL that turns on constant_update_2018 has been reverted, so this CL is also being reverted.
Original change's description:
> [vm/compiler] Implement new inlining pragmas.
>
> This change introduces two new pragmas:
>
> * `@pragma('vm:never-inline')`
> * `@pragma('vm:prefer-inline')`
>
> These replaces the old way of specifying AlwaysInline or NeverInline
> annotations when the (now removed) --enable-inlining-annotations flag
> was used.
>
> Bug: https://github.com/dart-lang/sdk/issues/36571
> Change-Id: I2495c72819d94e43cefc837d4eb454b7b3d4140c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99148
> Commit-Queue: Teagan Strickland <sstrickl@google.com>
> Reviewed-by: Samir Jindel <sjindel@google.com>
TBR=sjindel@google.com,sstrickl@google.com
Change-Id: Idc8e8344adb026a308af20c8b0d0224edb891d9c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/36571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109320
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
This reverts commit 9bbd3192f4.
Reason for revert: Reverting enabling of constant-update-2018 by default as some blocking issues were found that are breaking Flutter and preventing rolls of Dart into Flutter. Once the blocking issues are addressed and fixed this CL will be relanded.
Original change's description:
> [dart] Enable constant-update-2018
>
> Change-Id: Ib3942b4f6e336a02826305d9f81839333a5464a0
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106943
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
TBR=paulberry@google.com,vegorov@google.com,athom@google.com,vsm@google.com,aadilmaan@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I5796881412cec464f450ff3894ca253c58edc4a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109308
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
JSON RPC notifications never receive a response by design. In the VM
service, if an error needs to be returned for a request and the request
was a notification (i.e., has no ID associated with it), null is
returned. The Dart side of the service tries to create a Response object
with the null value, resulting in an exception being thrown. This change
will swallow the errors in situations where a notification RPC is
invalid.
Change-Id: If7d889150bfec51b933474f7a66fffb25e82daed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109200
Reviewed-by: Siva Annamalai <asiva@google.com>
Follow-up from https://dart-review.googlesource.com/c/sdk/+/109144.
* guards against extension dups
* improves checking to only tests types once (and migrates to using `TypeSystem.isSubtypeOf`)
Change-Id: Ibb5791dc6a52374d751315385341071fee5dde1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
This change introduces two new pragmas:
* `@pragma('vm:never-inline')`
* `@pragma('vm:prefer-inline')`
These replaces the old way of specifying AlwaysInline or NeverInline
annotations when the (now removed) --enable-inlining-annotations flag
was used.
Bug: https://github.com/dart-lang/sdk/issues/36571
Change-Id: I2495c72819d94e43cefc837d4eb454b7b3d4140c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99148
Commit-Queue: Teagan Strickland <sstrickl@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
This changes `File.openRead()` back to returning a `Stream<List<int>>`
and `HttpClientResponse` back to implementing `Stream<List<int>>`.
These two changes broke a significant number of call sites; backing it
out enables us to keep the changes from landing in the next dev release
until we analyze whether we can roll these changes out in a softer
manner or if they're worth making at all.
Bug: https://github.com/dart-lang/sdk/issues/36900
Change-Id: I8977abcba40c58a4ca2b4a05d857512989a1e0b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109102
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Todd Volkert <tvolkert@google.com>
TypeBuilder and FunctionTypeBuilder are only subclassed by
KernelTypeBuilder and KernelFunctionTypeBuilder, respectively, so the
distinction can be removed.
Change-Id: I2cccd0d6b08f695ecb6ccb543f858edd4919cfda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108819
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
