Commit graph

46774 commits

Author SHA1 Message Date
Terry Lucas
f27144d7b5 Roll 50: Updated for push to origin/master.
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2875773003 .
2017-05-10 18:16:51 -07:00
Bob Nystrom
a68b44924e Disambiguate setters and getters when patching DDC SDK.
Stdio was having its setters applied twice instead of applying the
getter and setter each once.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2874713005 .
2017-05-10 16:56:41 -07:00
Paul Berry
17c23be470 Set MethodInvocation.interfaceTarget during type inference.
We need to compute the interface target in order to do the inference
anyway, so this is a reasonable time to store it.

Also annotate the inference tests with interface targets so that we
can verify that the interface targets computed by analyzer match those
computed by Fasta.  Note that this causes a few strong mode tests to
fail that were previously passing, due to the fact that type inference
in Fasta is incomplete.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2874033003 .
2017-05-10 14:31:05 -07:00
Konstantin Shcheglov
114f49dcab Add the test for updating a part.
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2876643002 .
2017-05-10 14:20:35 -07:00
Stephen Adams
d9e094b906 Add more arguments to JS pseudo-function
TBR=sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2869333003 .
2017-05-10 14:03:46 -07:00
Brian Wilkerson
3b2c3ae5b2 Add support for built-in plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2874803003 .
2017-05-10 13:31:20 -07:00
Steve Messick
55097a44b3 Recover from merge problem
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2868383002 .
2017-05-10 13:12:14 -07:00
Konstantin Shcheglov
176c7d7303 Replace factory constructor with a static method for creating IncrementalKernelGenerator.
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2869273006 .
2017-05-10 13:10:11 -07:00
Stephen Adams
28d83e6c2b Fix swarm for non-integer Event timeStamps
Also make Mock implement new methods on Event

TBR=sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2868423003 .
2017-05-10 12:48:39 -07:00
Paul Berry
6208c8f05c Propagate type inference through variable gets.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2872323003 .
2017-05-10 12:21:32 -07:00
Devon Carew
f1a5503fcc Add --fatal-infos; hide --fatal-hints.
BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2874043002 .
2017-05-10 11:45:11 -07:00
Sigmund Cherem
c911f44c3f fix checked-mode failure in perf_test
TBR=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2868393002 .
2017-05-10 11:37:19 -07:00
Sigmund Cherem
bd85c499b0 Allow overriding core types in dart:_interceptors.
This gets rid of the warning you get today when building the SDK (you can see
this on the `build.py -m release patched_dart2js_sdk` target).

R=ahe@google.com, paulberry@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2869393003 .
2017-05-10 11:33:23 -07:00
Sigmund Cherem
5366a1f76c Fix compiler.perf script
TBR=johnniwinther@google.com,vegorov@google.com

Review-Url: https://codereview.chromium.org/2875703002 .
2017-05-10 11:15:08 -07:00
Paul Berry
e68668f88d Fix method call type inference with explicit type parameters.
This was broken for three reasons:

- We weren't recording the fact that the type parameters were
  explicitly provided, so the inference code path to handle this case
  wasn't being exercised.

- The inference code path to handle this case was accidentally
  referring to the `inferredTypes` variable, which is `null` in this
  case.

- We were not checking for the case where the user provided the wrong
  number of type parameters.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2874053002 .
2017-05-10 11:00:29 -07:00
Leaf Petersen
a2ebe9c809 Update DDC built sdk.
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2873363002 .
2017-05-10 10:30:33 -07:00
Paul Berry
22f68e6450 Fix annotation of generic method invocations in Fasta inference tests (again).
In c8026439dc, I was overzealous and
annotated all generic method invocation parameters, whether they were
inferred or explicit.  We just want to annotate the inferred ones.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2866363004 .
2017-05-10 10:21:44 -07:00
Jacob Richman
a35b79f178 Support configuring DDC runtime settings before the application starts and normalize API for configuring runtime settings.
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2874813002 .
2017-05-10 10:05:49 -07:00
Zachary Anderson
713b89fbe7 [infra] Stop console spam from utils.py on a cross-build
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2873613004 .
2017-05-10 09:41:45 -07:00
Paul Berry
44010ea549 Update status file for #29594
This should fix the analyzer bots.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2873343002 .
2017-05-10 09:39:40 -07:00
Brian Wilkerson
a3ac4253b1 Remove an obsolete error from the spec and an obsolete command-line flag
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2865403005 .
2017-05-10 09:33:43 -07:00
Bob Nystrom
224cb59528 Update dart_style to 1.0.6. (#29591)
This brings in support for URIs in "part of" directives.
2017-05-10 09:19:48 -07:00
Brian Wilkerson
2a4772a537 Remove unnecessary tests
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2868233003 .
2017-05-10 09:15:36 -07:00
Brian Wilkerson
e6c8092cea Enable analysis driver in tests where possible
R=danrubel@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2868353002 .
2017-05-10 09:13:25 -07:00
Terry Lucas
4d6fa74118 Temporary to make bots green with Chrome 50 IDLs
R=whesse@google.com
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2873323002 .
2017-05-10 07:51:08 -07:00
Terry Lucas
88a226b58b New sdk/lib generated from Chrome 50 IDLs
TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2871193002 .
2017-05-10 05:26:37 -07:00
Erik Ernst
7adb470835 Revert "Allowing e of any type in void f(...) => e in the analyzer."
This reverts commit 025b83fb89.

Review-Url: https://codereview.chromium.org/2871163002 .
2017-05-10 12:54:24 +02:00
Erik Ernst
025b83fb89 Allowing e of any type in void f(...) => e in the analyzer.
Addresses https://github.com/dart-lang/sdk/issues/28940.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2870063002 .
2017-05-10 11:36:43 +02:00
Zhivka Gucevska
8ea3c3b3e6 Refactor argument evaluation for static invocation
BUG=
R=dmitryas@google.com, kmillikin@google.com

Review-Url: https://codereview.chromium.org/2871953002 .
2017-05-10 11:11:32 +02:00
Johnni Winther
5e5aa2ea9e Skip constructors from ElementEnvironment.forEachClassMember
- and don't mixin static members

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2871573007 .
2017-05-10 09:52:53 +02:00
Johnni Winther
2a3d86acec Rewrite Constantifier.visitLet
R=sra@google.com

Review-Url: https://codereview.chromium.org/2872833003 .
2017-05-10 09:45:18 +02:00
Johnni Winther
958ab524c4 Pass data objects to ConstantEmitter
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2873633002 .
2017-05-10 09:28:38 +02:00
Johnni Winther
37f86b324e Pass data objects directly to NativeEmitter
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2872613003 .
2017-05-10 09:23:44 +02:00
Lasse R.H. Nielsen
7157b6aef2 Make Future._nullFuture be initialized synchronously.
Also type it as Future<Null> now that it makes sense.

Because there is no reason not to.

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2867763003 .
2017-05-10 09:21:08 +02:00
Ryan Macnak
1bf31322ad Omnibus Observatory UI fixes:
- Globally replace InstanceRepository with ObjectRepository. In general, instances may reference non-instances, so we should not assume we'll only get instances from the fields of instances.
 - Allow expanding context and closure refs like regular instance refs.
 - Fix display of a mirror reference's referent, which is never an instance or context.

R=aam@google.com, mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2873013004 .
2017-05-09 17:00:34 -07:00
danrubel
5b969e04f9 enable new analysis driver for completion sorter tests
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2875483002 .
2017-05-09 16:54:43 -07:00
Paul Berry
6e499b16cf Implement type inference of method invocations in Fasta.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2873813002 .
2017-05-09 16:51:05 -07:00
Brian Wilkerson
947413addc Remove an obsolete flag from test support
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2875433002 .
2017-05-09 16:39:57 -07:00
Jennifer Messerly
4c377076bf fix #29585, implement equality for tearoffs
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2873073002 .
2017-05-09 16:21:51 -07:00
Paul Berry
c8026439dc Fix annotation of generic method invocations in Fasta inference tests.
Note that one Fasta test starts failing as a result of this change,
due to the fact that the Fasta type inference logic is not yet
complete.

R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2867253004 .
2017-05-09 15:25:20 -07:00
Vijay Menon
36356c28c1 Better stack trace support
- Caches stack trace objects (package:stack_trace appears to rely on this)
- Better support for stack traces on primitives

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2869463002 .
2017-05-09 14:58:34 -07:00
Stephen Adams
aab31aa1a4 dart2js: Smaller async error sequence when only one handler
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2856223004 .
2017-05-09 14:44:42 -07:00
Brian Wilkerson
fbc3f3708d Remove unused reference to SearchEngine
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2872803003 .
2017-05-09 14:32:12 -07:00
Jennifer Messerly
811a9eed1d Revert "Revert "fix #27256, track type bounds for generic functions""
This reverts commit 3a23e604e2.

The problem was unrelated to the CL; it appears to be a dart:async break of package:async.

In the meantime we have turned on --unsafe-force-compile to DDC's shapshotting step

Review-Url: https://codereview.chromium.org/2869733006 .
2017-05-09 14:20:25 -07:00
Vijay Menon
96f9287c0b Regenerate DDC artifacts
I had to put --unsafe-force-compile back to get the snapshot to build.  Investigating...

TBR=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2873013003 .
2017-05-09 14:08:47 -07:00
Paul Berry
12ee9643d9 Fix annotation of promoted parameters in Fasta inference tests.
Previously, we only annotated "promotedType" for local variables; we
need to annotate it for function parameters as well.

Note that a few Fasta tests start failing as a result of this change,
due to the fact that the Fasta type promotion/inference logic is not
yet complete.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2868133002 .
2017-05-09 13:59:21 -07:00
Brian Wilkerson
68b6f9b90d Fix bot failures (TBR)
Review-Url: https://codereview.chromium.org/2869193002 .
2017-05-09 13:51:54 -07:00
Ryan Macnak
51ce2ba5e8 Clarify presentation of the target in retaining paths.
Update styles etc to fix missing italics.

R=aam@google.com

Review-Url: https://codereview.chromium.org/2862383002 .
2017-05-09 13:37:33 -07:00
Brian Wilkerson
1f893e86a9 Clean up some warnings
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2874443003 .
2017-05-09 13:07:06 -07:00
Brian Wilkerson
a70e29ac60 Add support for converting elements to plugin API objects
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2873503007 .
2017-05-09 13:02:31 -07:00