Commit graph

13368 commits

Author SHA1 Message Date
Florian Loitsch 99e5328eac Revert "Return futures on Stream.cancel when possible."
This reverts commit 395e7aaa69.

Review URL: https://codereview.chromium.org/2213193004 .
2016-08-05 14:32:14 +02:00
Florian Loitsch 395e7aaa69 Return futures on Stream.cancel when possible.
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2202533003 .
2016-08-05 13:58:45 +02:00
Regis Crelier c8910f9d38 Update new test to check asserts only if they are enabled and remove VM option.
It seems like asserts are not supported correctly in product mode.

Review URL: https://codereview.chromium.org/2215143002 .
2016-08-04 16:01:19 -07:00
Sigmund Cherem 0eee4027a6 Delete dart_backend from compiler.
R=sra@google.com

Review URL: https://codereview.chromium.org/2213673002 .
2016-08-04 15:57:04 -07:00
Regis Crelier fbbedf4f18 Introduce getter p on double in the VM to control fractional precision.
Add test.

R=asiva@google.com, fschneider@google.com

Review URL: https://codereview.chromium.org/2208473006 .
2016-08-04 15:18:00 -07:00
Matthias Hausner 6075a53547 Skip initializing_formal_* tests on Dartium
Apparently the VM does not get the --initializing-formal-access flag
set, which these tests need in order to pass.

TBR=terry

BUG=

Review URL: https://codereview.chromium.org/2219473002 .
2016-08-04 13:47:21 -07:00
Matthias Hausner 643fdb9dc8 Implement the language change that makes initializing formal parameters visible in the initializer list, but not in the constructor's body.
The feature is enabled with the flag --initializing-formal-access.

BUG=26655, 26656
R=regis@google.com

Review URL: https://codereview.chromium.org/2051213005 .
2016-08-04 11:24:25 -07:00
William Hesse cad5dd65cb Update status for Firefox 48
Also update status for Chrome on macOS.

BUG=https://github.com/dart-lang/sdk/issues/26789
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2215763002 .
2016-08-04 15:55:45 +02:00
Florian Loitsch ef4933df25 Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Committed: 34aed6a08b

Reverted: a1005bad7e

Committed: 8c4954492f

Reverted: 5ebcd3cda0

Committed: eaeb260244

Review URL: https://codereview.chromium.org/2205913003 .

Reverted: 90a194be3c
2016-08-04 14:45:01 +02:00
Florian Loitsch 90a194be3c Enter a description of the change.
Merge branch 'master' into revert

Revert "Better error-message when bind fails."

This reverts commit eaeb260244.

Review URL: https://codereview.chromium.org/2213533002 .
2016-08-03 23:18:39 +02:00
Florian Loitsch eaeb260244 Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Committed: 34aed6a08b

Reverted: a1005bad7e

Committed: 8c4954492f

Review URL: https://codereview.chromium.org/2205913003 .

Reverted: 5ebcd3cda0
2016-08-03 22:44:28 +02:00
Zachary Anderson 0e6f087942 Clear the error bit after reading the default trusted certs
fixes #26954

R=whesse@google.com

Review URL: https://codereview.chromium.org/2211453002 .
2016-08-03 12:24:35 -07:00
Ryan Macnak 5ebcd3cda0 Revert "Better error-message when bind fails."
This reverts commit 8c4954492f.

This change broke the Android build.

Review URL: https://codereview.chromium.org/2201183004 .
2016-08-03 09:54:57 -07:00
John McCutchan af46b9dc55 Fix typo in status file
BUG=

Review URL: https://codereview.chromium.org/2203163003 .
2016-08-03 08:34:11 -07:00
John McCutchan 6a23dda952 Mark double_pow_test as failing with a runtime error for reload
BUG=

Review URL: https://codereview.chromium.org/2209683003 .
2016-08-03 08:03:16 -07:00
Florian Loitsch 8c4954492f Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Committed: 34aed6a08b

Review URL: https://codereview.chromium.org/2205913003 .

Reverted: a1005bad7e
2016-08-03 16:27:48 +02:00
Florian Loitsch a1005bad7e Revert "Better error-message when bind fails."
This reverts commit 34aed6a08b.

Review URL: https://codereview.chromium.org/2210523002 .
2016-08-03 15:47:15 +02:00
Florian Loitsch 873c6e4688 Don't close stdio/stderr when shutting down.
Fixes #26872.

BUG= http://dartbug.com/26872
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2204953002 .
2016-08-03 15:30:30 +02:00
Florian Loitsch 34aed6a08b Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2205913003 .
2016-08-03 15:29:41 +02:00
John McCutchan 35146c688e Fix reload handling of unwind / stackoverflow errors
BUG=

Review URL: https://codereview.chromium.org/2201283002 .
2016-08-02 18:27:35 -07:00
John McCutchan b8500cdd2d More reload status and bug fixes
TBR=rmacnak

Review URL: https://codereview.chromium.org/2209513003 .
2016-08-02 17:26:13 -07:00
John McCutchan 268082769b Initial status file updates for $hot_reload_rollback
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2207653002 .
2016-08-02 11:03:44 -07:00
John McCutchan 8b3a8bbe0f Update status files now that tear off closure equality works across reloads
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2185133004 .
2016-07-28 12:42:12 -07:00
Regis Crelier 48060a653f Reverting bad fix of issue #26941.
Review URL: https://codereview.chromium.org/2179903009 .
2016-07-28 12:39:49 -07:00
William Hesse 118d55d79e Update status for html/js_util_test on IE.
This test was introduced in
https://codereview.chromium.org/2150313003

BUG=https://github.com/dart-lang/sdk/issues/26978
R=eernst@google.com

Review URL: https://codereview.chromium.org/2188663004 .
2016-07-28 15:30:48 +02:00
Regis Crelier 093bca5909 Temporarily skip test that became flaky after fixing #26941.
Review URL: https://codereview.chromium.org/2192723002 .
2016-07-27 22:38:42 -07:00
Regis Crelier f10ce1eb69 Skip new regression test crashing when precompiled.
Review URL: https://codereview.chromium.org/2186493005 .
2016-07-27 18:31:50 -07:00
Regis Crelier 11d340c51d Force local context allocation in finally clauses (fixes #26948).
Add regression test.

R=fschneider@google.com, hausner@google.com

Review URL: https://codereview.chromium.org/2188863002 .
2016-07-27 14:03:25 -07:00
Ryan Macnak 634a62c9df DBC: Add missing deopt info after stack overflow checks.
Fixes collecting a debugger stack trace at an interrupt.

Enable most vm-service tests.

R=zra@google.com

Review URL: https://codereview.chromium.org/2183993004 .
2016-07-27 12:25:54 -07:00
Stephen Adams 9d5fd9d5bd Avoid using call-through stub on calls to fields.
This usually removes the demand for the call-through stub and sometimes enables optimizations on the field load, e.g.:

    WhereIterator: {
      "^": "Iterator;_iterator,_f",
      moveNext$0: function() {
        for (var t1 = this._iterator; t1.moveNext$0();)
          if (this._f$1(t1.get$current()) === true)
            return true;
        return false;
      },
      _f$1: function(arg0) {
        return this._f.call$1(arg0);
      }
      ...
-->
    WhereIterator: {
      "^": "Iterator;_iterator,_f",
      moveNext$0: function() {
        var t1, t2;
        for (t1 = this._iterator, t2 = this._f; t1.moveNext$0();)
          if (t2.call$1(t1.get$current()) === true)
            return true;
        return false;
      },
      ...

BUG= https://github.com/dart-lang/sdk/issues/22197
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2180363002 .
2016-07-26 18:02:05 -07:00
Stephen Adams 94df5a0c24 dart2js: Avoid empty else clauses in generators.
R=sigurdm@google.com

Committed: a02c5798a4

Review URL: https://codereview.chromium.org/1916863002 .

Reverted: 803826256d
2016-07-26 09:58:34 -07:00
John McCutchan 50c141d298 Mark closure identity test as pass, fail for reload bots
BUG=

Review URL: https://codereview.chromium.org/2181233003 .
2016-07-26 06:38:06 -07:00
Jacob Richman 9648db46be TBR. Add back line that should not have been removed.
BUG=

Review URL: https://codereview.chromium.org/2179253002 .
2016-07-25 17:53:27 -07:00
Konstantin Shcheglov f8c32c5ea1 Issue 26860. Report CompileTimeErrorCode.FIELD_INITIALIZER_OUTSIDE_CONSTRUCTOR for parameters of function typed constructor parameters.
R=pquitslund@google.com, brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26860

Review URL: https://codereview.chromium.org/2178123003 .
2016-07-25 14:56:47 -07:00
Jacob Richman 410cde6023 Fix analyzer warnings in js_util_test, skip js_util_test in csp mode and baseline expectations for analyze_library.status
Update pkg/js CHANGELOG.md to address comment from previous CL.

BUG=

Review URL: https://codereview.chromium.org/2179153002 .
2016-07-25 13:20:25 -07:00
Jacob Richman 96ca5db7e5 Add JSNative utility class with static methods methods to efficiently manipulate typed JSInterop objects in cases where the member name is not known statically. These methods would be extension methods on JSObject if Dart supported extension methods. Update package js to export these methods. Implement in Dart2JS. Implement JS$ in dart2js.
BUG=
R=alanknight@google.com, sra@google.com

Review URL: https://codereview.chromium.org/2150313003 .
2016-07-25 09:59:01 -07:00
Johnni Winther 6549cd24af Split serialization tests further
+ add helpers to compute the split for reuse between tests.

R=whesse@google.com

Review URL: https://codereview.chromium.org/2162053005 .
2016-07-25 10:36:37 +02:00
William Hesse 5790e88f00 Update status for co19 test that also fails on linux Chrome 53.
Also change status for dart2js_native/native_call test from compile-time
error to a runtime error.

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2173653004 .
2016-07-22 18:51:22 +02:00
William Hesse 0502a04122 Update status for Chrome 53
BUG=
TBR=kustermann@google.com

Review URL: https://codereview.chromium.org/2175573003 .
2016-07-22 16:05:45 +02:00
Jacob Richman bbb0c3f727 Seems like this is all that is required to support callable JS objects. dartbug.com/25321
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/2164483004 .
2016-07-20 13:16:37 -07:00
John McCutchan f79756b88d Hot reload status file updates
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2164063002 .
2016-07-20 11:02:23 -07:00
William Hesse ca49303576 Revert "Add fast-mode Uri class."
This reverts commit 00090a0c72.

Revert "Add fast-mode Uri class."

This reverts commit 323ca7e410.

Revert "Fix regression for the one case where we deliberately don't follow the RFC."

This reverts commit b39e048c4b.

Revert "Cache hashCode in Uri implementations to improve performance when used as, e.g., Map key."

This reverts commit a11ad27723.

BUG=https://github.com/dart-lang/sdk/issues/26917
TBR=keertip@google.com

Review URL: https://codereview.chromium.org/2167663002 .
2016-07-20 14:32:52 +02:00
Jacob Richman bcf224b3e6 Regression tests for 25658 and 24817.
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2168493002 .
2016-07-19 17:08:58 -07:00
Alan Knight 4db29e8fbc Add a couple of additional XSS tests
BUG=

Review URL: https://codereview.chromium.org/2160413002 .
2016-07-19 13:37:45 -07:00
Keerti Parthasarathy 69a8b11f67 Fix for uri replace whene uri has fragment. Was adding a second '#'.
BUG=
R=het@google.com

Review URL: https://codereview.chromium.org/2158933003 .
2016-07-18 16:31:43 -07:00
Alan Knight 30b489578d Revert "Reapply zone tasks."
This reverts commit 6a7c037aa6.

BUG=

Review URL: https://codereview.chromium.org/2162643002 .
2016-07-18 13:12:36 -07:00
Harry Terkelsen c5728623b9 remove dependency on compiler from resolution
This is the first step of a refactoring that splits the resolution
phase from the backend. The end goal is that resolution can be run
without having to instantiate an entire compiler.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2123073003 .
2016-07-18 10:40:21 -07:00
Johnni Winther 941691650c Split out long-running serialization test and add timings to output
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/2156033002 .
2016-07-18 14:09:53 +02:00
Johnni Winther 3305201211 Serialize this-types in NativeBehavior separately.
BUG=
R=het@google.com

Review URL: https://codereview.chromium.org/2150333002 .
2016-07-18 10:42:23 +02:00
Alan Knight 2107c13ba2 Adjust FF/Win status for webgl extension tests
BUG=

Review URL: https://codereview.chromium.org/2161443002 .
2016-07-15 17:27:08 -07:00