languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:45:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
88730 commits 11 branches 6011 tags 1.4 GiB
Commit graph

128 commits

Author SHA1 Message Date
Samuel Rawlins 813ca7faf6 Revert "[analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter" 
This reverts commit 82143e6c95.

Reason for revert: This commit appears to have negatively affected the analyze benchmark:

* https://golem.corp.goog/Revision?repository=flutter-analyze&team=dartanalyzer&revision=114193

We need to revert and analyze it.

Original change's description:
> [analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter
>
> Bug: https://github.com/dart-lang/sdk/issues/49796
> Change-Id: Ide144ceb57bae94a71b9d1a7ec841d03363fc121
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258200
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/49796
Change-Id: I6ec04ffe8d85c417d138626ffa4f1a7ac7dafe2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268380
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-07 20:17:09 +00:00
Mateus Felipe C. C. Pinto 82143e6c95 [analyzer][meta] Refactor TargetKind to be a class, add a value in TargetKind to represent type parameter 
Bug: https://github.com/dart-lang/sdk/issues/49796
Change-Id: Ide144ceb57bae94a71b9d1a7ec841d03363fc121
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258200
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-04 23:38:40 +00:00
Sam Rawlins d77ded508e Report invalid mustCallSuper annotation targets 
Fixes https://github.com/dart-lang/sdk/issues/49499

Change-Id: Ibea55a78b58ee83b9290c33bca5e69039c995d55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252865
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-07-28 17:48:15 +00:00
Sam Rawlins aee2e21de8 Correct mustCallSuper documentation as per analyzer impl 
See must_call_super_test.dart for tests covered by this documentation.

Bug: https://github.com/dart-lang/sdk/issues/49499
Change-Id: I50e6546dda155cb133b8ad314db27a266a94fa00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-07-27 00:58:37 +00:00
Sam Rawlins 7280525117 Implement mustBeOverridden annotation and enforcement 
Fixes https://github.com/dart-lang/sdk/issues/30175
Fixes https://github.com/dart-lang/sdk/issues/28250

Change-Id: Id9c62448da9ade81258c2ae2355d05117057a8f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252463
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-07-25 22:17:18 +00:00
Devon Carew 580597c2eb [pkg/meta] analyze using package:lints 
Change-Id: Ie490a992eac0f8b6e784346c67c8c297e9d1d034
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250773
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-06 22:24:20 +00:00
Devon Carew ae727399f2 [pkg/meta] prep for publishing package:meta 1.8.0 
Change-Id: I74274bdc98c105115fd778a874de8724b5b133f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244561
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-05-16 21:56:05 +00:00
Devon Carew 2a20d4be24 [pkg] ensure each publishable package has a repository pubspec field 
Change-Id: I06c0d10c87c3f329098352a7abe9ef9fa0b1532e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/241504
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2022-04-19 22:13:51 +00:00
Alexander Thomas 30beab0f43 [infra] Add OWNERS to the Dart SDK 
* Add team "groups" in tools/OWNERS_<group name>.
* Add top-level OWNERS as a fallback.
* Add OWNERS for all top-level directories.
* Add OWNERS to all packages.

For additional background information see go/dart-sdk-owners.

TEST=No op until code-owners is enabled.
Bug: b/200915407
Change-Id: I7fe6116cc599c749cd50ca16151d6d6a801d99d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229147
Reviewed-by: Jonas Termansen <sortie@google.com>
 2022-02-14 14:06:34 +00:00
Marc Plano-Lesay 9d68fe751d Fix a typo 
Closes https://github.com/dart-lang/sdk/pull/47817
https://github.com/dart-lang/sdk/pull/47817

GitOrigin-RevId: a7bbf4d895136b4c304cc11dd2e83aa4f208be51
Change-Id: Ib60bfc53d77532ff782ba732a282f4c2a61d293a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221746
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2021-12-02 11:37:31 +00:00
pq dd35db6192 "master->main" migration 
Change-Id: I773e0a60a782f9e6678cea22e2a7d8fae48cffa3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212869
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-09-09 18:14:36 +00:00
Stephen Adams 55596f4c01 [dart2js] Implement package:meta/dart2js.dart in terms of @pragma 
Change-Id: I56777498f3c3b6f910eb8c7e066de4fc254c1708
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209040
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2021-08-16 18:02:39 +00:00
pq 1eb601b719 Update changelog to add UseResult.unless 
Change-Id: I4a74f2096efcd993d4fc168e0b7d509d8dcb327f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208867
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-08-04 16:03:59 +00:00
pq 9491cafc2f add UseResult.unless({... , this.parameterDefined}); 
Sample use:

```
@UseResult.unless(parameterDefined: 'count')
Matcher hasCount([int? count]) => Matcher();
```

See: https://github.com/dart-lang/sdk/issues/46727


Change-Id: I507659c09072157d67433f347d1fa6b511a93a7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208721
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-08-04 14:30:10 +00:00
Konstantin Shcheglov 5b39eb2f01 Prepare to publish meta 1.7.0 
Change-Id: I71e1db6cda7101df0afc64376b003c0c8b680dd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206144
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-07-07 21:02:53 +00:00
Konstantin Shcheglov 0f2e58367d Prepare to publish meta 2.0.0 
Adding any not private extension is a breaking change.
So, to add `TargetKindExtension` we need version `2.0.0`.

Bug: https://github.com/dart-lang/sdk/issues/46558
Change-Id: Ic23c95490f12805784460c40013711e9d99dbf23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-07-03 01:22:45 +00:00
Konstantin Shcheglov a6c37854f5 Prepare to publish meta 1.6.0 
Revert "Move TargetKind.displayString from analyzer to meta"

This reverts commit 6de639b71f.

Change-Id: Ie4bec18dbc22db81ddec50eb36f47282e8a0a7ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205904
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-07-03 00:00:05 +00:00
pq 25e4b7e6be prefer dart analyze to dartanalyzer 
Change-Id: I3076c816ce42aaa6afe4f80f7c156334dfc02805
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-07-02 22:41:55 +00:00
Konstantin Shcheglov a4a5f224e6 Prepare to publish meta 1.5.0 
Change-Id: Ie866fc10e60eed32e81bb75663ad63703d8e439b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205882
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-07-02 21:49:18 +00:00
Sam Rawlins 9f85dc07a7 Improve quality of @protected doc comment 
Fixes https://github.com/dart-lang/sdk/issues/29804

Start doc comment with a single-sentence summary.
https://dart.dev/guides/language/effective-dart/documentation#do-start-doc-comments-with-a-single-sentence-summary

Separate the first sentence of a doc comment into its own paragraph.
https://dart.dev/guides/language/effective-dart/documentation#do-separate-the-first-sentence-of-a-doc-comment-into-its-own-paragraph

Replace text which refers to "using" an "invocation" of a member with text which refers to "referencing" a member.

Explicitly call out mixins and superclass constraints.

Improve language around using "this" as a receiver.

Attempt to use more straightfoward sentences.

Change-Id: Ib465b640c217d3759455611116aef0545b5665fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201445
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-05-27 18:41:24 +00:00
Brian Wilkerson 6de639b71f Move TargetKind.displayString from analyzer to meta 
Change-Id: Ifa24fb96c97c6b7a2f27794e671672796c56331e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-05-26 19:37:40 +00:00
Konstantin Shcheglov e2756ed50a Prepare to publish meta 1.4.0 
Change-Id: I299ab2d6427a732447d1f0f2586a75055960b0d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201343
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2021-05-25 23:35:01 +00:00
Sam Rawlins e7d65d9822 Update docs on optionalTypeArgs to allow for functions, methods, typedefs 
Also minor edit to invalid_annotation_target_test.

Bug: https://github.com/dart-lang/sdk/issues/37714
Change-Id: Ie13a33625786d4a5fc7de2eee11d6adfad6cdcfd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201161
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2021-05-24 20:31:05 +00:00
pq 1bfa8610d1 add @useResult 
See: https://github.com/dart-lang/linter/issues/1888

Change-Id: Idd529c86236a4c2692104dc36cb0a7f0d5dd35aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200301
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-05-19 18:04:32 +00:00
creativecreatorormaybenot 9108f927ab Document same-library access for protected members 
I noticed that in the Flutter framework, `@protected` members are called from outside of instance methods. @Hixie responded:

> protected allows access from the same file

I think this should be documented.

Closes https://github.com/dart-lang/sdk/pull/45937
https://github.com/dart-lang/sdk/pull/45937

GitOrigin-RevId: c1a86d4039aeaa5a2126b505cad28e10fe361b0a
Change-Id: If0be693897abe10197516bdf854ec45fcb1be7fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-05-06 22:53:54 +00:00
Franklin Yow 03101c0c2b Update LICENSE 
Changes to comply to internal review

Closes https://github.com/dart-lang/sdk/pull/45568
https://github.com/dart-lang/sdk/pull/45568

TEST=CL contains no code changes.

No-Try: true
GitOrigin-RevId: 65796784e5fdfddaa021b5c55ad435b1db419700
Change-Id: I085a948f16dc9a0de128ed0bd456ae69adf6c124
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193888
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2021-04-07 10:28:38 +00:00
Nate Bosch d82e2b2e44 Prepare to publish js and meta for null safety 
Change-Id: Iecbe288b989e6053d1a1bd9372795b70e6ba05d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182360
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2021-02-02 21:33:17 +00:00
pq de787828b7 remove redundant experiment 
Since this package is opted-in, the experiment is no longer needed.

Change-Id: Ie5b855cc7b180ebcc30a3a4cb4001bbdc82c9c39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-11-11 16:55:22 +00:00
Nate Bosch 9ebbca4371 Bump SDK constraints in meta for pub 
Use a 2.12.0 lower bound since pub does not understand allowed
experiments for earlier versions.

Use a 3.0.0 upper bound to avoid a warning in pub and to give some
flexibility in publishing for stable.

Change-Id: I3540dc3c085ac120997e107cfed5a991ad3f5ec4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170202
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2020-11-03 20:45:37 +00:00
Jacob MacDonald af5501c232 allow 2.12 prerelease sdks for meta and js 
Change-Id: I4406a3c95993e2c8db4df3932a989f24f6a6ac05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169020
Auto-Submit: Jake Macdonald <jakemac@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
 2020-10-23 17:49:24 +00:00
Sam Rawlins b4f265290c Bump meta package to 1.3.0-nullsafety.4 
Change-Id: I693e4aee8c14177e3a72ef421b96637e4b1d2037
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-10-07 21:09:14 +00:00
Sam Rawlins afbb8f9063 Meta: introduce @internal annotation 
Fixes https://github.com/dart-lang/sdk/issues/28066

Change-Id: I200173e48bfbffa8460d6273c274d210b3be8606
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164244
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-09-24 00:25:29 +00:00
Nate Bosch 1c3808058d Prepare package:meta for the 2.11 dev SDKs 
Bump the upper bound to allow 2.10 stable and 2.11.0 dev SDK versions.

Change-Id: I54565fcb90c18438814cc30aa04f51807043af6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163762
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2020-09-22 00:16:02 +00:00
pq eb30e43940 specify targets for @doNotStore 
Change-Id: I22546585fb189e4536e16a38488ce2e8b3b7fe52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160740
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-29 01:11:03 +00:00
Jacob MacDonald 146ad014d9 update js/meta for the 2.10 dev sdk 
- bumps the meta version so it can be published
- updates sdk constraints to be consistent with all other packages (should have been equivalent anyways)

Change-Id: I83520d291625f13b0029e28aecb9714f365a75b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155460
Reviewed-by: William Hesse <whesse@google.com>
Auto-Submit: Jake Macdonald <jakemac@google.com>
 2020-07-22 15:28:34 +00:00
William Hesse f88ce7aef5 Increase Dart version to 2.10 
Change-Id: Ic6b556f935602834564aca24690608aa624efa43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155440
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2020-07-22 13:22:07 +00:00
Brian Wilkerson 896f874b9f An initial definition of the Target annotation 
Change-Id: I6980da1e869c57b15a8bd068fef17f33d6a884ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154380
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-07-17 19:01:17 +00:00
Jacob MacDonald cf13fd9fb8 update meta constraint to allow <=2.9.10 sdks 
Change-Id: Iff9d5a7f7a331b9ffd75e67cadcb4b43a2a4fe55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154841
Auto-Submit: Jake Macdonald <jakemac@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-07-17 16:29:40 +00:00
Jake Macdonald 3d44605c04 Revert "allow the 2.9.x stable sdk in the meta null_safety prerelease" 
This reverts commit 0a2f674e28.

Reason for revert: This accidentally allows 2.10 dev releases as well

Original change's description:
> allow the 2.9.x stable sdk in the meta null_safety prerelease
> 
> Change-Id: I383e630cf4edba19e4b8ee38adfb0c276eff1d33
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154750
> Auto-Submit: Jake Macdonald <jakemac@google.com>
> Commit-Queue: Jake Macdonald <jakemac@google.com>
> Commit-Queue: Nate Bosch <nbosch@google.com>
> Reviewed-by: Nate Bosch <nbosch@google.com>

TBR=jakemac@google.com,nbosch@google.com

Change-Id: I3461eeda4155ca40e4a80cc492b61d10d6c83646
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154820
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
 2020-07-17 14:29:11 +00:00
Jacob MacDonald 0a2f674e28 allow the 2.9.x stable sdk in the meta null_safety prerelease 
Change-Id: I383e630cf4edba19e4b8ee38adfb0c276eff1d33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154750
Auto-Submit: Jake Macdonald <jakemac@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2020-07-16 23:01:54 +00:00
Brian Wilkerson 73e9554779 Update meta to correspond to the published 1.2.2 
Change-Id: I9dcbd9237d25948eb62e3ba68403436c64c70845
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153822
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2020-07-09 17:38:32 +00:00
Jacob MacDonald 6dcd45f2b3 update nullsafety release version 
Change-Id: I0620fa89b971f363766cf4fa3e1f0ad33193ab28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153820
Auto-Submit: Jake Macdonald <jakemac@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
 2020-07-09 16:39:12 +00:00
Tess Strickland 06cb010247 Revert "Add unawaited to package:meta" 
This reverts commit 0d44449aaa.

Reason for revert: Breaks Flutter HHH and the Dart->Flutter roll.

Original change's description:
> Add unawaited to package:meta
> 
> Change-Id: I09df4989591327bd4d148e73a5887b900902576c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152680
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Jake Macdonald <jakemac@google.com>

TBR=brianwilkerson@google.com,jakemac@google.com

Change-Id: I71f491bccc37508a24b7f6f9d051ed914bafeccd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153351
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
 2020-07-07 08:14:51 +00:00
Brian Wilkerson 0d44449aaa Add unawaited to package:meta 
Change-Id: I09df4989591327bd4d148e73a5887b900902576c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152680
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
 2020-07-06 21:57:52 +00:00
pq b42dc32514 add @doNotStore entry 
Change-Id: I025b3c71ce05383c93adad0989e57f69972d3304
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152602
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-06-25 20:12:32 +00:00
pq 37ba50cd0c Add @doNotStore. 
See: https://github.com/dart-lang/sdk/issues/41941

As per the conversation there, I opted not to handle the formal parameter case.

(My thinking being we could add it as a refinement.)

Change-Id: Ia91c525c8ea4ce26d9debe3f52af9a3018e50d6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152540
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 17:27:52 +00:00
Jacob MacDonald e18b937c1f opt meta into null safety 
Change-Id: I004665a1b127d21f794ec3470dae0f7799ddfc06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151980
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Jake Macdonald <jakemac@google.com>
 2020-06-22 18:51:56 +00:00
Robert Nystrom 328f1be1fe Opt package:meta in to null safety. 
This is done by setting the SDK constraint min version in the package's
pubspec to 2.9.0 which is the version that CFE currently uses to mean
"opt in".

However, the pre-built SDK currently checked into the repo can't handle
that version. To work around that, this CL has a gross hack to simply
omit the language version in the generated package config if the
pubspect's version is 2.9. This has the effect of telling CFE to use
the current language version, which is what we want, while also allowing
us to put the right SDK constraint in the package's pubspec.

Change-Id: I51c2952003c83b74fb6f3344c93839fbd267a3ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145020
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-04-28 03:54:48 +00:00
pq 2d7235c14d typos 
Change-Id: Idbbd0ad4d6097f7c1c5a70de5f3fa4c2d13ff2c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-02 23:09:17 +00:00
pq a688de0371 Add deprecated member messages 
Change-Id: I8efa2244b3f03a1af44eca93ed4441a255c6cb68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129923
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-02 15:41:26 +00:00