Commit graph

38549 commits

Author SHA1 Message Date
William Hesse e9b92b73fe Start working on version 1.18 of Dart
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org/2039093004 .
2016-06-06 23:31:00 +02:00
John McCutchan 45e277a2cb Fix MacOS build
BUG=

Review URL: https://codereview.chromium.org/2035383004 .
2016-06-06 14:20:39 -07:00
John McCutchan 6fd8fd7987 Rework standalone to use a synchronous loader that does not invoke Dart code
- [x] The first caller of the tag handler blocks, recursive callers queue work and exit.
- [x] Use a NativeMessageHandler to receive I/O results from the service isolate.
- [x] Preserve load error message format.
- [x] Move packages map into service isolate.
- [x] Wire up Todd's native URI code.

R=turnidge@google.com

Review URL: https://codereview.chromium.org/1998963003 .
2016-06-06 14:15:01 -07:00
Konstantin Shcheglov ed8154a53c Add put/getSourceErrorsInLibrary to IncrementalCache.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2042883002 .
2016-06-06 13:27:25 -07:00
William Hesse 49dec47c97 Update status for failing vm precompilation test.
BUG=https://github.com/dart-lang/sdk/issues/26607
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2044613002 .
2016-06-06 13:15:33 -07:00
pq 8b1440fd2b Fix @protected checks to play nice with generic supers (linter#257).
Fixes: https://github.com/dart-lang/linter/issues/257.

(Pardon the member-sorting churn in `hint_code_test`.)

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2045693002 .
2016-06-06 13:14:13 -07:00
pq 8b779f33c0 Fix @protected to include closure references (linter#255).
Generalizes the check for invalid protected access.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2041873003 .

Fixes: https://github.com/dart-lang/linter/issues/255.
2016-06-06 11:43:30 -07:00
Konstantin Shcheglov e6d2b37065 Start using crypto 1.1.1 and tweak MD5 computation.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2041963002 .
2016-06-06 11:37:08 -07:00
Konstantin Shcheglov e87a9c955c Start adding experimental incremental analysis mode into CLI analyzer.
At the moment it is not very useful, because it does not use or store
errors from incremental cache yet. But I hope to implement this soon.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2039773004 .
2016-06-06 11:35:55 -07:00
Todd Turnidge 424ca27a15 Fix various nefarious problems with the script table used in source reports.
Before we could get duplicate or spurious script table entries.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2038203002 .
2016-06-06 11:22:46 -07:00
Konstantin Shcheglov 2ef55609fc Resynthesize enums lazily.
Now everything is resynthesized lazily, so we can remove 'unitHolder'.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2043783002 .
2016-06-06 08:55:29 -07:00
Konstantin Shcheglov df61e8d64a Resynthesize enum fields lazily.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2040673002 .
2016-06-06 08:32:07 -07:00
Erik Ernst 6d56db592b Revert "New tests for initializing formal access."
This reverts commit 543a51ff3e
because several status file updates are needed.

Review URL: https://codereview.chromium.org/2039243002 .
2016-06-06 16:07:03 +02:00
Erik Ernst 543a51ff3e New tests for initializing formal access.
This CL adds tests for previously uncovered elements of the semantics
and includes fixes such that the desired behavior is obtained. In
particular, an `isInitializingFormal` element may now occur in contexts
where it wasn't expected until now, and changes were made to handle it.
It is also checked that a capture of an initializing formal (in a
function literal) captures the parameter, not the field.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2039833002 .
2016-06-06 15:55:44 +02:00
danrubel 2d310f1e67 improve completions in closures and switch statements
This addresses several situations where the parser interprets "as" as
part of an "as" expression, but the user is trying to enter the "async"
keyword or an identifier starting with "as".

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2034713004 .
2016-06-06 08:09:44 -04:00
Johnni Winther e97c1c673f Align semantics of getDefaultConstructor()
The modelx implementation of getDefaultConstructor() (surprisingly)
returned constructors with only optional arguments. This CL aligns the
modelz implementation with this, adding a TODO to figure out what the
best behavior is.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2033893004 .
2016-06-06 11:23:22 +02:00
Johnni Winther 153c36ce39 Don't crash when tree shaking is disabled
When tree shaking is disabled, type checking crashed on member lookup into serialized classes.
Also classes are now ensured to be resolved when computing lookup.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2031293002 .
2016-06-06 11:08:01 +02:00
Johnni Winther b11a92f2ed Handle use of fromEnvironment from serialized data.
This CL removes the [intEnvironment], [boolEnvironment] and [stringEnvironment]
from [Compiler] and instead determine .fromEnvironment directly from the
constructor element itself.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2033383002 .
2016-06-06 10:52:41 +02:00
Johnni Winther 0b926d64a4 Handle deferred access of unserialized code.
This CL fixes crashes in deferred_load when using serialized dart:core:
- resolution impacts are cached in [Resolution] for both serialized and unserialized elements.
- type variable constants (for mirrors) are computed using [ConstantExpression]s.
- LibraryElementZ.getImportsFor returns the empty list; thus still not valid for deferred access in serialized code.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2034973003 .
2016-06-06 10:26:37 +02:00
Lasse R.H. Nielsen c7e601c90d Revert "Add package-config tests where test is running in Isolate.spawn-isolates."
This reverts commit f3f6d1e00d.

Running a new process doesn't correctly pass empty command line parameters on Windows.

Committed: 151d1b6796

R=floitsch@google.com

Committed: 2d8e63e985

Review URL: https://codereview.chromium.org/2038033002.
2016-06-06 08:46:58 +02:00
Harry Terkelsen 417b36a942 mark newly failing html test in safari
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2034283002 .
2016-06-03 16:17:33 -07:00
Sigmund Cherem 99792d9a79 fix remaining windows issues
TBR=het@google.com

Review URL: https://codereview.chromium.org/2035113004 .
2016-06-03 15:55:35 -07:00
Stephen Adams b37747934e Specialize Symbol.hashCode
Patch internal.Symbol.hashCode and specialize JS version to avoid
recomputing String.hashCode

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2038853003 .
2016-06-03 15:10:51 -07:00
Sigmund Cherem 5e9f7a8882 Fix IE status
Review URL: https://codereview.chromium.org/2040593002 .
2016-06-03 14:49:05 -07:00
Konstantin Shcheglov b473d6f451 Resynthesize CompilationUnitElement.types lazily.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2036203005 .
2016-06-03 14:42:37 -07:00
Regis Crelier 4524d15d52 Fix sed expression to substitute recalculated fingerprints after format change.
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2031153002 .
2016-06-03 14:38:16 -07:00
Konstantin Shcheglov 674fc7829b Create ClassElement.type lazily in ClassElementImpl and EnumElementImpl.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2038153003 .
2016-06-03 14:35:16 -07:00
Harry Terkelsen c59d264131 fix dart2js-mac10.11-safari tests
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2038173002 .
2016-06-03 14:29:02 -07:00
William Hesse fbf301c0ad Run dartium buildbot tests under xvfb on linux
Previously, the entire builder run was under xvfb, now only the tests are.

R=het@google.com
BUG=

Review URL: https://codereview.chromium.org/2038903002 .
2016-06-03 14:14:13 -07:00
Harry Terkelsen 1fa0ccf869 fix tests for dart2js-mac10.11-chrome-be
BUG=

Review URL: https://codereview.chromium.org/2038153002 .
2016-06-03 13:57:58 -07:00
Konstantin Shcheglov dbfce10aae Remove _DeferredClassElement because ClassElementImpl is now lazy.
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2042473002 .
2016-06-03 13:44:52 -07:00
Sigmund Cherem 63a8582514 Fix again linux#3: it was passing in jsshell, moved the entry to the chrome section.
TBR=het@google.com

Review URL: https://codereview.chromium.org/2034003003 .
2016-06-03 13:44:24 -07:00
Sigmund Cherem 6740e339c6 Fix co19 status file for dart2js-linux-chromeff-4-4-be
R=het@google.com

Review URL: https://codereview.chromium.org/2031313003 .
2016-06-03 13:26:34 -07:00
Konstantin Shcheglov 7af5b1c531 Resynthesize ClassElementImpl fields and property accessors lazily.
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2039573002 .
2016-06-03 13:10:24 -07:00
Sigmund Cherem bc0fe505b9 fix status of co19 for dart2js-linux-chromeff-3-4-be
R=het@google.com

Review URL: https://codereview.chromium.org/2038923002 .
2016-06-03 13:03:44 -07:00
Harry Terkelsen 31895ea4e1 triage more dart2js-linux tests
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2033893005 .
2016-06-03 10:43:39 -07:00
Todd Turnidge c6fbc89f43 Allow double-slash in uris. This is needed for data uri parsing.
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2035123002 .
2016-06-03 09:42:25 -07:00
Konstantin Shcheglov 98553a4917 Resynthesize constructors lazily.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2030403002 .
2016-06-03 09:38:22 -07:00
Konstantin Shcheglov 17adc3ccd1 Compute ConstructorElement.returnType/type dynamically.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2033293003 .
2016-06-03 09:24:21 -07:00
Paul Berry af8c6342bf Cleanup: remove package "analyzer2dart".
This was an experimental effort to merge the front ends of analyzer and
dart2js, and to my knowledge it has not received significant attention
in over a year.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2037123002 .
2016-06-03 09:23:30 -07:00
Paul Berry 86046f795b Fix resynthesis tests after dead code detection improvements.
Commit 38e8d9702b improved analyzer's
detection of dead code, causing some of the test cases in
resynthesize_test.dart to have dead code hints.  This CL adds
"allowErrors: true" to those tests so that they won't fail.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2037973003 .
2016-06-03 09:19:57 -07:00
pq 5a6c934a0a Fix @protected access check from within defining class (#26614).
Fixes: https://github.com/dart-lang/sdk/issues/26614.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2032363003 .
2016-06-03 09:09:46 -07:00
Zachary Anderson de78ddbc55 DBC: Collect type feedback for fastpath smi ops
R=turnidge@google.com, vegorov@google.com

Review URL: https://codereview.chromium.org/2015113002 .
2016-06-03 09:09:13 -07:00
Zachary Anderson 7cd20ac709 Fix status file for asan test no longer crashing
related #26487

Review URL: https://codereview.chromium.org/2037753003 .
2016-06-03 08:50:53 -07:00
Zach Anderson 44796ed02d Move Windows build output from //build to //out
This is needed in order to begin migration to GN because
third-party dependencies and GN boilerplate expect GN
boilerplate to be in //build.

R=asiva@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2027063003 .
2016-06-03 08:28:48 -07:00
Lasse R.H. Nielsen 2d8e63e985 Revert "Add package-config tests where test is running in Isolate.spawn-isolates."
This reverts commit f3f6d1e00d.

Running a new process doesn't correctly pass empty command line parameters on Windows.

Committed: 151d1b6796

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2038033002.
2016-06-03 17:12:17 +02:00
Lasse R.H. Nielsen 0bd6b7e924 Add package-config tests where test is running in Isolate.spawn-isolates.
R=floitsch@google.com

Committed: f3f6d1e00d

Committed: eda2a81c0c

Review URL: https://codereview.chromium.org/2020653002.
2016-06-03 16:48:21 +02:00
Lasse R.H. Nielsen eda2a81c0c Add package-config tests where test is running in Isolate.spawn-isolates.
R=floitsch@google.com

Committed: f3f6d1e00d

Review URL: https://codereview.chromium.org/2020653002.
2016-06-03 16:35:27 +02:00
Lasse R.H. Nielsen 151d1b6796 Revert "Add package-config tests where test is running in Isolate.spawn-isolates."
This reverts commit f3f6d1e00d.

Running a new process doesn't correctly pass empty command line parameters on Windows.

Review URL: https://codereview.chromium.org/2038033002 .
2016-06-03 15:34:52 +02:00
Lasse R.H. Nielsen f3f6d1e00d Add package-config tests where test is running in Isolate.spawn-isolates.
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2020653002 .
2016-06-03 13:53:50 +02:00